From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C5284A00E6 for ; Wed, 20 Mar 2019 14:18:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9222C5B3A; Wed, 20 Mar 2019 14:18:53 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 727D05B38; Wed, 20 Mar 2019 14:18:52 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id j9so2732506wrn.6; Wed, 20 Mar 2019 06:18:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=RLd8JW28GgrQnkOMn3nWrETLPVMgE01TsMDZoFm0IGc=; b=OadlSGPmX1LtenvgFkNaLhvHvjIMSuFUxeJeod/O/3hofI99iGJX16ISY6iFxHYhHY plUP6DVT2hk4GktQwVFn9O615Y5YNkS8c+ogavTJnlb9qvuY9lF+wzQmqSB8+OPjRNSh Th+K3dQwhCpwOgDr85q4Gy0SK3/xcZHr9Ux3HbW15FLWyY2PBmSptwrLAmBlNVksYKkG fwKasM4TdNxxw2+F9+EKsw4WpYKX6fp9itEN6/k+MhbSPwuO8Ursjfy2625xY5L+vxoq W2FGJRQWcgbc5TuEIUtJE6j9MjcV0hJ8gCr+V0ZgYv3F3V4QQyMi0IWhY4KLRi+IxiAO OHjg== X-Gm-Message-State: APjAAAWgu5A7iWm4x2wNVMWq/2e6XaRmLdN401mN/IAjDcoofmnCQOQe ulOxTIE5iRJd/VQ3sFp1kbg= X-Google-Smtp-Source: APXvYqy090p45eZ0KogcuOQTfNP7J2w8ZtZAcahihzV30G0JgcObRBxQga7TltUczdljrm3N50EPQw== X-Received: by 2002:a5d:510b:: with SMTP id s11mr22886189wrt.131.1553087932084; Wed, 20 Mar 2019 06:18:52 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id b10sm4010207wrt.86.2019.03.20.06.18.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Mar 2019 06:18:51 -0700 (PDT) Message-ID: From: Luca Boccassi To: Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" Cc: "stable@dpdk.org" , "gavin.hu@arm.com" , "viktorin@rehivetech.com" , Jerin Jacob Kollanukkaran , "bruce.richardson@intel.com" Date: Wed, 20 Mar 2019 13:18:50 +0000 In-Reply-To: <84033239dca8e91d432be6cc01bbdb65803c3af8.camel@marvell.com> References: <20181224125627.25690-1-bluca@debian.org> <20190107141130.24360-1-bluca@debian.org> <84033239dca8e91d432be6cc01bbdb65803c3af8.camel@marvell.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] build: use generic march on arm64 when using 'default' machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320131850.qrvURSqbYXGPBkcvSSgyx_zBvNw0N0NzjjF_vUItwwE@z> On Wed, 2019-03-20 at 05:01 +0000, Pavan Nikhilesh Bhagavatula wrote: > On Mon, 2019-01-07 at 14:11 +0000, Luca Boccassi wrote: > > When building for generic distribution we need a stable baseline > > architecture, or depending on the build worker the result will > > vary. > >=20 > > Force the default flags if the user explicitly sets machine=3Ddefault > > at configuration time. > >=20 > > Fixes: b1d48c41189a ("build: support ARM with meson") > > Cc: stable@dpdk.org > >=20 > > Signed-off-by: Luca Boccassi > > Acked-by: Bruce Richardson > > --- > > v2: fix typo in commit message, remove variable used only once > > v3: put back temporary variable, as "machine" gets overwritten > > by the function and loses the original value before we need > > it. > >=20 > > config/arm/meson.build | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > >=20 > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index dae55d6b2..614139534 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -6,6 +6,7 @@ > > march_opt =3D '-march=3D@0@'.format(machine) > > =20 > > arm_force_native_march =3D false > > +arm_force_default_march =3D (machine =3D=3D 'default') > > =20 > > machine_args_generic =3D [ > > ['default', ['-march=3Darmv8-a+crc+crypto']], > > @@ -105,7 +106,11 @@ else > > cmd_generic =3D ['generic', '', '', 'default', ''] > > cmd_output =3D cmd_generic # Set generic by default > ^ > > machine_args =3D [] # Clear previous machine args > > - if not meson.is_cross_build() > > + if arm_force_default_march and not meson.is_cross_build() > > + machine =3D impl_generic > > + cmd_output =3D cmd_generic >=20 > Isn't this assignment redundant as it is already done above? >=20 > Acked-by: Pavan Nikhilesh Removed in v4, thanks. --=20 Kind regards, Luca Boccassi