From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DAAFDA00E6 for ; Wed, 20 Mar 2019 19:51:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C2051B13F; Wed, 20 Mar 2019 19:51:10 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id D71E95A for ; Wed, 20 Mar 2019 19:51:07 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2KIbqfG000974; Wed, 20 Mar 2019 11:51:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=U9yhlNJu3f3MAsb2iva2LqK0/L4a7QYaz34eTYQ4rtY=; b=vK5NijGibyrCn5jwZCNo/1CDBZ9Zd9ped9ZDGbpKuDhBjEl0pBPXQfixPZmNlDhip9na PFE79XwoN3L6qn/r8Ro2dWN+xQ7etwXhX+MYJtiiv48sBc0FpbGCBU3FMY8QUN8nmnGr uIlbT64145Z563w9yCV5yNz/BPdCaqF5PdA5rGH9/r0B/bVaRllAkWjPQuGMCLJJi5d1 cyS1B8v0jWCmJMJiTzAd9vNNMgQ4+ZgvBCCo17Dj5wh+3OsitBb5z7OotPzvM3MgdiQW 31Csn9+pHrREAsnTCr6tmc4MNg1r+z9Y+ubfDsueFSTkBMosrreedKSTxcvVBznX7Nv1 HA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2rbjr6hrwq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 20 Mar 2019 11:51:05 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 20 Mar 2019 11:50:56 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 20 Mar 2019 11:50:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U9yhlNJu3f3MAsb2iva2LqK0/L4a7QYaz34eTYQ4rtY=; b=azxe3KPZwGbf3+lI/05fKgw/LcCQyKC5wGut9mfwnxsd9yrZHF9y0vbNZJBB7TvyF/OVK9Cf/j67MNGX+orMBx/eirkOmjsI0jDMvnYBKmTwBTpSmJePhcDU2spNAZVF+e9YAJCcrimE28Zfjjupyx02IgHNLZ+i+RnyPBgyFyU= Received: from MN2PR18MB2398.namprd18.prod.outlook.com (20.179.81.144) by MN2PR18MB2784.namprd18.prod.outlook.com (20.179.23.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Wed, 20 Mar 2019 18:50:54 +0000 Received: from MN2PR18MB2398.namprd18.prod.outlook.com ([fe80::2117:f855:a2e6:593f]) by MN2PR18MB2398.namprd18.prod.outlook.com ([fe80::2117:f855:a2e6:593f%2]) with mapi id 15.20.1709.015; Wed, 20 Mar 2019 18:50:54 +0000 From: Liron Himi To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" , "Trahe, Fiona" , "Doherty, Declan" , "De Lara Guarch, Pablo" , Michael Shamis , "akhil.goyal@nxp.com" , "ravi1.kumar@amd.com" , "tdu@semihalf.com" , Alan Winkowski CC: Liron Himi Thread-Topic: [RFC] cryptodev/sym: GCM IV len != 12 byte case Thread-Index: AdTfSeDR58Xinq03QgGH1UrdmGxm2QAA+ncw Date: Wed, 20 Mar 2019 18:50:54 +0000 Message-ID: References: <06EE24DD0B19E248B53F6DC8657831551B14CD9F@hasmsx109.ger.corp.intel.com> In-Reply-To: <06EE24DD0B19E248B53F6DC8657831551B14CD9F@hasmsx109.ger.corp.intel.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.132.232.126] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f5a85ff-181e-4960-2ae2-08d6ad64fb3c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:MN2PR18MB2784; x-ms-traffictypediagnostic: MN2PR18MB2784: x-microsoft-antispam-prvs: x-forefront-prvs: 098291215C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(376002)(346002)(396003)(39860400002)(53754006)(189003)(199004)(110136005)(52536014)(105586002)(71200400001)(256004)(71190400001)(486006)(2201001)(11346002)(476003)(6246003)(76176011)(4326008)(66066001)(790700001)(7696005)(2501003)(316002)(99286004)(25786009)(186003)(3846002)(107886003)(6116002)(9686003)(478600001)(33656002)(68736007)(74316002)(5660300002)(6436002)(106356001)(26005)(446003)(97736004)(2906002)(53546011)(8936002)(6636002)(8676002)(6506007)(6306002)(102836004)(86362001)(229853002)(54896002)(55016002)(14454004)(81156014)(81166006)(7736002)(53936002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2784; H:MN2PR18MB2398.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lSjoCN/p1Yl9iY9grwwX0nFEIuMsQXXfbPpmMQKBbfkmvvpcpHY5WjGHAjqgpr4Rr7wSkNhLBOdS85mBa/PpG5q02/oDoCeIVHbP9LPKT8vSuXqasB4hd/eInVqocUzeR7KW1gFPJmoYiwva5nkZgGGhu7f4EL58McfrPnyFQdKLuG8SL/XFSWW513fAYoUNkW3qE+D5J3RDcH9dBkkUeuxUQIGShwFCjlRVyRNPVKvQxG/yTObt7gjPtPpKf5CP4+MPGpQFDgWLxt25ELeuLM5aAX6Tf78Gf5w9WQaawGwby+a/u0OgJm1XcJwzTYyBXIWyk65aJEHQJLVJmZP/vXP/UyTu3hAd5bmzIRuqkc6fLIwQuKYZCDO/B4ozoEzXzCPzAPKO9grcLKhRwGlcEsbVr2QsXI/GkkApCjBFung= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1f5a85ff-181e-4960-2ae2-08d6ad64fb3c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2019 18:50:54.1662 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2784 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-20_11:, , signatures=0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC] cryptodev/sym: GCM IV len != 12 byte case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320185054.5Tv867VM3RMzKGgVSrRugSR36_EF6kFWSAhnMJ6USys@z> + Michael From: Kusztal, ArkadiuszX Sent: Wednesday, March 20, 2019 20:47 To: dev@dpdk.org; Trahe, Fiona ; Doherty, Declan ; De Lara Guarch, Pablo ; akhil.goyal@nxp.com; ravi1.kumar@amd.com; tdu@semihalf.com; Liron Him= i ; Alan Winkowski Subject: [EXT] [RFC] cryptodev/sym: GCM IV len !=3D 12 byte case External Email ________________________________ Hi all, There is a proposition to amend a bit API due to the following lines: * - For GCM mode, this is either 12 (for 96-bit IVs) * or 16, in which case data points to J0. ... } iv; /**< Initialisation vector parameters */ Problem arise when driver cannot support J0 input, right now we know that O= PENSSL PMD works with IV instead of J0 when iv_len !=3D 12. So it may be that we have to somehow support both. There are two options, a= nd I am very curious about community opinion. 1. Add a flag to aead_xform.iv to supports IV or J0 like this: uint8_t IV_used; And this could be reflected in capabilities. Of course for 96bits IV this f= ield would not be used, so it would had to be set only for iv.length !=3D 1= 2 1. Change API comments to something like: * - For GCM mode, this is either 12 (for 96-bit IVs), * - for IV length different than 96 bits it is or J0 or IV, * - refer to specific driver rst or capabilities which one * - is supported, etc. (J0 by definition is of 16 bytes len) I cc'ing maintainers of drivers that support iv_len !=3D 16 bytes. Cannot check how it works as I have no hw. Regards, Arek