DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] drivers/virtio: fix duplicate naming of include guard
@ 2019-03-20 13:57 Andrius Sirvys
  2019-03-20 13:57 ` Andrius Sirvys
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Andrius Sirvys @ 2019-03-20 13:57 UTC (permalink / raw)
  To: dev, Maxime Coquelin, Tiwei Bie, Zhihong Wang
  Cc: stable, Andrius Sirvys, jianfeng.tan

The LGTM static code analysis tool is reporting

"The macro name '_VHOST_NET_USER_H' of this include guard is used
in 2 different header files."

lib/librte_vhost/vhost_user.h has the same include guard.
Renamed the include guard in vhost.h to differentiate.

Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer")
Cc: jianfeng.tan@intel.com
Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
---
 drivers/net/virtio/virtio_user/vhost.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_user/vhost.h b/drivers/net/virtio/virtio_user/vhost.h
index 83a85cc..f8d26b6 100644
--- a/drivers/net/virtio/virtio_user/vhost.h
+++ b/drivers/net/virtio/virtio_user/vhost.h
@@ -2,8 +2,8 @@
  * Copyright(c) 2010-2016 Intel Corporation
  */
 
-#ifndef _VHOST_NET_USER_H
-#define _VHOST_NET_USER_H
+#ifndef ANOTHER_VHOST_NET_USER_H
+#define ANOTHER_VHOST_NET_USER_H
 
 #include <stdint.h>
 #include <linux/types.h>
-- 
2.7.4

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-03-27 11:13 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 13:57 [dpdk-dev] [PATCH] drivers/virtio: fix duplicate naming of include guard Andrius Sirvys
2019-03-20 13:57 ` Andrius Sirvys
2019-03-21  6:19 ` Rami Rosen
2019-03-21  6:19   ` Rami Rosen
2019-03-21  7:59 ` Tiwei Bie
2019-03-21  7:59   ` Tiwei Bie
2019-03-21  9:26   ` Maxime Coquelin
2019-03-21  9:26     ` Maxime Coquelin
2019-03-21 10:09 ` [dpdk-dev] [PATCH v2] " Andrius Sirvys
2019-03-21 10:09   ` Andrius Sirvys
2019-03-22  6:06   ` Tiwei Bie
2019-03-22  6:06     ` Tiwei Bie
2019-03-27 11:13   ` Maxime Coquelin
2019-03-27 11:13     ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).