From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3B64AA00E6 for ; Thu, 21 Mar 2019 11:58:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BED561B487; Thu, 21 Mar 2019 11:58:06 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 755B01B160 for ; Thu, 21 Mar 2019 11:58:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 03:58:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,252,1549958400"; d="scan'208";a="153780817" Received: from mhajkowx-mobl.ger.corp.intel.com ([10.104.14.169]) by fmsmga002.fm.intel.com with ESMTP; 21 Mar 2019 03:58:01 -0700 From: Hajkowski To: david.hunt@intel.com Cc: dev@dpdk.org, Marcin Hajkowski Date: Thu, 21 Mar 2019 11:55:04 +0100 Message-Id: <20190321105506.6656-3-marcinx.hajkowski@intel.com> X-Mailer: git-send-email 2.20.1.windows.1 In-Reply-To: <20190321105506.6656-1-marcinx.hajkowski@intel.com> References: <20190321105506.6656-1-marcinx.hajkowski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 2/4] power: extend guest channel api for reading X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190321105504.UpmDRFCYFu20GHd5e759h9jRUCGCiHr3stTY7QmUT7w@z> From: Marcin Hajkowski Added new experimental API rte_power_guest_channel_receive_msg which gives possibility to receive messages send to guest. Signed-off-by: Marcin Hajkowski --- lib/librte_power/channel_commands.h | 5 ++ lib/librte_power/guest_channel.c | 65 ++++++++++++++++++++++++++ lib/librte_power/guest_channel.h | 35 ++++++++++++++ lib/librte_power/rte_power_version.map | 1 + 4 files changed, 106 insertions(+) diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h index e7b93a797..33fd53a6d 100644 --- a/lib/librte_power/channel_commands.h +++ b/lib/librte_power/channel_commands.h @@ -28,6 +28,11 @@ extern "C" { #define CPU_POWER_SCALE_MIN 4 #define CPU_POWER_ENABLE_TURBO 5 #define CPU_POWER_DISABLE_TURBO 6 + +/* Generic Power Command Response */ +#define CPU_POWER_CMD_ACK 1 +#define CPU_POWER_CMD_NACK 2 + #define HOURS 24 #define MAX_VFS 10 diff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c index 9cf7d2cb2..3213fa769 100644 --- a/lib/librte_power/guest_channel.c +++ b/lib/librte_power/guest_channel.c @@ -10,6 +10,7 @@ #include #include #include +#include #include @@ -19,6 +20,9 @@ #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1 +/* Timeout for incoming message in milliseconds. */ +#define TIMEOUT 10 + static int global_fds[RTE_MAX_LCORE] = { [0 ... RTE_MAX_LCORE-1] = -1 }; int @@ -125,6 +129,67 @@ int rte_power_guest_channel_send_msg(struct channel_packet *pkt, return guest_channel_send_msg(pkt, lcore_id); } +int power_guest_channel_read_msg(struct channel_packet *pkt, + unsigned int lcore_id) +{ + int ret; + + struct pollfd fds; + fds.fd = global_fds[lcore_id]; + fds.events = POLLIN; + + ret = poll(&fds, 1, TIMEOUT); + if (ret == 0) { + RTE_LOG(DEBUG, GUEST_CHANNEL, "Timeout occurs during poll function.\n"); + return -1; + } else if (ret < 0) { + RTE_LOG(ERR, GUEST_CHANNEL, "Error occurred during poll function: %s\n", + strerror(ret)); + return -1; + } + + void *buffer = pkt; + + if (lcore_id >= RTE_MAX_LCORE) { + RTE_LOG(ERR, GUEST_CHANNEL, "Channel(%u) is out of range 0...%d\n", + lcore_id, RTE_MAX_LCORE-1); + return -1; + } + + if (global_fds[lcore_id] < 0) { + RTE_LOG(ERR, GUEST_CHANNEL, "Channel is not connected\n"); + return -1; + } + + int buffer_len = sizeof(*pkt); + + while (buffer_len > 0) { + ret = read(global_fds[lcore_id], + buffer, buffer_len); + if (ret < 0) { + if (errno == EINTR) + continue; + return -1; + } + /* No data has been read, this can indicate not + * consistent buffer_len with actual data size. + */ + if (ret == 0) { + RTE_LOG(ERR, GUEST_CHANNEL, "No more data has been read.\n"); + return -1; + } + buffer = (char *)buffer + ret; + buffer_len -= ret; + } + + return 0; +} + +int rte_power_guest_channel_receive_msg(struct channel_packet *pkt, + unsigned int lcore_id) +{ + return power_guest_channel_read_msg(pkt, lcore_id); +} void guest_channel_host_disconnect(unsigned int lcore_id) diff --git a/lib/librte_power/guest_channel.h b/lib/librte_power/guest_channel.h index 373d39898..7c385df39 100644 --- a/lib/librte_power/guest_channel.h +++ b/lib/librte_power/guest_channel.h @@ -68,6 +68,41 @@ int guest_channel_send_msg(struct channel_packet *pkt, unsigned int lcore_id); int rte_power_guest_channel_send_msg(struct channel_packet *pkt, unsigned int lcore_id); +/** + * Read a message contained in pkt over the Virtio-Serial + * from the host endpoint. + * + * @param pkt + * Pointer to a populated struct channel_packet + * + * @param lcore_id + * lcore_id. + * + * @return + * - 0 on success. + * - Negative on error. + */ +int power_guest_channel_read_msg(struct channel_packet *pkt, + unsigned int lcore_id); + +/** + * Receive a message contained in pkt over the Virtio-Serial + * from the host endpoint. + * + * @param pkt + * Pointer to a populated struct channel_packet + * + * @param lcore_id + * lcore_id. + * + * @return + * - 0 on success. + * - Negative on error. + */ +int __rte_experimental +rte_power_guest_channel_receive_msg(struct channel_packet *pkt, + unsigned int lcore_id); + #ifdef __cplusplus } #endif diff --git a/lib/librte_power/rte_power_version.map b/lib/librte_power/rte_power_version.map index 042917360..69f5ea3f4 100644 --- a/lib/librte_power/rte_power_version.map +++ b/lib/librte_power/rte_power_version.map @@ -44,4 +44,5 @@ EXPERIMENTAL { rte_power_empty_poll_stat_update; rte_power_poll_stat_fetch; rte_power_poll_stat_update; + rte_power_guest_channel_receive_msg; }; -- 2.17.2