From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id B538AA00E6
for <public@inbox.dpdk.org>; Fri, 22 Mar 2019 03:09:42 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 8785C1B561;
Fri, 22 Mar 2019 03:09:42 +0100 (CET)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id 72A7C1B55F
for <dev@dpdk.org>; Fri, 22 Mar 2019 03:09:40 +0100 (CET)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
21 Mar 2019 19:09:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,255,1549958400"; d="scan'208";a="154029427"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206])
by fmsmga002.fm.intel.com with ESMTP; 21 Mar 2019 19:09:38 -0700
Date: Fri, 22 Mar 2019 10:05:34 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,
Karlsson Magnus <magnus.karlsson@intel.com>,
Topel Bjorn <bjorn.topel@intel.com>
Message-ID: <20190322020534.GG84243@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
<20190321091845.78495-1-xiaolong.ye@intel.com>
<20190321091845.78495-2-xiaolong.ye@intel.com>
<20190321082415.1dc0a2b9@shemminger-XPS-13-9360>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <20190321082415.1dc0a2b9@shemminger-XPS-13-9360>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD
driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190322020534.rBDjnamvrD87J4R1a6hCNEk9aRNWXk5Jw2gl2xldsR0@z>
On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>
>> +
>> +static inline int
>> +reserve_fill_queue(struct xsk_umem_info *umem, int reserve_size)
>> +{
>> + struct xsk_ring_prod *fq = &umem->fq;
>> + uint32_t idx;
>> + void *addr = NULL;
>> + int i, ret;
>> +
>> + ret = xsk_ring_prod__reserve(fq, reserve_size, &idx);
>> + if (!ret) {
>> + RTE_LOG(ERR, AF_XDP, "Failed to reserve enough fq descs.\n");
>> + return ret;
>> + }
>> +
>> + for (i = 0; i < reserve_size; i++) {
>> + __u64 *fq_addr;
>> + rte_ring_dequeue(umem->buf_ring, &addr);
>
>You should check return value of dequeue, otherwise static checkers will
>(rightly) complain that "everyone else checks return value of of rte_ring_dequeue()
>why not here?"
Got it, will do.