From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 141B6A00E6 for ; Fri, 22 Mar 2019 10:01:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2CBF41B58F; Fri, 22 Mar 2019 10:01:50 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9C3571B57B; Fri, 22 Mar 2019 10:01:48 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F33E489C34; Fri, 22 Mar 2019 09:01:47 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F81B60123; Fri, 22 Mar 2019 09:01:46 +0000 (UTC) From: Maxime Coquelin To: Wenzhuo Lu , dev@dpdk.org Cc: stable@dpdk.org References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com> <1553149569-105555-1-git-send-email-wenzhuo.lu@intel.com> <1553149569-105555-2-git-send-email-wenzhuo.lu@intel.com> Message-ID: <1151d47d-4a77-f192-38f6-d7231fca30c8@redhat.com> Date: Fri, 22 Mar 2019 10:01:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 22 Mar 2019 09:01:48 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 1/8] net/ice: fix Tx function setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322090144.UZ5hUKmnOJ6uyHu09FCfKBP33QPYUAwf4Je_tHMGyDc@z> On 3/22/19 9:46 AM, Maxime Coquelin wrote: > > > On 3/21/19 7:26 AM, Wenzhuo Lu wrote: >> The TX setting functions is not called. > > s/functions/function/ > >> >> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") >> Cc: stable@dpdk.org >> >> Signed-off-by: Wenzhuo Lu >> --- >>   drivers/net/ice/ice_ethdev.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c >> index a23c63a..b804be1 100644 >> --- a/drivers/net/ice/ice_ethdev.c >> +++ b/drivers/net/ice/ice_ethdev.c >> @@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf) >>       } >>       ice_set_rx_function(dev); >> +    ice_set_tx_function(dev); >>       mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK | >>               ETH_VLAN_EXTEND_MASK; >> > > Other than that: > > Reviewed-by: Maxime Coquelin Sorry, just notice I didn't fetch my mailbox, so I didn't see the v5. Anyway my comments seem to apply to v5 too. Maxime