DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ian Stokes <ian.stokes@intel.com>
To: dev@dpdk.org
Cc: stephen@networkplumber.org, Ian Stokes <ian.stokes@intel.com>
Subject: [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices
Date: Fri, 22 Mar 2019 13:01:17 +0000	[thread overview]
Message-ID: <1553259678-4515-7-git-send-email-ian.stokes@intel.com> (raw)
Message-ID: <20190322130117.fRQaaT6YpMOA-kjO7vxgGlIjVRrlFoSWafi3GuZVpIg@z> (raw)
In-Reply-To: <1553259678-4515-1-git-send-email-ian.stokes@intel.com>

This commit sets the min and max supported MTU values for igb devices
via the eth_igb_info_get() function. Min MTU supported is set to
ETHER_MIN_MTU and max mtu is calculated as the max packet length
supported minus the transport overhead. To aid in these calculations
a new MACRO 'E1000_ETH_OVERHEAD' has been introduced to consolidate
overhead calculation and avoid duplication.

Signed-off-by: Ian Stokes <ian.stokes@intel.com>
---
 drivers/net/e1000/e1000_ethdev.h | 6 ++++++
 drivers/net/e1000/igb_ethdev.c   | 7 +++++--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h
index 94edff08e..3e74cd8fe 100644
--- a/drivers/net/e1000/e1000_ethdev.h
+++ b/drivers/net/e1000/e1000_ethdev.h
@@ -89,6 +89,12 @@
 	ETH_RSS_IPV6_UDP_EX)
 
 /*
+ * The overhead from MTU to max frame size.
+ * Considering VLAN so a tag needs to be counted.
+ */
+#define E1000_ETH_OVERHEAD (ETHER_HDR_LEN + ETHER_CRC_LEN + VLAN_TAG_SIZE)
+
+/*
  * Maximum number of Ring Descriptors.
  *
  * Since RDLEN/TDLEN should be multiple of 128 bytes, the number of ring
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 87c9aedf2..b897e8ad4 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -2283,6 +2283,10 @@ eth_igb_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 	dev_info->speed_capa = ETH_LINK_SPEED_10M_HD | ETH_LINK_SPEED_10M |
 			ETH_LINK_SPEED_100M_HD | ETH_LINK_SPEED_100M |
 			ETH_LINK_SPEED_1G;
+
+	dev_info->max_mtu = dev_info->max_rx_pktlen - E1000_ETH_OVERHEAD;
+	dev_info->min_mtu = ETHER_MIN_MTU;
+
 }
 
 static const uint32_t *
@@ -4466,8 +4470,7 @@ eth_igb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 	uint32_t rctl;
 	struct e1000_hw *hw;
 	struct rte_eth_dev_info dev_info;
-	uint32_t frame_size = mtu + (ETHER_HDR_LEN + ETHER_CRC_LEN +
-				     VLAN_TAG_SIZE);
+	uint32_t frame_size = mtu + E1000_ETH_OVERHEAD;
 
 	hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
-- 
2.13.6


  parent reply	other threads:[~2019-03-22 13:02 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 13:01 [dpdk-dev] [PATCH v2 0/7] ethdev: add min/max MTU to device info Ian Stokes
2019-03-22 13:01 ` Ian Stokes
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 1/7] " Ian Stokes
2019-03-22 13:01   ` Ian Stokes
2019-03-25 14:26   ` Ferruh Yigit
2019-03-25 14:26     ` Ferruh Yigit
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 2/7] net/i40e: set min and max MTU for i40e devices Ian Stokes
2019-03-22 13:01   ` Ian Stokes
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 3/7] net/i40e: set min and max MTU for i40e VF devices Ian Stokes
2019-03-22 13:01   ` Ian Stokes
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 4/7] net/ixgbe: set min and max MTU for ixgbe devices Ian Stokes
2019-03-22 13:01   ` Ian Stokes
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 5/7] net/ixgbe: set min and max MTU for ixgbe VF devices Ian Stokes
2019-03-22 13:01   ` Ian Stokes
2019-03-22 13:01 ` Ian Stokes [this message]
2019-03-22 13:01   ` [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices Ian Stokes
2019-03-25 14:25   ` Ferruh Yigit
2019-03-25 14:25     ` Ferruh Yigit
2019-03-26 13:58     ` Zhang, Qi Z
2019-03-26 13:58       ` Zhang, Qi Z
2019-03-26 14:02       ` Ananyev, Konstantin
2019-03-26 14:02         ` Ananyev, Konstantin
2019-03-26 14:09         ` Zhang, Qi Z
2019-03-26 14:09           ` Zhang, Qi Z
2019-03-26 14:18           ` Ananyev, Konstantin
2019-03-26 14:18             ` Ananyev, Konstantin
2019-03-27  1:13             ` Zhang, Qi Z
2019-03-27  1:13               ` Zhang, Qi Z
2019-03-27  7:02             ` Zhang, Qi Z
2019-03-27  7:02               ` Zhang, Qi Z
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 7/7] app/testpmd: verify mtu with rte_eth_dev_info_get() Ian Stokes
2019-03-22 13:01   ` Ian Stokes
2019-03-25 14:20   ` Ferruh Yigit
2019-03-25 14:20     ` Ferruh Yigit
2019-03-28 16:41     ` Ferruh Yigit
2019-03-28 16:41       ` Ferruh Yigit
2019-03-28 16:43 ` [dpdk-dev] [PATCH v2 0/7] ethdev: add min/max MTU to device info Ferruh Yigit
2019-03-28 16:43   ` Ferruh Yigit
2019-03-29 17:52 ` [dpdk-dev] [PATCH v3 1/7] " Ferruh Yigit
2019-03-29 17:52   ` Ferruh Yigit
2019-03-29 17:52   ` [dpdk-dev] [PATCH v3 2/7] net/i40e: set min and max MTU for i40e devices Ferruh Yigit
2019-03-29 17:52     ` Ferruh Yigit
2019-03-29 17:52   ` [dpdk-dev] [PATCH v3 3/7] net/i40e: set min and max MTU for i40e VF devices Ferruh Yigit
2019-03-29 17:52     ` Ferruh Yigit
2019-03-29 17:52   ` [dpdk-dev] [PATCH v3 4/7] net/ixgbe: set min and max MTU for ixgbe devices Ferruh Yigit
2019-03-29 17:52     ` Ferruh Yigit
2019-03-29 17:52   ` [dpdk-dev] [PATCH v3 5/7] net/ixgbe: set min and max MTU for ixgbe VF devices Ferruh Yigit
2019-03-29 17:52     ` Ferruh Yigit
2019-03-29 17:52   ` [dpdk-dev] [PATCH v3 6/7] net/e1000: set min and max MTU for igb devices Ferruh Yigit
2019-03-29 17:52     ` Ferruh Yigit
2019-03-29 17:52   ` [dpdk-dev] [PATCH v3 7/7] app/testpmd: verify MTU with device provided limits Ferruh Yigit
2019-03-29 17:52     ` Ferruh Yigit
2019-03-29 17:56   ` [dpdk-dev] [PATCH v3 1/7] ethdev: add min/max MTU to device info Ferruh Yigit
2019-03-29 17:56     ` Ferruh Yigit
2019-03-29 18:05     ` Ferruh Yigit
2019-03-29 18:05       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553259678-4515-7-git-send-email-ian.stokes@intel.com \
    --to=ian.stokes@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).