* [dpdk-dev] [PATCH] ethdev: fix a typo
@ 2019-03-22 15:17 Rami Rosen
2019-03-22 15:17 ` Rami Rosen
2019-03-25 14:16 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 2 replies; 6+ messages in thread
From: Rami Rosen @ 2019-03-22 15:17 UTC (permalink / raw)
To: dev; +Cc: konstantin.ananyev, arybchenko, stable, Rami Rosen
This patch fixes a trivial typo in rte_ethdev.h.
retieve=>retrieve
Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
lib/librte_ethdev/rte_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index a3c864a13..dc8d072e8 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -1135,7 +1135,7 @@ struct rte_eth_dev_info {
/**
* Ethernet device RX queue information structure.
- * Used to retieve information about configured queue.
+ * Used to retrieve information about configured queue.
*/
struct rte_eth_rxq_info {
struct rte_mempool *mp; /**< mempool used by that queue. */
--
2.19.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] ethdev: fix a typo
2019-03-22 15:17 [dpdk-dev] [PATCH] ethdev: fix a typo Rami Rosen
@ 2019-03-22 15:17 ` Rami Rosen
2019-03-25 14:16 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
1 sibling, 0 replies; 6+ messages in thread
From: Rami Rosen @ 2019-03-22 15:17 UTC (permalink / raw)
To: dev; +Cc: konstantin.ananyev, arybchenko, stable, Rami Rosen
This patch fixes a trivial typo in rte_ethdev.h.
retieve=>retrieve
Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
lib/librte_ethdev/rte_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index a3c864a13..dc8d072e8 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -1135,7 +1135,7 @@ struct rte_eth_dev_info {
/**
* Ethernet device RX queue information structure.
- * Used to retieve information about configured queue.
+ * Used to retrieve information about configured queue.
*/
struct rte_eth_rxq_info {
struct rte_mempool *mp; /**< mempool used by that queue. */
--
2.19.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix a typo
2019-03-22 15:17 [dpdk-dev] [PATCH] ethdev: fix a typo Rami Rosen
2019-03-22 15:17 ` Rami Rosen
@ 2019-03-25 14:16 ` Ferruh Yigit
2019-03-25 14:16 ` Ferruh Yigit
2019-03-25 14:29 ` Thomas Monjalon
1 sibling, 2 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-03-25 14:16 UTC (permalink / raw)
To: Rami Rosen, dev
Cc: konstantin.ananyev, arybchenko, stable, Thomas Monjalon, John McNamara
On 3/22/2019 3:17 PM, Rami Rosen wrote:
> This patch fixes a trivial typo in rte_ethdev.h.
> retieve=>retrieve
>
> Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
It is great to have these fixes, but I wonder if there is a way to get them
fixed as a bunch, can running a spell check utility on the DPDK and fix all
existing typos in one go help? Any idea?
cc'ed John & Thomas,
Does it make sense to run something periodical, like before each release, run
spellcheck and fix the typos for whole code?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix a typo
2019-03-25 14:16 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-03-25 14:16 ` Ferruh Yigit
2019-03-25 14:29 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-03-25 14:16 UTC (permalink / raw)
To: Rami Rosen, dev
Cc: konstantin.ananyev, arybchenko, stable, Thomas Monjalon, John McNamara
On 3/22/2019 3:17 PM, Rami Rosen wrote:
> This patch fixes a trivial typo in rte_ethdev.h.
> retieve=>retrieve
>
> Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
It is great to have these fixes, but I wonder if there is a way to get them
fixed as a bunch, can running a spell check utility on the DPDK and fix all
existing typos in one go help? Any idea?
cc'ed John & Thomas,
Does it make sense to run something periodical, like before each release, run
spellcheck and fix the typos for whole code?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix a typo
2019-03-25 14:16 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-25 14:16 ` Ferruh Yigit
@ 2019-03-25 14:29 ` Thomas Monjalon
2019-03-25 14:29 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-03-25 14:29 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Rami Rosen, dev, konstantin.ananyev, arybchenko, stable, John McNamara
25/03/2019 15:16, Ferruh Yigit:
> On 3/22/2019 3:17 PM, Rami Rosen wrote:
> > This patch fixes a trivial typo in rte_ethdev.h.
> > retieve=>retrieve
> >
> > Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Applied to dpdk-next-net/master, thanks.
>
>
> It is great to have these fixes, but I wonder if there is a way to get them
> fixed as a bunch, can running a spell check utility on the DPDK and fix all
> existing typos in one go help? Any idea?
>
> cc'ed John & Thomas,
> Does it make sense to run something periodical, like before each release, run
> spellcheck and fix the typos for whole code?
Yes, it would make sense.
We can also add more spell checkers as part of checkpatch.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix a typo
2019-03-25 14:29 ` Thomas Monjalon
@ 2019-03-25 14:29 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-03-25 14:29 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Rami Rosen, dev, konstantin.ananyev, arybchenko, stable, John McNamara
25/03/2019 15:16, Ferruh Yigit:
> On 3/22/2019 3:17 PM, Rami Rosen wrote:
> > This patch fixes a trivial typo in rte_ethdev.h.
> > retieve=>retrieve
> >
> > Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Applied to dpdk-next-net/master, thanks.
>
>
> It is great to have these fixes, but I wonder if there is a way to get them
> fixed as a bunch, can running a spell check utility on the DPDK and fix all
> existing typos in one go help? Any idea?
>
> cc'ed John & Thomas,
> Does it make sense to run something periodical, like before each release, run
> spellcheck and fix the typos for whole code?
Yes, it would make sense.
We can also add more spell checkers as part of checkpatch.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-25 14:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 15:17 [dpdk-dev] [PATCH] ethdev: fix a typo Rami Rosen
2019-03-22 15:17 ` Rami Rosen
2019-03-25 14:16 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-25 14:16 ` Ferruh Yigit
2019-03-25 14:29 ` Thomas Monjalon
2019-03-25 14:29 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).