From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 3F93BA00E6
for <public@inbox.dpdk.org>; Fri, 22 Mar 2019 18:06:25 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C55991B6E9;
Fri, 22 Mar 2019 18:06:22 +0100 (CET)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id A9C6B1B6CD;
Fri, 22 Mar 2019 18:06:21 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
[10.5.11.15])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id EBFCA80471;
Fri, 22 Mar 2019 17:06:20 +0000 (UTC)
Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59])
by smtp.corp.redhat.com (Postfix) with ESMTPS id AD70A5D75F;
Fri, 22 Mar 2019 17:06:16 +0000 (UTC)
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com,
ramirose@gmail.com, arybchenko@solarflare.com, ferruh.yigit@intel.com,
stable@dpdk.org
References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com>
<1553261824-1881-1-git-send-email-david.marchand@redhat.com>
<1553261824-1881-3-git-send-email-david.marchand@redhat.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <8de1b82d-29a8-10be-75b1-463c9d755c19@redhat.com>
Date: Fri, 22 Mar 2019 18:06:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <1553261824-1881-3-git-send-email-david.marchand@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.28]); Fri, 22 Mar 2019 17:06:21 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v4 2/4] app/testpmd: extend fwd statistics to
64bits
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190322170614.ueHBYI4W6hqjLQG93AoTlnhmA_qh2lSuX6VSr_wCOF4@z>
On 3/22/19 2:37 PM, David Marchand wrote:
> fwd engine statistics are stored as unsigned int (32bits) and can wrap
> quite quickly.
> Example: sending 7mpps for 614s gives us 4298000000 packets =>
> 0x1002e4680 larger than 32bits.
>
> testpmd reports forwarding stats as:
> RX-packets: 3500381 TX-packets: 3500010 TX-dropped: 371
>
> While the port and accumulated stats are reported as 64bits:
> RX-packets: 4298467677 RX-dropped: 0 RX-total: 4298467677
> TX-packets: 4298467306 TX-dropped: 371 TX-total: 4298467677
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> Changelog since v2:
> - split out of the previous patch with a dedicated commitlog
> - Cc'd stable
>
> ---
> app/test-pmd/testpmd.c | 51 +++++++++++++++++---------------------------------
> app/test-pmd/testpmd.h | 12 ++++++------
> 2 files changed, 23 insertions(+), 40 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>