From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3F66FA00E6 for ; Sat, 23 Mar 2019 20:12:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B579A5942; Sat, 23 Mar 2019 20:12:46 +0100 (CET) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by dpdk.org (Postfix) with ESMTP id C06A41B743 for ; Sat, 23 Mar 2019 20:12:44 +0100 (CET) Received: by mail-vs1-f48.google.com with SMTP id j184so3216902vsd.11 for ; Sat, 23 Mar 2019 12:12:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dg3W8Jlmn86k0l/nHDWh8l9FSds/DpllIgvm+5VkPLI=; b=BYDyDDgWZuibNM639ICzJkUM+hy7wkBWd1a7WEUtjiZpgqv37qtBNfmbxAtClIlmJG X4E3A2pfu0F1GiBumety4LgDlDsX7Q4RHO1xyZJ5WKXyG1fi+bj3ycy2l/VBx1uG5Bcu 9qSwXns0CewYiQqs8NAhGtA8key2X+d1p/FrYymTRMcyJfAwcEizBbMT06U4N0HoDxhD XluuAFXzuHNaT86Qd3ElnyBGP8pg+VPcdhDbJC0AtD+Hy4G4Ha2ISNOzdu6DggUjdjYL WHHe0hxa87j72fANwkKtX5ZT6UAEM2xeMQpNJNBEmiY9dRHB17IhrLMVUbD4kSA18SIW Zvyw== X-Gm-Message-State: APjAAAXiy+Cc3q6HLPDx5x7f/JoW4UZPe4bMkwTVPiPRtJeprLvXAK/b wyycaDqwtFAIrXSLxP9+OvMrXirJ+dx8QLFC/XFiwA== X-Google-Smtp-Source: APXvYqx+0cKfMNOTD+vXnCyIQuDsHML0aCbsIPUmHDP0CalHy5Q7R9kCTIyViZP8DcsBXXe3dXHhU36GoGRO/TdGOyw= X-Received: by 2002:a67:2444:: with SMTP id k65mr10209567vsk.39.1553368363937; Sat, 23 Mar 2019 12:12:43 -0700 (PDT) MIME-Version: 1.0 References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com> In-Reply-To: From: David Marchand Date: Sat, 23 Mar 2019 20:12:33 +0100 Message-ID: To: Andrew Rybchenko Cc: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , "Yigit, Ferruh" , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190323191233.h-ITNjSDqrabGCHjb7930P8-Ee2aNUWknmWma1Jz9-Q@z> On Fri, Mar 22, 2019 at 6:43 PM David Marchand wrote: > On Fri, Mar 22, 2019 at 6:35 PM Andrew Rybchenko < > arybchenko@solarflare.com> wrote: > >> >> In fact bad Rx checksum counters follow and I think they should be in >> this line. >> >> That's why there is no \n here from the very beginning. >> >> My fix for the bug (local) just add \n in else branch below. >> > Just to be clear. origin/master: - iofwd engine: ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 ------- RX-packets: 121811360 TX-packets: 121811392 TX-dropped: 0 RX-bursts : 3806605 [100% of 32 pkts] TX-bursts : 3806606 [100% of 32 pkts] - csum engine: ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 ------- RX-packets: 5467488 TX-packets: 5467520 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 RX-bursts : 170859 [100% of 32 pkts] TX-bursts : 170860 [100% of 32 pkts] So, as suggested, I added a printf("\n") in the else for the csum engine block: - iofwd engine: ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 ------- RX-packets: 259770560 TX-packets: 259770592 TX-dropped: 0 RX-bursts : 8117830 [100% of 32 pkts] TX-bursts : 8117831 [100% of 32 pkts] - csum engine: ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 ------- RX-packets: 7834016 TX-packets: 7834048 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 RX-bursts : 244813 [100% of 32 pkts] TX-bursts : 244814 [100% of 32 pkts] deal ? -- David Marchand