DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrius Sirvys <andrius.sirvys@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v4] build: move variable definition to top level
Date: Sun, 24 Mar 2019 23:59:22 +0100	[thread overview]
Message-ID: <8490098.mdA5AMzK3V@xps> (raw)
Message-ID: <20190324225922.SIuYUei2eqW37EefSOhBlOhxYTflKeAPND1TXjOto3k@z> (raw)
In-Reply-To: <1551958101-104223-1-git-send-email-andrius.sirvys@intel.com>

07/03/2019 12:28, Andrius Sirvys:
> If for debugging we disable the driver directory in the meson.build file,
> we get an error because the variable "driver_classes" does not exist.
> This is because driver_classes is only defined in the
> drivers/meson.build file. Defining driver_classes in dpdk/meson.build file
> will make it easier for compiling separate directories.
> 
> In the process, we rename driver_classes to dpdk_driver_classes for
> consistency with the other variables.
> 
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v4: Removed unreleated files that were accidentally included
> ---
>  drivers/meson.build | 4 ++--
>  meson.build         | 3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)

Please, could you rebase on top of latest changes in master?
Thanks




  reply	other threads:[~2019-03-24 22:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 16:29 [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately Andrius Sirvys
2019-03-05 17:21 ` Bruce Richardson
2019-03-05 17:26   ` Bruce Richardson
2019-03-05 18:01     ` Ranjit Menon
2019-03-07  9:56 ` [dpdk-dev] [PATCH v3] build: move variable definition to top level Andrius Sirvys
2019-03-07 10:18   ` Bruce Richardson
2019-03-07 11:28   ` [dpdk-dev] [PATCH v4] " Andrius Sirvys
2019-03-24 22:59     ` Thomas Monjalon [this message]
2019-03-24 22:59       ` Thomas Monjalon
2019-03-25 10:34     ` [dpdk-dev] [PATCH v5] " Andrius Sirvys
2019-03-25 10:34       ` Andrius Sirvys
2019-03-26 22:16       ` Thomas Monjalon
2019-03-26 22:16         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8490098.mdA5AMzK3V@xps \
    --to=thomas@monjalon.net \
    --cc=andrius.sirvys@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).