From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 20C46A05D3
	for <public@inbox.dpdk.org>; Mon, 25 Mar 2019 08:47:51 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id DF0BF2BFA;
	Mon, 25 Mar 2019 08:47:49 +0100 (CET)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 3BCCF2BF7
 for <dev@dpdk.org>; Mon, 25 Mar 2019 08:47:48 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
 [10.5.11.22])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 721C53086209;
 Mon, 25 Mar 2019 07:47:47 +0000 (UTC)
Received: from localhost (ovpn-117-19.ams2.redhat.com [10.36.117.19])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 944941001E6F;
 Mon, 25 Mar 2019 07:47:42 +0000 (UTC)
Date: Mon, 25 Mar 2019 08:47:35 +0100
From: Jens Freimann <jfreimann@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
Message-ID: <20190325074735.t5mziidmukza5lpg@jenstp.localdomain>
References: <20190325052716.7730-1-tiwei.bie@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Disposition: inline
In-Reply-To: <20190325052716.7730-1-tiwei.bie@intel.com>
User-Agent: NeoMutt/20180716-1376-5d6ed1
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.42]); Mon, 25 Mar 2019 07:47:47 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] net/virtio: define avail and used flags as
 constants
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190325074735.Vu0poa1e1OA8VGfAyPI6F9ePNKBt1rs88Ex05QS4HC8@z>

On Mon, Mar 25, 2019 at 01:27:16PM +0800, Tiwei Bie wrote:
>We are consistently passing 1 as the argument in the data path,
>so there is no need to define avail/used flags as function-like
>macros anymore. This patch changes the avail and used flags to
>constants. And a frequently used combination is also introduced.
>
>Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>---
> drivers/net/virtio/virtio_ethdev.c              | 10 ++++------
> drivers/net/virtio/virtio_ring.h                |  9 +++++++--
> drivers/net/virtio/virtio_rxtx.c                |  9 ++++-----
> .../net/virtio/virtio_user/virtio_user_dev.c    | 17 ++++++++++-------
> drivers/net/virtio/virtqueue.h                  |  4 ++--
> 5 files changed, 27 insertions(+), 22 deletions(-)
>

Reviewed-by: Jens Freimann <jfreimann@redhat.com>