From: Chas Williams <3chas3@gmail.com>
To: dev@dpdk.org
Cc: olivier.matz@6wind.com, Bill Hong <bhong@brocade.com>,
stable@dpdk.org, Chas Williams <chas3@att.com>
Subject: [dpdk-dev] [PATCH] net: fix Tx VLAN flag for offload emulation
Date: Mon, 25 Mar 2019 11:05:41 -0400 [thread overview]
Message-ID: <20190325150541.12087-1-3chas3@gmail.com> (raw)
Message-ID: <20190325150541.mhPfwUpanqBLcw-F-vGb4JrR2SoeMQ8KALGTH_hXDEM@z> (raw)
From: Bill Hong <bhong@brocade.com>
A PMD might use rte_vlan_insert to implement Tx VLAN offload. Typically
the PMD will insert the VLAN header in the transmit path and then attempt
to send the packets. If this fails, the packets are returned to
the application which may attempt to send these packets again. If the
PKT_TX_VLAN flag is not cleared, the transmit path may attempt to insert
the VLAN header again.
Fixes: 47aa48b969f8 ("net: fix stripped VLAN flag for offload emulation");
Cc: stable@dpdk.org
Signed-off-by: Bill Hong <bhong@brocade.com>
Signed-off-by: Chas Williams <chas3@att.com>
---
lib/librte_net/rte_ether.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
index c2c5e249f..e0d831113 100644
--- a/lib/librte_net/rte_ether.h
+++ b/lib/librte_net/rte_ether.h
@@ -408,7 +408,7 @@ static inline int rte_vlan_insert(struct rte_mbuf **m)
vh = (struct vlan_hdr *) (nh + 1);
vh->vlan_tci = rte_cpu_to_be_16((*m)->vlan_tci);
- (*m)->ol_flags &= ~PKT_RX_VLAN_STRIPPED;
+ (*m)->ol_flags &= ~(PKT_RX_VLAN_STRIPPED | PKT_TX_VLAN);
return 0;
}
--
2.17.2
next reply other threads:[~2019-03-25 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 15:05 Chas Williams [this message]
2019-03-25 15:05 ` Chas Williams
2019-03-26 16:50 ` Ferruh Yigit
2019-03-26 16:50 ` Ferruh Yigit
2019-03-26 18:01 ` Chas Williams
2019-03-26 18:01 ` Chas Williams
2019-04-01 20:17 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-01 20:17 ` Ferruh Yigit
2019-04-04 17:07 ` [dpdk-dev] " Ferruh Yigit
2019-04-04 17:07 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325150541.12087-1-3chas3@gmail.com \
--to=3chas3@gmail.com \
--cc=bhong@brocade.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).