From: "Wang, Yipeng1" <yipeng1.wang@intel.com>
To: "Poornima, PallantlaX" <pallantlax.poornima@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] hash: fix sprintf with snprintf
Date: Mon, 25 Mar 2019 18:05:32 +0000 [thread overview]
Message-ID: <D2C4A16CA39F7F4E8E384D204491D7A673E453EB@ORSMSX104.amr.corp.intel.com> (raw)
Message-ID: <20190325180532.ToFhYVXbAF7afLvQ_rTnRaI-rzAYbB0JBpgI9qXjXCM@z> (raw)
In-Reply-To: <EE76425279735140910E0DBA3963DA361BBA864D@BGSMSX103.gar.corp.intel.com>
Sorry for the late reply, but I noticed the test folder is recently moved under app so you may need a rebase.
Please keep my ack after rebase: Acked-by: Yipeng Wang <yipeng1.wang at intel.com>
>-----Original Message-----
>From: Poornima, PallantlaX
>Sent: Monday, March 25, 2019 7:43 AM
>To: dev@dpdk.org
>Cc: Pattan, Reshma <reshma.pattan@intel.com>; Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh
><sameh.gobriel@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo
><pablo.de.lara.guarch@intel.com>; stephen@networkplumber.org; stable@dpdk.org
>Subject: RE: [PATCH v2] hash: fix sprintf with snprintf
>
>Hi,
>
>>-----Original Message-----
>>From: Poornima, PallantlaX
>>Sent: Thursday, February 14, 2019 6:28 PM
>>To: dev@dpdk.org
>>Cc: Pattan, Reshma <reshma.pattan@intel.com>; Wang, Yipeng1
>><yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>;
>>Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo
>><pablo.de.lara.guarch@intel.com>; stephen@networkplumber.org;
>>Poornima, PallantlaX <pallantlax.poornima@intel.com>; stable@dpdk.org
>>Subject: [PATCH v2] hash: fix sprintf with snprintf
>>
>>sprintf function is not secure as it doesn't check the length of string.
>>More secure function snprintf is used.
>>
>>Fixes: 473d1bebce ("hash: allow to store data in hash table")
>>Cc: stable@dpdk.org
>>
>>Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
>>---
>>v2: Addressed review comment to correct the format specifier of
>>hastest_key_lens.
>>---
>
>
>Request for ACK please if there are no comments
>
>Regards,
>Poornima
next prev parent reply other threads:[~2019-03-25 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 12:57 Pallantla Poornima
[not found] ` <EE76425279735140910E0DBA3963DA361BBA864D@BGSMSX103.gar.corp.intel.com>
2019-03-25 18:05 ` Wang, Yipeng1 [this message]
2019-03-25 18:05 ` Wang, Yipeng1
2019-03-26 10:27 ` [dpdk-dev] [PATCH v3] app/test/hash: " Pallantla Poornima
2019-03-26 10:27 ` Pallantla Poornima
2019-04-04 23:59 ` Thomas Monjalon
2019-04-04 23:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2C4A16CA39F7F4E8E384D204491D7A673E453EB@ORSMSX104.amr.corp.intel.com \
--to=yipeng1.wang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pallantlax.poornima@intel.com \
--cc=reshma.pattan@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).