From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D23461150 for ; Tue, 26 Mar 2019 03:17:58 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Mar 2019 19:17:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="331968318" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga005.fm.intel.com with ESMTP; 25 Mar 2019 19:17:55 -0700 Date: Tue, 26 Mar 2019 10:13:36 +0800 From: Ye Xiaolong To: Stephen Hemminger Cc: dev@dpdk.org, David Marchand , Qi Zhang , Karlsson Magnus , Topel Bjorn , Maxime Coquelin , Ferruh Yigit , Luca Boccassi , Bruce Richardson , Ananyev Konstantin Message-ID: <20190326021336.GA48057@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190325060400.40291-1-xiaolong.ye@intel.com> <20190325060400.40291-2-xiaolong.ye@intel.com> <20190325085814.1cca7845@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190325085814.1cca7845@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2019 02:17:59 -0000 On 03/25, Stephen Hemminger wrote: >On Mon, 25 Mar 2019 14:03:56 +0800 >Xiaolong Ye wrote: > >> + >> + ret = xsk_ring_prod__reserve(fq, reserve_size, &idx); >> + if (unlikely(!ret)) { >> + AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n"); > >You defined AF_XDP_LOG to add a newline (similar to other drivers). >But all the messages already have a newline. >This will cause log to be double spaced. Thanks for the catch, I'll remove the newline in the definition. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8B7DFA05D3 for ; Tue, 26 Mar 2019 03:18:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6932D2BD3; Tue, 26 Mar 2019 03:18:00 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D23461150 for ; Tue, 26 Mar 2019 03:17:58 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Mar 2019 19:17:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="331968318" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga005.fm.intel.com with ESMTP; 25 Mar 2019 19:17:55 -0700 Date: Tue, 26 Mar 2019 10:13:36 +0800 From: Ye Xiaolong To: Stephen Hemminger Cc: dev@dpdk.org, David Marchand , Qi Zhang , Karlsson Magnus , Topel Bjorn , Maxime Coquelin , Ferruh Yigit , Luca Boccassi , Bruce Richardson , Ananyev Konstantin Message-ID: <20190326021336.GA48057@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190325060400.40291-1-xiaolong.ye@intel.com> <20190325060400.40291-2-xiaolong.ye@intel.com> <20190325085814.1cca7845@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190325085814.1cca7845@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326021336.e0pPOxKHAEVu043HiLSlx8qZr5dQseTPOBvgyGPoXKs@z> On 03/25, Stephen Hemminger wrote: >On Mon, 25 Mar 2019 14:03:56 +0800 >Xiaolong Ye wrote: > >> + >> + ret = xsk_ring_prod__reserve(fq, reserve_size, &idx); >> + if (unlikely(!ret)) { >> + AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n"); > >You defined AF_XDP_LOG to add a newline (similar to other drivers). >But all the messages already have a newline. >This will cause log to be double spaced. Thanks for the catch, I'll remove the newline in the definition.