From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 8B7DFA05D3
for <public@inbox.dpdk.org>; Tue, 26 Mar 2019 03:18:01 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 6932D2BD3;
Tue, 26 Mar 2019 03:18:00 +0100 (CET)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id D23461150
for <dev@dpdk.org>; Tue, 26 Mar 2019 03:17:58 +0100 (CET)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
25 Mar 2019 19:17:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="331968318"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206])
by fmsmga005.fm.intel.com with ESMTP; 25 Mar 2019 19:17:55 -0700
Date: Tue, 26 Mar 2019 10:13:36 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Karlsson Magnus <magnus.karlsson@intel.com>,
Topel Bjorn <bjorn.topel@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Ferruh Yigit <ferruh.yigit@intel.com>, Luca Boccassi <bluca@debian.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Ananyev Konstantin <konstantin.ananyev@intel.com>
Message-ID: <20190326021336.GA48057@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
<20190325060400.40291-1-xiaolong.ye@intel.com>
<20190325060400.40291-2-xiaolong.ye@intel.com>
<20190325085814.1cca7845@shemminger-XPS-13-9360>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <20190325085814.1cca7845@shemminger-XPS-13-9360>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD
driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190326021336.e0pPOxKHAEVu043HiLSlx8qZr5dQseTPOBvgyGPoXKs@z>
On 03/25, Stephen Hemminger wrote:
>On Mon, 25 Mar 2019 14:03:56 +0800
>Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>
>> +
>> + ret = xsk_ring_prod__reserve(fq, reserve_size, &idx);
>> + if (unlikely(!ret)) {
>> + AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n");
>
>You defined AF_XDP_LOG to add a newline (similar to other drivers).
>But all the messages already have a newline.
>This will cause log to be double spaced.
Thanks for the catch, I'll remove the newline in the definition.