* [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
2019-03-20 3:31 [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key Wei Zhao
@ 2019-03-20 3:31 ` Wei Zhao
2019-03-20 9:21 ` Peng, Yuan
` (3 subsequent siblings)
4 siblings, 0 replies; 22+ messages in thread
From: Wei Zhao @ 2019-03-20 3:31 UTC (permalink / raw)
To: dev; +Cc: yuan.peng, stable, qi.z.zhang, Wei Zhao
There need a warning info when no perfect RSS key is config,
so i40e will use default key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f0..9235b08 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so use default configuration\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
2019-03-20 3:31 [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key Wei Zhao
2019-03-20 3:31 ` Wei Zhao
@ 2019-03-20 9:21 ` Peng, Yuan
2019-03-20 9:21 ` Peng, Yuan
2019-03-20 9:23 ` Zhao1, Wei
2019-03-20 12:20 ` Kevin Traynor
` (2 subsequent siblings)
4 siblings, 2 replies; 22+ messages in thread
From: Peng, Yuan @ 2019-03-20 9:21 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, Zhang, Qi Z
Tested-by: Peng Yuan <yuan.peng@intel.com>
- Tested Branch: master
- Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c
- OS: 4.13.9-300.fc27.x86_64
- GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
- CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- NIC: Intel Corporation Device Fortville [8086:1583]
- Default x86_64-native-linuxapp-gcc configuration
- Prerequisites:
- Total 1 case1, 1 passed, 0 failed
- Case steps:
1. Bind the pf port to dpdk driver:
./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1
2. start testpmd:
./x86_64-native-linuxapp-gcc/app/testpmd --log-level=*:8 -c 1ffff -n 4 - -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained
3. set an invalid RSS-key
testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end key 67108863 / end
i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured
i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so use default configuration
Flow rule #0 created
there is a device warning reported.
-----Original Message-----
From: Zhao1, Wei
Sent: Wednesday, March 20, 2019 11:31 AM
To: dev@dpdk.org
Cc: Peng, Yuan <yuan.peng@intel.com>; stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/i40e: add warning info when no perfect RSS key
There need a warning info when no perfect RSS key is config, so i40e will use default key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index dca61f0..9235b08 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so
+use default configuration\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
2019-03-20 9:21 ` Peng, Yuan
@ 2019-03-20 9:21 ` Peng, Yuan
2019-03-20 9:23 ` Zhao1, Wei
1 sibling, 0 replies; 22+ messages in thread
From: Peng, Yuan @ 2019-03-20 9:21 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, Zhang, Qi Z
Tested-by: Peng Yuan <yuan.peng@intel.com>
- Tested Branch: master
- Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c
- OS: 4.13.9-300.fc27.x86_64
- GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
- CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- NIC: Intel Corporation Device Fortville [8086:1583]
- Default x86_64-native-linuxapp-gcc configuration
- Prerequisites:
- Total 1 case1, 1 passed, 0 failed
- Case steps:
1. Bind the pf port to dpdk driver:
./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1
2. start testpmd:
./x86_64-native-linuxapp-gcc/app/testpmd --log-level=*:8 -c 1ffff -n 4 - -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained
3. set an invalid RSS-key
testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end key 67108863 / end
i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured
i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so use default configuration
Flow rule #0 created
there is a device warning reported.
-----Original Message-----
From: Zhao1, Wei
Sent: Wednesday, March 20, 2019 11:31 AM
To: dev@dpdk.org
Cc: Peng, Yuan <yuan.peng@intel.com>; stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/i40e: add warning info when no perfect RSS key
There need a warning info when no perfect RSS key is config, so i40e will use default key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index dca61f0..9235b08 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so
+use default configuration\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
2019-03-20 9:21 ` Peng, Yuan
2019-03-20 9:21 ` Peng, Yuan
@ 2019-03-20 9:23 ` Zhao1, Wei
2019-03-20 9:23 ` Zhao1, Wei
1 sibling, 1 reply; 22+ messages in thread
From: Zhao1, Wei @ 2019-03-20 9:23 UTC (permalink / raw)
To: Peng, Yuan, dev; +Cc: stable, Zhang, Qi Z
Thank you!
> -----Original Message-----
> From: Peng, Yuan
> Sent: Wednesday, March 20, 2019 5:21 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH] net/i40e: add warning info when no perfect RSS key
>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> - Tested Branch: master
> - Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c
> - OS: 4.13.9-300.fc27.x86_64
> - GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
> - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
> - NIC: Intel Corporation Device Fortville [8086:1583]
> - Default x86_64-native-linuxapp-gcc configuration
> - Prerequisites:
> - Total 1 case1, 1 passed, 0 failed
>
> - Case steps:
> 1. Bind the pf port to dpdk driver:
> ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 2. start testpmd:
> ./x86_64-native-linuxapp-gcc/app/testpmd --log-level=*:8 -c 1ffff -n 4 - -i --
> nb-cores=8 --rxq=4 --txq=4 --port-topology=chained
>
> 3. set an invalid RSS-key
> testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end
> key 67108863 / end
> i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured
> i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so use
> default configuration
>
> Flow rule #0 created
> there is a device warning reported.
>
>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, March 20, 2019 11:31 AM
> To: dev@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; stable@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: add warning info when no perfect RSS key
>
> There need a warning info when no perfect RSS key is config, so i40e will use
> default key.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index dca61f0..9235b08 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> rss_conf.rss_key = (uint8_t *)rss_key_default;
> rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> sizeof(uint32_t);
> + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config
> for i40e, so
> +use default configuration\n");
> }
>
> i40e_hw_rss_hash_set(pf, &rss_conf);
> --
> 2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
2019-03-20 9:23 ` Zhao1, Wei
@ 2019-03-20 9:23 ` Zhao1, Wei
0 siblings, 0 replies; 22+ messages in thread
From: Zhao1, Wei @ 2019-03-20 9:23 UTC (permalink / raw)
To: Peng, Yuan, dev; +Cc: stable, Zhang, Qi Z
Thank you!
> -----Original Message-----
> From: Peng, Yuan
> Sent: Wednesday, March 20, 2019 5:21 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH] net/i40e: add warning info when no perfect RSS key
>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> - Tested Branch: master
> - Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c
> - OS: 4.13.9-300.fc27.x86_64
> - GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
> - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
> - NIC: Intel Corporation Device Fortville [8086:1583]
> - Default x86_64-native-linuxapp-gcc configuration
> - Prerequisites:
> - Total 1 case1, 1 passed, 0 failed
>
> - Case steps:
> 1. Bind the pf port to dpdk driver:
> ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 2. start testpmd:
> ./x86_64-native-linuxapp-gcc/app/testpmd --log-level=*:8 -c 1ffff -n 4 - -i --
> nb-cores=8 --rxq=4 --txq=4 --port-topology=chained
>
> 3. set an invalid RSS-key
> testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end
> key 67108863 / end
> i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured
> i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so use
> default configuration
>
> Flow rule #0 created
> there is a device warning reported.
>
>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, March 20, 2019 11:31 AM
> To: dev@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; stable@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: add warning info when no perfect RSS key
>
> There need a warning info when no perfect RSS key is config, so i40e will use
> default key.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index dca61f0..9235b08 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> rss_conf.rss_key = (uint8_t *)rss_key_default;
> rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> sizeof(uint32_t);
> + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config
> for i40e, so
> +use default configuration\n");
> }
>
> i40e_hw_rss_hash_set(pf, &rss_conf);
> --
> 2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
2019-03-20 3:31 [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key Wei Zhao
2019-03-20 3:31 ` Wei Zhao
2019-03-20 9:21 ` Peng, Yuan
@ 2019-03-20 12:20 ` Kevin Traynor
2019-03-20 12:20 ` Kevin Traynor
2019-03-22 1:27 ` Zhao1, Wei
2019-03-22 2:16 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-03-22 3:06 ` Wei Zhao
4 siblings, 2 replies; 22+ messages in thread
From: Kevin Traynor @ 2019-03-20 12:20 UTC (permalink / raw)
To: Wei Zhao, dev; +Cc: yuan.peng, stable, qi.z.zhang
On 20/03/2019 03:31, Wei Zhao wrote:
> There need a warning info when no perfect RSS key is config,
It is mixing info and warning levels in the description and log. Better
to be consistent and use one (I think info).
> so i40e will use default key.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index dca61f0..9235b08 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> rss_conf.rss_key = (uint8_t *)rss_key_default;
> rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> sizeof(uint32_t);
> + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so use default configuration\n");
It's an info log, so remove "Warning!" and the message can be a little
clearer so user doesn't interpret as an instruction. Suggest "No RSS key
config for i40e provided, using default"
> }
>
> i40e_hw_rss_hash_set(pf, &rss_conf);
>
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
2019-03-20 12:20 ` Kevin Traynor
@ 2019-03-20 12:20 ` Kevin Traynor
2019-03-22 1:27 ` Zhao1, Wei
1 sibling, 0 replies; 22+ messages in thread
From: Kevin Traynor @ 2019-03-20 12:20 UTC (permalink / raw)
To: Wei Zhao, dev; +Cc: yuan.peng, stable, qi.z.zhang
On 20/03/2019 03:31, Wei Zhao wrote:
> There need a warning info when no perfect RSS key is config,
It is mixing info and warning levels in the description and log. Better
to be consistent and use one (I think info).
> so i40e will use default key.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index dca61f0..9235b08 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> rss_conf.rss_key = (uint8_t *)rss_key_default;
> rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> sizeof(uint32_t);
> + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so use default configuration\n");
It's an info log, so remove "Warning!" and the message can be a little
clearer so user doesn't interpret as an instruction. Suggest "No RSS key
config for i40e provided, using default"
> }
>
> i40e_hw_rss_hash_set(pf, &rss_conf);
>
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
2019-03-20 12:20 ` Kevin Traynor
2019-03-20 12:20 ` Kevin Traynor
@ 2019-03-22 1:27 ` Zhao1, Wei
2019-03-22 1:27 ` Zhao1, Wei
1 sibling, 1 reply; 22+ messages in thread
From: Zhao1, Wei @ 2019-03-22 1:27 UTC (permalink / raw)
To: Kevin Traynor, dev; +Cc: Peng, Yuan, stable, Zhang, Qi Z
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Wednesday, March 20, 2019 8:21 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; stable@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect
> RSS key
>
> On 20/03/2019 03:31, Wei Zhao wrote:
> > There need a warning info when no perfect RSS key is config,
>
> It is mixing info and warning levels in the description and log. Better to be
> consistent and use one (I think info).
>
Ok, we will use dev info.
> > so i40e will use default key.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index dca61f0..9235b08 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> > rss_conf.rss_key = (uint8_t *)rss_key_default;
> > rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> > sizeof(uint32_t);
> > + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config
> for i40e, so
> > +use default configuration\n");
>
> It's an info log, so remove "Warning!" and the message can be a little clearer
> so user doesn't interpret as an instruction. Suggest "No RSS key config for
> i40e provided, using default"
Ok , change in v2
>
> > }
> >
> > i40e_hw_rss_hash_set(pf, &rss_conf);
> >
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
2019-03-22 1:27 ` Zhao1, Wei
@ 2019-03-22 1:27 ` Zhao1, Wei
0 siblings, 0 replies; 22+ messages in thread
From: Zhao1, Wei @ 2019-03-22 1:27 UTC (permalink / raw)
To: Kevin Traynor, dev; +Cc: Peng, Yuan, stable, Zhang, Qi Z
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Wednesday, March 20, 2019 8:21 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; stable@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect
> RSS key
>
> On 20/03/2019 03:31, Wei Zhao wrote:
> > There need a warning info when no perfect RSS key is config,
>
> It is mixing info and warning levels in the description and log. Better to be
> consistent and use one (I think info).
>
Ok, we will use dev info.
> > so i40e will use default key.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index dca61f0..9235b08 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> > rss_conf.rss_key = (uint8_t *)rss_key_default;
> > rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> > sizeof(uint32_t);
> > + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config
> for i40e, so
> > +use default configuration\n");
>
> It's an info log, so remove "Warning!" and the message can be a little clearer
> so user doesn't interpret as an instruction. Suggest "No RSS key config for
> i40e provided, using default"
Ok , change in v2
>
> > }
> >
> > i40e_hw_rss_hash_set(pf, &rss_conf);
> >
^ permalink raw reply [flat|nested] 22+ messages in thread
* [dpdk-dev] [PATCH v2] net/i40e: add warning info when no perfect RSS key
2019-03-20 3:31 [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key Wei Zhao
` (2 preceding siblings ...)
2019-03-20 12:20 ` Kevin Traynor
@ 2019-03-22 2:16 ` Wei Zhao
2019-03-22 2:16 ` Wei Zhao
2019-03-22 3:06 ` Wei Zhao
4 siblings, 1 reply; 22+ messages in thread
From: Wei Zhao @ 2019-03-22 2:16 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, ktraynor, Wei Zhao
There need a warning info when no perfect RSS key is config,
so i40e will use default key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com@>
---
v2:
--update dev info message
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f0..89a55c1 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* [dpdk-dev] [PATCH v2] net/i40e: add warning info when no perfect RSS key
2019-03-22 2:16 ` [dpdk-dev] [PATCH v2] " Wei Zhao
@ 2019-03-22 2:16 ` Wei Zhao
0 siblings, 0 replies; 22+ messages in thread
From: Wei Zhao @ 2019-03-22 2:16 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, ktraynor, Wei Zhao
There need a warning info when no perfect RSS key is config,
so i40e will use default key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com@>
---
v2:
--update dev info message
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f0..89a55c1 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread
* [dpdk-dev] [PATCH v2] net/i40e: add warning info when no perfect RSS key
2019-03-20 3:31 [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key Wei Zhao
` (3 preceding siblings ...)
2019-03-22 2:16 ` [dpdk-dev] [PATCH v2] " Wei Zhao
@ 2019-03-22 3:06 ` Wei Zhao
2019-03-22 3:06 ` Wei Zhao
` (2 more replies)
4 siblings, 3 replies; 22+ messages in thread
From: Wei Zhao @ 2019-03-22 3:06 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, ktraynor, Wei Zhao
There need a warning info when no perfect RSS key is config,
so i40e will use default key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
v2:
--update dev info message
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f0..89a55c1 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* [dpdk-dev] [PATCH v2] net/i40e: add warning info when no perfect RSS key
2019-03-22 3:06 ` Wei Zhao
@ 2019-03-22 3:06 ` Wei Zhao
2019-03-22 13:30 ` Zhang, Qi Z
2019-03-26 8:35 ` [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid Wei Zhao
2 siblings, 0 replies; 22+ messages in thread
From: Wei Zhao @ 2019-03-22 3:06 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, ktraynor, Wei Zhao
There need a warning info when no perfect RSS key is config,
so i40e will use default key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
v2:
--update dev info message
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f0..89a55c1 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/i40e: add warning info when no perfect RSS key
2019-03-22 3:06 ` Wei Zhao
2019-03-22 3:06 ` Wei Zhao
@ 2019-03-22 13:30 ` Zhang, Qi Z
2019-03-22 13:30 ` Zhang, Qi Z
2019-03-26 8:35 ` [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid Wei Zhao
2 siblings, 1 reply; 22+ messages in thread
From: Zhang, Qi Z @ 2019-03-22 13:30 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, ktraynor
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, March 22, 2019 11:07 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; ktraynor@redhat.com;
> Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v2] net/i40e: add warning info when no perfect RSS key
>
> There need a warning info when no perfect RSS key is config, so i40e will use
> default key.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/i40e: add warning info when no perfect RSS key
2019-03-22 13:30 ` Zhang, Qi Z
@ 2019-03-22 13:30 ` Zhang, Qi Z
0 siblings, 0 replies; 22+ messages in thread
From: Zhang, Qi Z @ 2019-03-22 13:30 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, ktraynor
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, March 22, 2019 11:07 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; ktraynor@redhat.com;
> Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v2] net/i40e: add warning info when no perfect RSS key
>
> There need a warning info when no perfect RSS key is config, so i40e will use
> default key.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 22+ messages in thread
* [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid
2019-03-22 3:06 ` Wei Zhao
2019-03-22 3:06 ` Wei Zhao
2019-03-22 13:30 ` Zhang, Qi Z
@ 2019-03-26 8:35 ` Wei Zhao
2019-03-26 8:35 ` Wei Zhao
2019-03-26 12:41 ` Zhang, Qi Z
2 siblings, 2 replies; 22+ messages in thread
From: Wei Zhao @ 2019-03-26 8:35 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, ferruh.yigit, Wei Zhao
A log message is required when provided RSS key is
not valid so that driver will use the default RSS key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
v2:
update dev info message
v3:
update log info
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 63ec813..5472312 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid
2019-03-26 8:35 ` [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid Wei Zhao
@ 2019-03-26 8:35 ` Wei Zhao
2019-03-26 12:41 ` Zhang, Qi Z
1 sibling, 0 replies; 22+ messages in thread
From: Wei Zhao @ 2019-03-26 8:35 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, ferruh.yigit, Wei Zhao
A log message is required when provided RSS key is
not valid so that driver will use the default RSS key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
v2:
update dev info message
v3:
update log info
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 63ec813..5472312 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid
2019-03-26 8:35 ` [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid Wei Zhao
2019-03-26 8:35 ` Wei Zhao
@ 2019-03-26 12:41 ` Zhang, Qi Z
2019-03-26 12:41 ` Zhang, Qi Z
2019-03-26 14:51 ` Ferruh Yigit
1 sibling, 2 replies; 22+ messages in thread
From: Zhang, Qi Z @ 2019-03-26 12:41 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, Yigit, Ferruh
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, March 26, 2019 4:35 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid
>
> A log message is required when provided RSS key is not valid so that driver will
> use the default RSS key.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> ---
>
> v2:
> update dev info message
>
> v3:
> update log info
> ---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 63ec813..5472312 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> rss_conf.rss_key = (uint8_t *)rss_key_default;
> rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> sizeof(uint32_t);
> + PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using
> +default\n");
s/perfect/valid to align with the title
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
> }
>
> i40e_hw_rss_hash_set(pf, &rss_conf);
> --
> 2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid
2019-03-26 12:41 ` Zhang, Qi Z
@ 2019-03-26 12:41 ` Zhang, Qi Z
2019-03-26 14:51 ` Ferruh Yigit
1 sibling, 0 replies; 22+ messages in thread
From: Zhang, Qi Z @ 2019-03-26 12:41 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, Yigit, Ferruh
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, March 26, 2019 4:35 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid
>
> A log message is required when provided RSS key is not valid so that driver will
> use the default RSS key.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> ---
>
> v2:
> update dev info message
>
> v3:
> update log info
> ---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 63ec813..5472312 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> rss_conf.rss_key = (uint8_t *)rss_key_default;
> rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> sizeof(uint32_t);
> + PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using
> +default\n");
s/perfect/valid to align with the title
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
> }
>
> i40e_hw_rss_hash_set(pf, &rss_conf);
> --
> 2.7.5
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid
2019-03-26 12:41 ` Zhang, Qi Z
2019-03-26 12:41 ` Zhang, Qi Z
@ 2019-03-26 14:51 ` Ferruh Yigit
2019-03-26 14:51 ` Ferruh Yigit
1 sibling, 1 reply; 22+ messages in thread
From: Ferruh Yigit @ 2019-03-26 14:51 UTC (permalink / raw)
To: Zhang, Qi Z, Zhao1, Wei, dev; +Cc: stable
On 3/26/2019 12:41 PM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Zhao1, Wei
>> Sent: Tuesday, March 26, 2019 4:35 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
>> <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid
>>
>> A log message is required when provided RSS key is not valid so that driver will
>> use the default RSS key.
>>
>> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>> Tested-by: Peng Yuan <yuan.peng@intel.com>
>>
>> ---
>>
>> v2:
>> update dev info message
>>
>> v3:
>> update log info
>> ---
>> drivers/net/i40e/i40e_ethdev.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index 63ec813..5472312 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
>> rss_conf.rss_key = (uint8_t *)rss_key_default;
>> rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
>> sizeof(uint32_t);
>> + PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using
>> +default\n");
>
> s/perfect/valid to align with the title
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
Message carried into next line to keep line length < 80 while merging next-net:
PMD_DRV_LOG(INFO,
"No valid RSS key config for i40e, using default\n");
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid
2019-03-26 14:51 ` Ferruh Yigit
@ 2019-03-26 14:51 ` Ferruh Yigit
0 siblings, 0 replies; 22+ messages in thread
From: Ferruh Yigit @ 2019-03-26 14:51 UTC (permalink / raw)
To: Zhang, Qi Z, Zhao1, Wei, dev; +Cc: stable
On 3/26/2019 12:41 PM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Zhao1, Wei
>> Sent: Tuesday, March 26, 2019 4:35 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
>> <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid
>>
>> A log message is required when provided RSS key is not valid so that driver will
>> use the default RSS key.
>>
>> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>> Tested-by: Peng Yuan <yuan.peng@intel.com>
>>
>> ---
>>
>> v2:
>> update dev info message
>>
>> v3:
>> update log info
>> ---
>> drivers/net/i40e/i40e_ethdev.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index 63ec813..5472312 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
>> rss_conf.rss_key = (uint8_t *)rss_key_default;
>> rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
>> sizeof(uint32_t);
>> + PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using
>> +default\n");
>
> s/perfect/valid to align with the title
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
Message carried into next line to keep line length < 80 while merging next-net:
PMD_DRV_LOG(INFO,
"No valid RSS key config for i40e, using default\n");
^ permalink raw reply [flat|nested] 22+ messages in thread