Re: [dpdk-dev] [PATCH v3] crypto/aesni_mb: support newer version library only

[Akhil Goyal <akhil.goyal@nxp.com>]

On 3/25/2019 7:28 PM, Fan Zhang wrote:
> As stated in 19.02 deprecation notice, this patch updates the
> aesni_mb PMD to remove the support of older Intel-ipsec-mb
> library version eariler than 0.52.
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> v3:
> - updated documentation.
>
> v2:
> - fixed incorrect version in documentation.
>   doc/guides/cryptodevs/aesni_mb.rst                 |    7 +-
>   doc/guides/rel_notes/deprecation.rst               |    3 -
>   drivers/crypto/aesni_mb/Makefile                   |   21 +-
>   drivers/crypto/aesni_mb/aesni_mb_ops.h             |  302 -----
>   drivers/crypto/aesni_mb/meson.build                |   13 +-
>   drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c  | 1313 --------------------
>   .../crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c  |  745 -----------
>   drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h |   37 -
>   8 files changed, 15 insertions(+), 2426 deletions(-)
>   delete mode 100644 drivers/crypto/aesni_mb/aesni_mb_ops.h
>   delete mode 100644 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c
>   delete mode 100644 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c
>
> diff --git a/doc/guides/cryptodevs/aesni_mb.rst b/doc/guides/cryptodevs/aesni_mb.rst
> index 47f2ecc2f..0e29ed126 100644
> --- a/doc/guides/cryptodevs/aesni_mb.rst
> +++ b/doc/guides/cryptodevs/aesni_mb.rst
> @@ -57,10 +57,6 @@ Limitations
>   
>   * Chained mbufs are not supported.
>   * Only in-place is currently supported (destination address is the same as source address).
> -* RTE_CRYPTO_AEAD_AES_GCM only works properly when the multi-buffer library is
> -  0.51.0 or newer.
> -* RTE_CRYPTO_HASH_AES_GMAC is supported by library version v0.51 or later.
> -* RTE_CRYPTO_HASH_SHA* is supported by library version v0.52 or later.
>   
>   
>   Installation
> @@ -92,7 +88,8 @@ and the Multi-Buffer library version supported by them:
>      17.05 - 17.08   0.45 - 0.48
>      17.11           0.47 - 0.48
>      18.02           0.48
> -   18.05+          0.49+
> +   18.05 - 19.02   0.49 - 0.52
> +   19.05+          0.52+
>      ==============  ============================
>   
>   
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 1b4fcb7e6..8adeaa552 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -72,6 +72,3 @@ Deprecation Notices
>     replace ``enum rte_meter_color`` in meter library in 19.05. This will help
>     to consolidate color definition, which is currently replicated in many places,
>     such as: rte_meter.h, rte_mtr.h, rte_tm.h.
> -
> -* crypto/aesni_mb: the minimum supported intel-ipsec-mb library version will be
> -  changed from 0.49.0 to 0.52.0.
>
I think this deserve to be updated in the release note as well.