From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5D16CA05D3 for <public@inbox.dpdk.org>; Tue, 26 Mar 2019 10:15:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F5062BF4; Tue, 26 Mar 2019 10:15:44 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130041.outbound.protection.outlook.com [40.107.13.41]) by dpdk.org (Postfix) with ESMTP id AC9B12BD3 for <dev@dpdk.org>; Tue, 26 Mar 2019 10:15:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DgBSFFkQjcRyV/kYWz0YIXZvPTb1l5LDYaeJK8+lMio=; b=xGFxUF3hkACwTtJWQ9MPfZbk9NT5tfv42XPsbqNIEc7sRHS+BPNsX3OXu/drQ/jy8r1cRV5efwlN8NAql8aqWUYX0VDhy5seZJHJvfzIXMMAeJeQgbMp2e4rDD8G2rFKg+/2D929ubDwfYNEwqfCF/i5zpFtdd/wgfZscpOgkrY= Received: from VI1PR05MB4224.eurprd05.prod.outlook.com (52.133.12.13) by VI1PR05MB5214.eurprd05.prod.outlook.com (20.178.12.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.16; Tue, 26 Mar 2019 09:15:39 +0000 Received: from VI1PR05MB4224.eurprd05.prod.outlook.com ([fe80::bcb0:ed58:d76:cac]) by VI1PR05MB4224.eurprd05.prod.outlook.com ([fe80::bcb0:ed58:d76:cac%4]) with mapi id 15.20.1730.019; Tue, 26 Mar 2019 09:15:39 +0000 From: Dekel Peled <dekelp@mellanox.com> To: "pradeep@us.ibm.com" <pradeep@us.ibm.com>, Shahaf Shuler <shahafs@mellanox.com> CC: "bruce.richardson@intel.com" <bruce.richardson@intel.com>, Chao Zhu <chaozhu@linux.vnet.ibm.com>, "dev@dpdk.org" <dev@dpdk.org>, David Christensen <drc@ibm.com>, "honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>, "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, "ola.liljedahl@arm.com" <ola.liljedahl@arm.com>, Ori Kam <orika@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>, David Wilder <wilder@us.ibm.com>, Yongseok Koh <yskoh@mellanox.com>, Idan Werpoler <Idanw@mellanox.com>, Olga Shern <olgas@mellanox.com> Thread-Topic: [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER Thread-Index: AQHU3Yp0jK3S6l0vmk2P4CMRCfI9FaYSS1UAgABrb7CAABghgIAAjcKAgAARgoCAAbKgAIAAqiuAgAEafgCAAHesgIAAcDoAgAAnRYCAAFWXgIACEuEAgAC4XQCAApfpgA== Date: Tue, 26 Mar 2019 09:15:39 +0000 Message-ID: <VI1PR05MB4224613FA0B8DB3737F8F23DB65F0@VI1PR05MB4224.eurprd05.prod.outlook.com> References: <1552913893-43407-1-git-send-email-dekelp@mellanox.com> <11283309.AIL3tCH6tf@xps> <OF204AC919.EF7DE1FC-ON882583C5.0054B82A-882583C5.00553665@notes.na.collabserv.com> <4334064.10fvSv6A2r@xps> <OF4C2DBD4B.3CAEF22E-ON882583C5.007DFA88-882583C5.007E1FF2@notes.na.collabserv.com> <AM0PR0502MB3795753A8C8FE1874DFD1175C35D0@AM0PR0502MB3795.eurprd05.prod.outlook.com> <OFB810109E.4E511E37-ON882583C7.0060A84E-882583C7.0060D2F5@notes.na.collabserv.com> In-Reply-To: <OFB810109E.4E511E37-ON882583C7.0060A84E-882583C7.0060D2F5@notes.na.collabserv.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47b466af-47b1-41b4-884d-08d6b1cb9d4e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB5214; x-ms-traffictypediagnostic: VI1PR05MB5214: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: <VI1PR05MB521499A91450D75C5F16CCACB65F0@VI1PR05MB5214.eurprd05.prod.outlook.com> x-forefront-prvs: 09888BC01D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(39860400002)(396003)(366004)(199004)(189003)(7696005)(53546011)(3846002)(6116002)(86362001)(6306002)(97736004)(236005)(6436002)(316002)(9686003)(81166006)(76176011)(6636002)(54896002)(2906002)(54906003)(55016002)(8936002)(7736002)(790700001)(6506007)(68736007)(74316002)(229853002)(93886005)(71200400001)(7416002)(71190400001)(110136005)(33656002)(486006)(478600001)(81156014)(53936002)(476003)(105586002)(446003)(11346002)(106356001)(186003)(14454004)(26005)(4326008)(66066001)(52536014)(256004)(14444005)(8676002)(25786009)(2501003)(6246003)(107886003)(102836004)(99286004)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB5214; H:VI1PR05MB4224.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: /FFtQlsrzGcVgnZCCRJdx15FKeJcl6BfByqpvhTJitZhE6rH1wKkbQ7CTBlymCRpuFxQQEPaVoLcO8FnpVwhHII5IwKOSjLtxJ+bGLuijQ3N4m9tfiP6TnQwiy2jxk1nbO2Gn+V5TWOb35qfJTPBRB/UCYlvWLjzSE+EXwK9ohbdGW1hvpcZpSXQHPimHWq4CmVL6zHAnyBA5dkbDIzBw7PAv13VdGAsUMrdm4a9sV4MiHRdWAruNYzz3tWFGcX6reMY/UdxmV9M0iP4VxwJReGXaIQTUuE7+B1EGFsImJ0ymwm6+K1dp0V4jjRdjBibfIfmMY3kVg7p4Pe0nddKaVZnQBDYDrWra6d3MliPyUXyRdQRyPV9e1MyHqVeI2+wfh4IYYgi4zzr5qyyUia7SsI71kGQ6kwXJcTJt0AgK48= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47b466af-47b1-41b4-884d-08d6b1cb9d4e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2019 09:15:39.2328 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5214 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190326091539.BA7ncxz8Fxp2oTYc24KVh-wh82OPtukgdfwNZhg094g@z> +Idan Werpoler. From: Pradeep Satyanarayana <pradeep@us.ibm.com> Sent: Sunday, March 24, 2019 7:38 PM To: Shahaf Shuler <shahafs@mellanox.com> Cc: bruce.richardson@intel.com; Chao Zhu <chaozhu@linux.vnet.ibm.com>; Deke= l Peled <dekelp@mellanox.com>; dev@dpdk.org; David Christensen <drc@ibm.com= >; honnappa.nagarahalli@arm.com; konstantin.ananyev@intel.com; ola.liljedah= l@arm.com; Ori Kam <orika@mellanox.com>; Thomas Monjalon <thomas@monjalon.n= et>; David Wilder <wilder@us.ibm.com>; Yongseok Koh <yskoh@mellanox.com> Subject: RE: [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER Shahaf Shuler <shahafs@mellanox.com<mailto:shahafs@mellanox.com>> wrote on = 03/23/2019 11:37:42 PM: > From: Shahaf Shuler <shahafs@mellanox.com<mailto:shahafs@mellanox.com>> > To: "pradeep@us.ibm.com<mailto:pradeep@us.ibm.com>" <pradeep@us.ibm.com<m= ailto:pradeep@us.ibm.com>>, Thomas Monjalon > <thomas@monjalon.net<mailto:thomas@monjalon.net>> > Cc: "bruce.richardson@intel.com<mailto:bruce.richardson@intel.com>" <bruc= e.richardson@intel.com<mailto:bruce.richardson@intel.com>>, Chao > Zhu <chaozhu@linux.vnet.ibm.com<mailto:chaozhu@linux.vnet.ibm.com>>, Deke= l Peled <dekelp@mellanox.com<mailto:dekelp@mellanox.com>>, > "dev@dpdk.org<mailto:dev@dpdk.org>" <dev@dpdk.org<mailto:dev@dpdk.org>>, = David Christensen <drc@ibm.com<mailto:drc@ibm.com>>, > "honnappa.nagarahalli@arm.com<mailto:honnappa.nagarahalli@arm.com>" <honn= appa.nagarahalli@arm.com<mailto:honnappa.nagarahalli@arm.com>>, > "konstantin.ananyev@intel.com<mailto:konstantin.ananyev@intel.com>" <kons= tantin.ananyev@intel.com<mailto:konstantin.ananyev@intel.com>>, > "ola.liljedahl@arm.com<mailto:ola.liljedahl@arm.com>" <ola.liljedahl@arm.= com<mailto:ola.liljedahl@arm.com>>, Ori Kam > <orika@mellanox.com<mailto:orika@mellanox.com>>, David Wilder <wilder@us.= ibm.com<mailto:wilder@us.ibm.com>>, Yongseok Koh > <yskoh@mellanox.com<mailto:yskoh@mellanox.com>> > Date: 03/23/2019 11:37 PM > Subject: RE: [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER > > Pradeep, > > Pradeep Satyanarayana wrote on Saturday, March 23, 2019 12:58 AM > >Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>> wrote = on 03/22/2019 10:51:17 AM: > >> Date: 03/22/2019 10:51 AM > >> Subject: Re: [PATCH] eal/ppc: remove fix of memory barrier for IBM POW= ER > >> > >> 22/03/2019 16:30, Pradeep Satyanarayana: > >> > Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>> wr= ote on 03/22/2019 01:49:03 AM: > >> > > 22/03/2019 02:40, Pradeep Satyanarayana: > >> > > > - rte_[rw]mb (general memory barrier) --> should be lwsync > >> > > > >> > > This is what may be discussed. > >> > > The assumption is that the general memory barrier should cover > >> > > all cases (CPU caches, SMP and I/O). > >> > > That's why we think it should "sync" for Power. > >> > > >> > In that case, at a minimum we must de-link rte_smp_[rw]mb from rte_[= rw]mb > >> > and retain it as lwsync. Agreed? > >> > >> I have no clue about what is needed for SMP barrier in Power. > >> As long as it works as expected, no problem. > >> > > > >We will try that out and report back here, later next week > > Till then, i think there are 2 orthogonal issues: > 1. ppc rte_wmb is incorrect > 2. ppc rte_smp_[rw]mb may be improved. > > for #1 the current patch from Dekel seems to be OK. do you agree? > for #2 i guess you will check and come back w/ patch/answer? That has been the line of thinking. However, we need to do some extensive t= esting to confirm that it all holds up. Thanks Pradeep pradeep@us.ibm.com<mailto:pradeep@us.ibm.com>