From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4C4AA2BFA for ; Tue, 26 Mar 2019 11:58:37 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 03:58:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="330764455" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga006.fm.intel.com with SMTP; 26 Mar 2019 03:58:33 -0700 Received: by (sSMTP sendmail emulation); Tue, 26 Mar 2019 10:58:31 +0000 Date: Tue, 26 Mar 2019 10:58:31 +0000 From: Bruce Richardson To: Jerin Jacob Kollanukkaran Cc: "anand.rawat@intel.com" , "dev@dpdk.org" , "pallavi.kadam@intel.com" , "thomas@monjalon.net" , "ranjit.menon@intel.com" , "jeffrey.b.shaw@intel.com" Message-ID: <20190326105831.GA188340@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190326060238.9884-1-anand.rawat@intel.com> <20190326060238.9884-4-anand.rawat@intel.com> <13f7c718448539712a6ba5024959b296143555e6.camel@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13f7c718448539712a6ba5024959b296143555e6.camel@marvell.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v5 3/8] kvargs: adding a module definition file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2019 10:58:37 -0000 On Tue, Mar 26, 2019 at 10:32:34AM +0000, Jerin Jacob Kollanukkaran wrote: > On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > > adding a DEF file for kvargs to specify the exports > > for the creation of the shared library. > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: Anand Rawat > > Reviewed-by: Pallavi Kadam > > Reviewed-by: Ranjit Menon > > --- > > lib/librte_kvargs/rte_kvargs_exports.def | 7 +++++++ > > 1 file changed, 7 insertions(+) > > create mode 100644 lib/librte_kvargs/rte_kvargs_exports.def > > > > diff --git a/lib/librte_kvargs/rte_kvargs_exports.def > > b/lib/librte_kvargs/rte_kvargs_exports.def > > new file mode 100644 > > index 000000000..265d3cc9a > > --- /dev/null > > +++ b/lib/librte_kvargs/rte_kvargs_exports.def > > Maintaining two separate files (.map and .def) for shared > library definition will be pain full. > Yes, though I'd question how much more painful it is than having to update a separate map file anyway - just consider the number of patches that have been submitted over the years which failed shared library build because map file updates were forgotten. However, my hope is that down the road we can have the def file generated from the map file (or potentially vice versa). Perhaps the meson python module could be used to allow us to script it a bit. > # Is it possible to add neutral file format if windows is not happy > with .map file? > # I am not sure, How we can express "EXPERIMENTAL" tag with .def file. > # It is good to check, How OTHER cross platform libraries addressing > this problem > A wider question is whether it is possible at all to have ABI versions associated with functions? I didn't find any mention of it in the documentations, and if it's not possible, then the question of how to put an experimental version is moot, I think. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6FEEDA05D3 for ; Tue, 26 Mar 2019 11:58:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95B8E2C28; Tue, 26 Mar 2019 11:58:39 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4C4AA2BFA for ; Tue, 26 Mar 2019 11:58:37 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 03:58:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="330764455" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga006.fm.intel.com with SMTP; 26 Mar 2019 03:58:33 -0700 Received: by (sSMTP sendmail emulation); Tue, 26 Mar 2019 10:58:31 +0000 Date: Tue, 26 Mar 2019 10:58:31 +0000 From: Bruce Richardson To: Jerin Jacob Kollanukkaran Cc: "anand.rawat@intel.com" , "dev@dpdk.org" , "pallavi.kadam@intel.com" , "thomas@monjalon.net" , "ranjit.menon@intel.com" , "jeffrey.b.shaw@intel.com" Message-ID: <20190326105831.GA188340@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190326060238.9884-1-anand.rawat@intel.com> <20190326060238.9884-4-anand.rawat@intel.com> <13f7c718448539712a6ba5024959b296143555e6.camel@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <13f7c718448539712a6ba5024959b296143555e6.camel@marvell.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v5 3/8] kvargs: adding a module definition file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326105831.h77R_p-Fu_IYqe1tmz1uP9vqRSDpGMh5QQkYJQUzfKQ@z> On Tue, Mar 26, 2019 at 10:32:34AM +0000, Jerin Jacob Kollanukkaran wrote: > On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > > adding a DEF file for kvargs to specify the exports > > for the creation of the shared library. > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: Anand Rawat > > Reviewed-by: Pallavi Kadam > > Reviewed-by: Ranjit Menon > > --- > > lib/librte_kvargs/rte_kvargs_exports.def | 7 +++++++ > > 1 file changed, 7 insertions(+) > > create mode 100644 lib/librte_kvargs/rte_kvargs_exports.def > > > > diff --git a/lib/librte_kvargs/rte_kvargs_exports.def > > b/lib/librte_kvargs/rte_kvargs_exports.def > > new file mode 100644 > > index 000000000..265d3cc9a > > --- /dev/null > > +++ b/lib/librte_kvargs/rte_kvargs_exports.def > > Maintaining two separate files (.map and .def) for shared > library definition will be pain full. > Yes, though I'd question how much more painful it is than having to update a separate map file anyway - just consider the number of patches that have been submitted over the years which failed shared library build because map file updates were forgotten. However, my hope is that down the road we can have the def file generated from the map file (or potentially vice versa). Perhaps the meson python module could be used to allow us to script it a bit. > # Is it possible to add neutral file format if windows is not happy > with .map file? > # I am not sure, How we can express "EXPERIMENTAL" tag with .def file. > # It is good to check, How OTHER cross platform libraries addressing > this problem > A wider question is whether it is possible at all to have ABI versions associated with functions? I didn't find any mention of it in the documentations, and if it's not possible, then the question of how to put an experimental version is moot, I think. /Bruce