Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: rework PMD global data init

[Shahaf Shuler <shahafs@mellanox.com>]

Monday, March 25, 2019 9:16 PM, Yongseok Koh:
> Subject: [dpdk-dev] [PATCH v2 3/4] net/mlx5: rework PMD global data init
> 
> There's more need to have PMD global data structure. This should be
> initialized once per a process regardless of how many PMD instances are
> probed. mlx5_init_once() is called during probing and make sure all the init
> functions are called once per a process. Currently, such global data and its
> initialization functions are even scattered. Rather than 'extern'-ing such
> variables and calling such functions one by one making sure it is called only
> once by checking the validity of such variables, it will be better to have a
> global storage to hold such data and a consolidated function having all the
> initializations. The existing shared memory gets more extensively used for
> this purpose. As there could be multiple secondary processes, a static
> storage (local to process) is also added.
> 
> As the reserved virtual address for UAR remap is a PMD global resource, this
> doesn't need to be stored in the device priv structure, but in the PMD global
> data.
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>

Acked-by: Shahaf Shuler <shahafs@mellanox.com>