From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F1430A05D3 for ; Tue, 26 Mar 2019 16:22:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A1E4D0B2; Tue, 26 Mar 2019 16:22:17 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 0FE545F72 for ; Tue, 26 Mar 2019 16:22:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D079B37ED; Tue, 26 Mar 2019 11:22:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 11:22:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=K4+GdUpdTJGWJS5a8RZUSKzOIQdU8XWM2V33BKXZZ4o=; b=qZFJl9Kt2My0 Ki8cjb9yRe8aiH66FOLBfhKNGYe05f3JcVS54oKoOVd8UhS9/12CizrOVGEg0SZ5 Xa/XjZQ6yviTxTGIybUCwSWyYzC1fu8qUpCYFcOG5HLJWTWP3y3AHwE/zfYuMD+A PDH4QlbrRX7Jf2qKh1OkvsjxubNFxxc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=K4+GdUpdTJGWJS5a8RZUSKzOIQdU8XWM2V33BKXZZ 4o=; b=6zBidktUBzKnGrZ9nGHHpjVh+54cvexZqakiAieGdizo1Sql/Uqys0IZj rwL2eLOBDgdgrppqvJuyCr0BVIBZCRloz7Rw1FVoBjVLkdgeA19DrZDdYidX/l3G KTenzA3rAPtP3ILJQHUz6iLW7Mv8Qauj/xM4dfi5PyGCcDc0kg/BvAzJJcKmGm6R nNQJwVW4vZf5WXlrMkNByq78JzigDLTYGgkZkRNbbYPjhf93j0pskTPKQqw8anRI 5cS7bOc4tjgB4+CMO1lvOpaw8sqOb5ir3TLEsj4ZWwli6JXetSnB7HkewXW9UxvQ HCtXQGuE+9tWFjkCh3zjEBjQebCYg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedtgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 95A5110316; Tue, 26 Mar 2019 11:22:11 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Jerin Jacob Kollanukkaran , "pallavi.kadam@intel.com" , "anand.rawat@intel.com" , "dev@dpdk.org" , "ranjit.menon@intel.com" , "jeffrey.b.shaw@intel.com" Date: Tue, 26 Mar 2019 16:22:10 +0100 Message-ID: <4104487.G3urQPyzIp@xps> In-Reply-To: <20190326151738.GA488640@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <4709724.uuJ7r4bRVe@xps> <20190326151738.GA488640@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326152210.N91vymO7Y-_r1qUCp_R0-K13ywlZFyyB-WPmfZVgn8A@z> 26/03/2019 16:17, Bruce Richardson: > On Tue, Mar 26, 2019 at 04:07:26PM +0100, Thomas Monjalon wrote: > > 26/03/2019 15:41, Bruce Richardson: > > > On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote: > > > > 26/03/2019 14:37, Jerin Jacob Kollanukkaran: > > > > > On Tue, 2019-03-26 at 10:58 +0000, Bruce Richardson wrote: > > > > > > However, my hope is that down the road we can have the def file > > > > > > generated > > > > > > from the map file (or potentially vice versa). Perhaps the meson > > > > > > python > > > > > > module could be used to allow us to script it a bit. > > > > > > > > > > Make sense. Do we want to support shared lib for Windows for the first > > > > > version? or Can we live with static lib till we find a proper solution. > > > > > I do believe the base Windows Helloworld support needs to added this > > > > > release in main repo and add the subsequent features step by step. > > > > > I would treat, shared lib as subsequent feature if it is not clean. > > > > > > > > I agree, shared library can be supported later. > > > > > > > I would agree, except *not* supporting it will be more painful than what is > > > proposed here. :-) > > > > Why? > > We can just document it as broken, and test only "static" compilation. > > Am I missing something? > > > Yes, static compilation also builds the shared libraries too. To turn that > off, you'd have to modify the meson.build files to conditionally undefine > the shared library builds on windows. Then undefine out the assignment to > any dependency variables that are using those libraries, etc. It's doable, > but it's a lot messier than adding in 2 .def files. OK, thanks