From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 0B2E9A05D3
	for <public@inbox.dpdk.org>; Tue, 26 Mar 2019 17:34:29 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BBB981B434;
	Tue, 26 Mar 2019 17:34:28 +0100 (CET)
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-eopbgr820118.outbound.protection.outlook.com [40.107.82.118])
 by dpdk.org (Postfix) with ESMTP id 385BE1B447
 for <dev@dpdk.org>; Tue, 26 Mar 2019 17:34:27 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PQ7W9Sxfy3FUg2dQnfGuiwsV4eqtXgNPot6y9FtxdOQ=;
 b=CMC+EVMov0cm1EZxwGUa8BdNd2ciKsD+TJNoPSjtUHNxGoB+O7UoLoTD0o8Y3ZiEwycq5PFgM3/jLsOG6i69yTZH2Y2sbG0cgCK3JbTvcCvZtp8pqOOSxUbitufLoqzvqF+AXzmcdI94c8GYRIHE0n0KXGDHQ10NaR+gImmVVDM=
Received: from MWHPR21MB0638.namprd21.prod.outlook.com (10.175.141.139) by
 MWHPR21MB0176.namprd21.prod.outlook.com (10.173.52.22) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1771.3; Tue, 26 Mar 2019 16:34:25 +0000
Received: from MWHPR21MB0638.namprd21.prod.outlook.com
 ([fe80::c4e7:ece1:887e:b983]) by MWHPR21MB0638.namprd21.prod.outlook.com
 ([fe80::c4e7:ece1:887e:b983%3]) with mapi id 15.20.1771.002; Tue, 26 Mar 2019
 16:34:25 +0000
From: Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>
To: Anand Rawat <anand.rawat@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
 "ranjit.menon@intel.com" <ranjit.menon@intel.com>, "jeffrey.b.shaw@intel.com"
 <jeffrey.b.shaw@intel.com>, "bruce.richardson@intel.com"
 <bruce.richardson@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>
Thread-Topic: [dpdk-dev] [PATCH v5 8/8] build: meson changes to build on
 windows
Thread-Index: AQHU45m24aHOAk/l4Uaxlm0354yujaYeHDCQ
Date: Tue, 26 Mar 2019 16:34:25 +0000
Message-ID:
 <MWHPR21MB063866D9075C897FDA1F3206EF5F0@MWHPR21MB0638.namprd21.prod.outlook.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190326060238.9884-1-anand.rawat@intel.com>
 <20190326060238.9884-9-anand.rawat@intel.com>
In-Reply-To: <20190326060238.9884-9-anand.rawat@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=haramakr@microsoft.com; 
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-03-26T16:34:22.6201557Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=cd1ff289-f35f-4a63-88eb-64b914caf2d7;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic
x-originating-ip: [131.107.147.44]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c0733ef3-4da7-4c4a-ab02-08d6b208e904
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7193020);
 SRVR:MWHPR21MB0176; 
x-ms-traffictypediagnostic: MWHPR21MB0176:
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Harini.Ramakrishnan@microsoft.com; 
x-microsoft-antispam-prvs: <MWHPR21MB01761C7BEADEBD6A6E8A29FAEF5F0@MWHPR21MB0176.namprd21.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 09888BC01D
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10019020)(39860400002)(396003)(346002)(376002)(366004)(136003)(13464003)(189003)(199004)(14444005)(72206003)(102836004)(316002)(8936002)(256004)(478600001)(3846002)(105586002)(76176011)(7696005)(6436002)(74316002)(106356001)(22452003)(7736002)(81166006)(10090500001)(5660300002)(25786009)(4326008)(81156014)(8676002)(305945005)(2501003)(2906002)(229853002)(8990500004)(6116002)(53936002)(55016002)(6246003)(71190400001)(71200400001)(14454004)(9686003)(68736007)(52536014)(86612001)(446003)(10290500003)(11346002)(86362001)(476003)(26005)(186003)(99286004)(54906003)(110136005)(97736004)(6506007)(66066001)(53546011)(33656002)(486006);
 DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR21MB0176;
 H:MWHPR21MB0638.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; MX:1; A:1; 
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: MHB3zAol///AhZsI14W+hugv9P5r0YWVraMXEkf0PCiQnT+XsU/QYiP7s3Xf2uv8AzxA9JvkHEayiS1QcwiJ1LtDQ9x1jiMRVEMhSt3luBov3T9/FeL7IYXya6Jj1h8ety8/v/3DNwtbP6QEE1GmOay2B0j0Zo/pSZ2cyy0S7zQvEj69RyO0nTy16DDccBVbtaFDOa0eHfqSDCaIj6K+KC4LUx3JhZCj4/AHcU7r+972JUP2Hy+320QmJb7IGMNkqsdBS3e+fYVbEMrtEuZs4Cikb8o15bQjiJjzwuEusqkjbChFW7LzVmiZOKVtPglkRAR5KDl228IVd14Q0koZFCKOp0A1yx+fxvGN1XQKZNYaZ9eanFvRXYq1a3EZVQyrQOwymKvq9e9nkLV6TV+Ux3P/irFQk1F1vqWb1g9U0+4=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0733ef3-4da7-4c4a-ab02-08d6b208e904
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2019 16:34:25.6882 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0176
Subject: Re: [dpdk-dev] [PATCH v5 8/8] build: meson changes to build on
 windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190326163425.ouR7jwSxYyF8JEonjFtOnQmPk6dg_HKlP1B98OoCFT4@z>



-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Anand Rawat
Sent: Monday, March 25, 2019 11:03 PM
To: dev@dpdk.org
Cc: anand.rawat@intel.com; pallavi.kadam@intel.com; ranjit.menon@intel.com;=
 jeffrey.b.shaw@intel.com; bruce.richardson@intel.com; thomas@monjalon.net
Subject: [dpdk-dev] [PATCH v5 8/8] build: meson changes to build on windows

Added meson workarounds to build helloworld on windows.
Windows currently only supports kvargs and eal libraries.
This change restricts the build flow to supported libraries only.

Signed-off-by: Anand Rawat <anand.rawat@intel.com>
Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
Acked-by: Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>
---
 app/meson.build                   |  6 +++++-
 buildtools/meson.build            |  6 +++++-
 drivers/meson.build               |  6 +++++-
 examples/meson.build              |  6 +++++-
 kernel/windows/meson.build        |  4 ++++
 lib/librte_eal/common/meson.build | 14 +++++++++-----
 lib/meson.build                   |  4 ++++
 7 files changed, 37 insertions(+), 9 deletions(-)  create mode 100644 kern=
el/windows/meson.build

diff --git a/app/meson.build b/app/meson.build index aa353f657..e949624b7 1=
00644
--- a/app/meson.build
+++ b/app/meson.build
@@ -1,5 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2017 Intel Corpora=
tion
+# Copyright(c) 2017-2019 Intel Corporation
+
+if host_machine.system() =3D=3D 'windows'
+	subdir_done()
+endif
=20
 apps =3D [
 	'pdump',
diff --git a/buildtools/meson.build b/buildtools/meson.build index cdd38ed2=
4..0209bec8f 100644
--- a/buildtools/meson.build
+++ b/buildtools/meson.build
@@ -1,5 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2017 Intel Corpora=
tion
+# Copyright(c) 2017-2019 Intel Corporation
+
+if host_machine.system() =3D=3D 'windows'
+	subdir_done()
+endif
=20
 subdir('pmdinfogen')
=20
diff --git a/drivers/meson.build b/drivers/meson.build index 69d0556d3..33d=
1503f3 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -1,5 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2017 Intel Corpora=
tion
+# Copyright(c) 2017-2019 Intel Corporation
+
+if host_machine.system() =3D=3D 'windows'
+	subdir_done()
+endif
=20
 # Defines the order in which the drivers are buit.
 driver_classes =3D ['common',
diff --git a/examples/meson.build b/examples/meson.build index af81c762e..b=
c1430fa8 100644
--- a/examples/meson.build
+++ b/examples/meson.build
@@ -35,7 +35,11 @@ foreach example: examples
=20
 	ext_deps =3D [execinfo]
 	includes =3D [include_directories(example)]
-	deps =3D ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']
+	if host_machine.system() !=3D 'windows'
+		deps =3D ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']
+	else
+		deps =3D ['eal'] # only supported lib on windows currently
+	endif
 	subdir(example)
=20
 	if build
diff --git a/kernel/windows/meson.build b/kernel/windows/meson.build new fi=
le mode 100644 index 000000000..c4a2a656a
--- /dev/null
+++ b/kernel/windows/meson.build
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Intel=20
+Corporation
+
+# stub file for supporting windows logic in future release
\ No newline at end of file
diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meso=
n.build
index 5ecae0b1f..e9021c00c 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -1,23 +1,26 @@
 # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2017 Intel Corpora=
tion
+# Copyright(c) 2017-2019 Intel Corporation
=20
 eal_inc +=3D include_directories('.', 'include',
 		join_paths('include/arch', arch_subdir))
=20
 common_objs =3D []
+common_sources =3D files(
+		'eal_common_errno.c',
+		'eal_common_launch.c',
+		'eal_common_lcore.c',
+		'eal_common_log.c'
+	)
+if host_machine.system() !=3D 'windows'
 common_sources =3D files(
 	'eal_common_bus.c',
 	'eal_common_cpuflags.c',
 	'eal_common_class.c',
 	'eal_common_devargs.c',
 	'eal_common_dev.c',
-	'eal_common_errno.c',
 	'eal_common_fbarray.c',
 	'eal_common_hexdump.c',
 	'eal_common_hypervisor.c',
-	'eal_common_launch.c',
-	'eal_common_lcore.c',
-	'eal_common_log.c',
 	'eal_common_memalloc.c',
 	'eal_common_memory.c',
 	'eal_common_memzone.c',
@@ -38,6 +41,7 @@ common_sources =3D files(
 	'rte_reciprocal.c',
 	'rte_service.c'
 )
+endif
=20
 # get architecture specific sources and objs  eal_common_arch_sources =3D =
[] diff --git a/lib/meson.build b/lib/meson.build index 1fe1b4677..8d771109=
0 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -30,6 +30,10 @@ libraries =3D [
 	# flow_classify lib depends on pkt framework table lib
 	'flow_classify', 'bpf', 'telemetry']
=20
+if host_machine.system() =3D=3D 'windows'
+	libraries =3D ['kvargs','eal'] # override libraries for windows endif
+
 default_cflags =3D machine_args
 if cc.has_argument('-Wno-format-truncation')
 	default_cflags +=3D '-Wno-format-truncation'
--
2.17.1.windows.2