From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>,
dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>,
Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Allain Legacy <allain.legacy@windriver.com>,
Matt Peters <matt.peters@windriver.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] bnxt: fix receive VLAN offload flags
Date: Tue, 26 Mar 2019 17:37:32 +0000 [thread overview]
Message-ID: <642f7bb4-6439-1cef-1b52-0a32cf8f73a5@intel.com> (raw)
Message-ID: <20190326173732.nrl4soDQDP9O3PsL_PTwbEK9Xjtj36gRSxyYmHV3KZ8@z> (raw)
In-Reply-To: <CACZ4nhvyHcebyCUxX4xoOUJj=AuRZZ7XeQsAejoPFQ3Cy7Kpew@mail.gmail.com>
On 3/25/2019 9:34 PM, Ajit Khaparde wrote:
> On Mon, Mar 25, 2019 at 2:28 PM Stephen Hemminger <
> stephen@networkplumber.org> wrote:
>
>> From: Stephen Hemminger <sthemmin@microsoft.com>
>>
>> The bnxt driver is not correctly setting the receive VLAN offload
>> flags. When VLAN is offloaded the driver must set the PKT_RX_VLAN_STRIPPED
>> flag.
>>
>> Actually, several drivers have the same bug, only most of the
>> Intel drivers look right. Any driver that sets vlan_tci is probably
>> stripping the tag, and should be setting RX_VLAN_STRIPPED.
>>
>> To quote rte_mbuf.h:
>>
>> /**
>> * The RX packet is a 802.1q VLAN packet, and the tci has been
>> * saved in in mbuf->vlan_tci.
>> * If the flag PKT_RX_VLAN_STRIPPED is also present, the VLAN
>> * header has been stripped from mbuf data, else it is still
>> * present.
>> */
>>
>> Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
>> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Applied to dpdk-next-net/master, thanks.
In a quick glance, following PMDs as well set "PKT_RX_VLAN" but not
"PKT_RX_VLAN_STRIPPED", their maintainers are cc'ed, can you please double check:
- bnx2x
- qede (it doesn't set 'vlan_tci' if not stripped, should be fixed)
- dpaa2
- dpaa (is 'vlan_tci' set?)
- avp
- fm10k
next prev parent reply other threads:[~2019-03-26 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 21:27 Stephen Hemminger
2019-03-25 21:27 ` Stephen Hemminger
2019-03-25 21:34 ` Ajit Khaparde
2019-03-25 21:34 ` Ajit Khaparde
2019-03-26 17:37 ` Ferruh Yigit [this message]
2019-03-26 17:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642f7bb4-6439-1cef-1b52-0a32cf8f73a5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=allain.legacy@windriver.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=matt.peters@windriver.com \
--cc=qi.z.zhang@intel.com \
--cc=rmody@marvell.com \
--cc=shreyansh.jain@nxp.com \
--cc=shshaikh@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).