From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id D57F2A05D3
for <public@inbox.dpdk.org>; Tue, 26 Mar 2019 18:40:30 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CDFCF1B448;
Tue, 26 Mar 2019 18:40:29 +0100 (CET)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 564E41B436
for <dev@dpdk.org>; Tue, 26 Mar 2019 18:40:28 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
26 Mar 2019 10:40:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,273,1549958400"; d="scan'208";a="310592188"
Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96])
by orsmga005.jf.intel.com with ESMTP; 26 Mar 2019 10:40:26 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.7]) by
IRSMSX154.ger.corp.intel.com ([169.254.12.238]) with mapi id 14.03.0415.000;
Tue, 26 Mar 2019 17:40:25 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>, "Lu, Wenzhuo"
<wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>
Thread-Topic: [PATCH v2 2/2] app/testpmd: fix tx qinq insert enable
Thread-Index: AQHU3XEDEumPh/yJU0a8d4+JAcaeAaYeOedA
Date: Tue, 26 Mar 2019 17:40:24 +0000
Message-ID:
<8CEF83825BEC744B83065625E567D7C260D76A21@IRSMSX108.ger.corp.intel.com>
References: <20190219064840.12046-1-ndabilpuram@marvell.com>
<20190318095613.28167-1-ndabilpuram@marvell.com>
<20190318095613.28167-2-ndabilpuram@marvell.com>
In-Reply-To: <20190318095613.28167-2-ndabilpuram@marvell.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjIyN2RjYTAtM2QwYi00MmI4LWJkOWUtYzc1ODI1MzNjNzI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOERLREMxbWVuZkxyU1BpN3kxempjOURzT0IzWlFEXC9ORW0yd1BVbU5ncURhNUhSeU1qOHBcLytDTVEzMlliN2VXIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix tx qinq insert enable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190326174024.HqSmb6U6bQ45I-Vu8HPqq3ZdHC6J8Xr2VLvNZ6t0Mwc@z>
Hi Nithin
<snip>
> Subject: [PATCH v2 2/2] app/testpmd: fix tx qinq insert enable
>=20
./dpdk/devtools/check-git-log.sh -1
Wrong headline lowercase:
app/testpmd: fix tx qinq insert enable
The commit line does not seem correct as it is actually fixing the tx_qinq_=
set() function.
Otherwise=20
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
> DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes both vlan id's as
> arguments.
>=20
> Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> Cc: shahafs@mellanox.com
>=20
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> v2:
> * Split change into two seperate patches as suggested.
>=20
> app/test-pmd/config.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> f800503..0243f07 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2994,7 +2994,8 @@ tx_qinq_set(portid_t port_id, uint16_t vlan_id,
> uint16_t vlan_id_outer)
> }
>=20
> tx_vlan_reset(port_id);
> - ports[port_id].dev_conf.txmode.offloads |=3D
> DEV_TX_OFFLOAD_QINQ_INSERT;
> + ports[port_id].dev_conf.txmode.offloads |=3D
> (DEV_TX_OFFLOAD_VLAN_INSERT |
> +
> DEV_TX_OFFLOAD_QINQ_INSERT);
> ports[port_id].tx_vlan_id =3D vlan_id;
> ports[port_id].tx_vlan_id_outer =3D vlan_id_outer; }
> --
> 2.8.4