From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A02021B436 for ; Tue, 26 Mar 2019 22:16:54 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 14:16:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,274,1549958400"; d="scan'208";a="126110897" Received: from ae13-28.jf.intel.com ([10.166.188.62]) by orsmga007.jf.intel.com with ESMTP; 26 Mar 2019 14:16:53 -0700 Date: Tue, 26 Mar 2019 14:14:28 -0700 From: Jeff Shaw To: Thomas Monjalon Cc: Stephen Hemminger , Anand Rawat , dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Message-ID: <20190326211428.GA86003@ae13-28.jf.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190326060238.9884-5-anand.rawat@intel.com> <20190326120621.73d46f74@shemminger-XPS-13-9360> <5731264.uOF5Ix2MiQ@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5731264.uOF5Ix2MiQ@xps> User-Agent: Mutt/1.9.2 (2017-12-15) Subject: Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2019 21:16:55 -0000 On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > 26/03/2019 20:06, Stephen Hemminger: > > On Mon, 25 Mar 2019 23:02:34 -0700 > > Anand Rawat wrote: > > > > > +/*- > > > + * SPDX-License-Identifier: BSD-3-Clause > > > + * > > > + * Copyright (c) 1991, 1993 > > > + * The Regents of the University of California. All rights reserved. > > > + * > > > + * Redistribution and use in source and binary forms, with or without > > > + * modification, are permitted provided that the following conditions > > > + * are met: > > > + * 1. Redistributions of source code must retain the above copyright > > > + * notice, this list of conditions and the following disclaimer. > > > + * 2. Redistributions in binary form must reproduce the above copyright > > > + * notice, this list of conditions and the following disclaimer in the > > > + * documentation and/or other materials provided with the distribution. > > > + * 3. Neither the name of the University nor the names of its contributors > > > + * may be used to endorse or promote products derived from this software > > > + * without specific prior written permission. > > > + * > > > + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND > > > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > > > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > > > + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE > > > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > > > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS > > > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > > > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT > > > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY > > > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > > > + * SUCH DAMAGE. > > > + * > > > > If you have SPDX license identifier then the text boilerplate is unnecessary > > and not desired. I think we'd still need the Copyright statement there, right? > > Even better would be to get it as a dependency outside of DPDK. > Where this code come from? > How other projects on Windows get it? > It comes from FreeBSD 12.0, specifically https://github.com/freebsd/freebsd/blob/releng/12.0/sys/sys/queue.h It has been modified such that only the parts used by DPDK (i.e. TAILQ) are implemented. The other stuff has been deleted. Windows does not have sys/queue.h, so we reproduce it here. Would it better to have this as a dependency outside of DPDK? I think pulling a file from the internet and applying a patch (where we'd have to maintain a patch file inside of DPDK's repo anyway) would be overkill when we just need a few lines of code that will change very infrequently. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 92688A05D3 for ; Tue, 26 Mar 2019 22:16:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4B741B457; Tue, 26 Mar 2019 22:16:55 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A02021B436 for ; Tue, 26 Mar 2019 22:16:54 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 14:16:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,274,1549958400"; d="scan'208";a="126110897" Received: from ae13-28.jf.intel.com ([10.166.188.62]) by orsmga007.jf.intel.com with ESMTP; 26 Mar 2019 14:16:53 -0700 Date: Tue, 26 Mar 2019 14:14:28 -0700 From: Jeff Shaw To: Thomas Monjalon Cc: Stephen Hemminger , Anand Rawat , dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Message-ID: <20190326211428.GA86003@ae13-28.jf.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190326060238.9884-5-anand.rawat@intel.com> <20190326120621.73d46f74@shemminger-XPS-13-9360> <5731264.uOF5Ix2MiQ@xps> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <5731264.uOF5Ix2MiQ@xps> User-Agent: Mutt/1.9.2 (2017-12-15) Subject: Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326211428.hv7kBQBMPSJSB_Uyq5TUZXMVylHoOLUl8Jg4V7t8nto@z> On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > 26/03/2019 20:06, Stephen Hemminger: > > On Mon, 25 Mar 2019 23:02:34 -0700 > > Anand Rawat wrote: > > > > > +/*- > > > + * SPDX-License-Identifier: BSD-3-Clause > > > + * > > > + * Copyright (c) 1991, 1993 > > > + * The Regents of the University of California. All rights reserved. > > > + * > > > + * Redistribution and use in source and binary forms, with or without > > > + * modification, are permitted provided that the following conditions > > > + * are met: > > > + * 1. Redistributions of source code must retain the above copyright > > > + * notice, this list of conditions and the following disclaimer. > > > + * 2. Redistributions in binary form must reproduce the above copyright > > > + * notice, this list of conditions and the following disclaimer in the > > > + * documentation and/or other materials provided with the distribution. > > > + * 3. Neither the name of the University nor the names of its contributors > > > + * may be used to endorse or promote products derived from this software > > > + * without specific prior written permission. > > > + * > > > + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND > > > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > > > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > > > + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE > > > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > > > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS > > > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > > > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT > > > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY > > > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > > > + * SUCH DAMAGE. > > > + * > > > > If you have SPDX license identifier then the text boilerplate is unnecessary > > and not desired. I think we'd still need the Copyright statement there, right? > > Even better would be to get it as a dependency outside of DPDK. > Where this code come from? > How other projects on Windows get it? > It comes from FreeBSD 12.0, specifically https://github.com/freebsd/freebsd/blob/releng/12.0/sys/sys/queue.h It has been modified such that only the parts used by DPDK (i.e. TAILQ) are implemented. The other stuff has been deleted. Windows does not have sys/queue.h, so we reproduce it here. Would it better to have this as a dependency outside of DPDK? I think pulling a file from the internet and applying a patch (where we'd have to maintain a patch file inside of DPDK's repo anyway) would be overkill when we just need a few lines of code that will change very infrequently.