From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 86590A05D3 for ; Tue, 26 Mar 2019 22:48:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABF901B47E; Tue, 26 Mar 2019 22:48:01 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 48FEC1B479 for ; Tue, 26 Mar 2019 22:48:00 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D64F346F4; Tue, 26 Mar 2019 17:47:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 17:47:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=tpIoIJPE1n2aJKHjfO5HdVK8o0xZY79UDcMAwGBN9k8=; b=fvzOGUw8rQTJ RZFfdbtdQtTl90m9d4yj+Yr4gXATqhslH6Yrpzol/BwwEovYLPkDUMOqX3bTMDo5 y2InihGMMVPpMUhhk7NTIgzTDYcbA+M0U+n/NrRHuUuZfvt4vWi9TWHXKr4y/+Tg gxBlV4i6CeJX7LX6ZPn6aEtA83L/lWo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=tpIoIJPE1n2aJKHjfO5HdVK8o0xZY79UDcMAwGBN9 k8=; b=6bk5bymuO3Y7hVGm5wYigY5EtWUvyZN0WKek/81rjGUqlb/wKYN9sXOHY JH/RoTv/lbaKC4Chkdqi5SQFoq0FzDUZLrhKp+lPHO4dAtCCK144ciWRh3j/3GzV /VNpjiAAhBFRgu5F+K+yyaH2ny3dyBROolecEQZ5bhaRxIg6P7/34FSA9JGVCsVX gZxUe6Q9JL38rjKHK8nnx7+VUHHVS6WaisUUwMDVMv97+2dc4rg5ONCCawhYlkuI iGcOvU/H15tWxY7rbBavWhGIfdq4AvCTi8o6XP60bLADpSa8X0mmpHu/r2+Bj6he qEHFmDcqj8Xy5t5Ux/bf6VInN6DrA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedtgdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehfrhgvvgguvghskhhtohhprdhorhhgpdhgihhthhhusgdrtghomhenucfk phepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthh homhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 58FF710316; Tue, 26 Mar 2019 17:47:56 -0400 (EDT) From: Thomas Monjalon To: Jeff Shaw Cc: Stephen Hemminger , Anand Rawat , dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, bruce.richardson@intel.com Date: Tue, 26 Mar 2019 22:47:54 +0100 Message-ID: <5081191.FUufC16Il9@xps> In-Reply-To: <20190326211428.GA86003@ae13-28.jf.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <5731264.uOF5Ix2MiQ@xps> <20190326211428.GA86003@ae13-28.jf.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326214754.eK4L_uXmku045ISKOL2TpL7zO7KbFUxGmFtUEEJ3X0I@z> 26/03/2019 22:14, Jeff Shaw: > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > Even better would be to get it as a dependency outside of DPDK. > > Where this code come from? > > How other projects on Windows get it? > > It comes from FreeBSD 12.0, specifically > https://github.com/freebsd/freebsd/blob/releng/12.0/sys/sys/queue.h > > It has been modified such that only the parts used by DPDK (i.e. TAILQ) are > implemented. The other stuff has been deleted. Windows does not have sys/queue.h, > so we reproduce it here. > > Would it better to have this as a dependency outside of DPDK? I think pulling a file > from the internet and applying a patch (where we'd have to maintain a patch file > inside of DPDK's repo anyway) would be overkill when we just need a few lines of > code that will change very infrequently. We already try to get the libbsd dependency on Linux. Why not mandate libbsd for Windows? It has this header file and a lot more: https://gitlab.freedesktop.org/libbsd/libbsd/blob/master/include/bsd/sys/queue.h Relying on libbsd may avoid copying other files for Windows port.