From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2E060A05D3 for ; Tue, 26 Mar 2019 22:57:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3A151B488; Tue, 26 Mar 2019 22:57:09 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 735451B486 for ; Tue, 26 Mar 2019 22:57:08 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 14:57:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,274,1549958400"; d="scan'208";a="137650402" Received: from ae13-28.jf.intel.com ([10.166.188.62]) by fmsmga007.fm.intel.com with ESMTP; 26 Mar 2019 14:57:06 -0700 Date: Tue, 26 Mar 2019 14:54:41 -0700 From: Jeff Shaw To: Thomas Monjalon Cc: Jeff Shaw , Stephen Hemminger , Anand Rawat , dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, bruce.richardson@intel.com Message-ID: <20190326215441.GA86100@ae13-28.jf.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <5731264.uOF5Ix2MiQ@xps> <20190326211428.GA86003@ae13-28.jf.intel.com> <5081191.FUufC16Il9@xps> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <5081191.FUufC16Il9@xps> User-Agent: Mutt/1.9.2 (2017-12-15) Subject: Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326215441.Z_u46ApGl2lYIG_SQpSsRt4WpyM7-Oh5tQ2Q0cvCK5I@z> On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > 26/03/2019 22:14, Jeff Shaw: > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > Even better would be to get it as a dependency outside of DPDK. > > > Where this code come from? > > > How other projects on Windows get it? > > > > It comes from FreeBSD 12.0, specifically > > https://github.com/freebsd/freebsd/blob/releng/12.0/sys/sys/queue.h > > > > It has been modified such that only the parts used by DPDK (i.e. TAILQ) are > > implemented. The other stuff has been deleted. Windows does not have sys/queue.h, > > so we reproduce it here. > > > > Would it better to have this as a dependency outside of DPDK? I think pulling a file > > from the internet and applying a patch (where we'd have to maintain a patch file > > inside of DPDK's repo anyway) would be overkill when we just need a few lines of > > code that will change very infrequently. > > We already try to get the libbsd dependency on Linux. > Why not mandate libbsd for Windows? > It has this header file and a lot more: > https://gitlab.freedesktop.org/libbsd/libbsd/blob/master/include/bsd/sys/queue.h > > Relying on libbsd may avoid copying other files for Windows port. I like that idea, though it doesn't look like libbsd builds on Windows, do you know of a Windows version or one that doesn't depend on autotools to build?