From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A30F6A05D3 for ; Tue, 26 Mar 2019 23:24:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D49231B2AC; Tue, 26 Mar 2019 23:24:00 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id D94D11B212 for ; Tue, 26 Mar 2019 23:23:58 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 87CE946CF; Tue, 26 Mar 2019 18:23:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 18:23:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kmiZWw5w8E6ChMtxo7rBTW+fcuzDHCm6XQJ9xT+pzhg=; b=GJiIJi6ZGrU3 L/ha79nMI6qzJax3jaflup43oO9w8A87JspwM4d/Nf4jmqIMxeG7g63a8iDsc/cJ k1XodDkwOQeIcH0PjXUZQ6kltEtkIyib+BuRXl5mwinuBvcirXMkW1QvAtwyNo0k OfpVRcwLTn56/iqt+7n3ISiwtdUYoVw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=kmiZWw5w8E6ChMtxo7rBTW+fcuzDHCm6XQJ9xT+pz hg=; b=gQGd6W8LATlcmY4UiHa7l+kX8bSgzKMDq14sH2nFI0mqfH4LfsSHmekKH aiFAOrTaXMAWTAPgTxWYZrplLyWec9SY6ebU7o4xwnSncSeJ35h6BjdQZTcQ9U2p Ael3Eb30MaLUfOYvVhm5jAzY/q/WudrOrN066iNqpUXUXfQbOQtOkBlOUs8v0Iq/ VotiPkCNlSTUgslQq7Z/mjgNlG1QL9h/E1dexy+XxPu2Pw3Zr4QfgrD5iMkaA7Yd Ex3dN/yHENG/Sf+rX0BeEsl72JzXhd0OJyFtNOpAlJXuHaBBXWqaI4Qt9n+plZaF mmSFOZc5T140PBBwVRpXdjh7MBL+w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedtgdduvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehfrhgvvgguvghskhhtohhprdhorhhgpdhgihhthhhusgdrtghomhenucfk phepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthh homhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C0DF4E4210; Tue, 26 Mar 2019 18:23:53 -0400 (EDT) From: Thomas Monjalon To: Jeff Shaw Cc: Stephen Hemminger , Anand Rawat , dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, bruce.richardson@intel.com Date: Tue, 26 Mar 2019 23:23:50 +0100 Message-ID: <12533294.MXuU50Ibyh@xps> In-Reply-To: <20190326215441.GA86100@ae13-28.jf.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <5081191.FUufC16Il9@xps> <20190326215441.GA86100@ae13-28.jf.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326222350.r4DxtpN8O2135EqlBL8ufCdA-TDaM7geSPsz7IvO7zk@z> 26/03/2019 22:54, Jeff Shaw: > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > 26/03/2019 22:14, Jeff Shaw: > > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > > Even better would be to get it as a dependency outside of DPDK. > > > > Where this code come from? > > > > How other projects on Windows get it? > > > > > > It comes from FreeBSD 12.0, specifically > > > https://github.com/freebsd/freebsd/blob/releng/12.0/sys/sys/queue.h > > > > > > It has been modified such that only the parts used by DPDK (i.e. TAILQ) are > > > implemented. The other stuff has been deleted. Windows does not have sys/queue.h, > > > so we reproduce it here. > > > > > > Would it better to have this as a dependency outside of DPDK? I think pulling a file > > > from the internet and applying a patch (where we'd have to maintain a patch file > > > inside of DPDK's repo anyway) would be overkill when we just need a few lines of > > > code that will change very infrequently. > > > > We already try to get the libbsd dependency on Linux. > > Why not mandate libbsd for Windows? > > It has this header file and a lot more: > > https://gitlab.freedesktop.org/libbsd/libbsd/blob/master/include/bsd/sys/queue.h > > > > Relying on libbsd may avoid copying other files for Windows port. > > I like that idea, though it doesn't look like libbsd builds on Windows, do you > know of a Windows version or one that doesn't depend on autotools to build? It seems libbsd is not packaged for Windows. May be worth to ask opinions to libbsd maintainers. Please could you list which other headers are required for the Windows port?