DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrius Sirvys <andrius.sirvys@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] acl: fix missing flags when compiling without AVX2
Date: Wed, 27 Mar 2019 10:39:07 +0100	[thread overview]
Message-ID: <4103365.eioPbUUbMs@xps> (raw)
Message-ID: <20190327093907.nC8jKf0qcmqrqSh83TkUAb7iPXUC5M3YO4x35xnrkGo@z> (raw)
In-Reply-To: <20190311163141.GA805836@bricha3-MOBL.ger.corp.intel.com>

11/03/2019 17:31, Bruce Richardson:
> On Mon, Mar 11, 2019 at 03:18:11PM +0000, Andrius Sirvys wrote:
> > When compiling the ACL library on a system without AVX2 support,
> > the flags used to compile the AVX2-specific code for later run-time
> > use were not based on the regular cflags for the rest of the library.
> > This can cause errors due to symbols being missed/undefined
> > due to incorrect flags. For example,
> > when testing compilation on Alpine linux, we got:
> > 	error: unknown type name 'cpu_set_t'
> > due to _GNU_SOURCE not being defined in the cflags.
> > 
> > This issue can be fixed by appending "-mavx2" to
> > the cflags rather than replacing them with it.
> > 
> > Fixes: 5b9656b157d3 ("lib: build with meson")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> > ---
> > --- a/lib/librte_acl/meson.build
> > +++ b/lib/librte_acl/meson.build
> > -				c_args: '-mavx2')
> > +				c_args: cflags +  ['-mavx2'])
> 
> Looks to be 2 spaces rather than 1 before the opening "[", but not a big
> deal and can be fixed on apply if necessary.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied (without double space), thanks




  reply	other threads:[~2019-03-27  9:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 15:18 Andrius Sirvys
2019-03-11 16:31 ` Bruce Richardson
2019-03-27  9:39   ` Thomas Monjalon [this message]
2019-03-27  9:39     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4103365.eioPbUUbMs@xps \
    --to=thomas@monjalon.net \
    --cc=andrius.sirvys@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).