From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A8CA1A05D3 for ; Wed, 27 Mar 2019 12:14:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82FF95F1D; Wed, 27 Mar 2019 12:14:48 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 70A7D5B26 for ; Wed, 27 Mar 2019 12:14:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 142E721C5F; Wed, 27 Mar 2019 07:14:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 27 Mar 2019 07:14:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=bzQM9T8qWR3qXBOIwGpd9lkVzBsUDBxE8zW7PfnUPZg=; b=bKp77rfcp5+m 3K/00DtvkKlijNt/iIhlqJkbUR0NW7uT+9PSHmuahw8nNdkrwbcYhkk9/Demm+Ub 6K0Acd8RLtyb9hM7S3bIbigcGAgSKVDK3tJJQNem4eBPBP+ju7XhbFdNunbe9StG PBDev38BL5E8bVuddFoTU7Nx7TVu4Ig= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=bzQM9T8qWR3qXBOIwGpd9lkVzBsUDBxE8zW7PfnUP Zg=; b=eu5Bs83kSwGNhEOKyn/t/TVfMpdbPGjhWVAm1HffKCHothUwM7yb/vIwI I2roYxQ0mHhFZLSko1cczxV/bvZENofflVQp+S1yNuHtIwEL4QglVgRG5ATQUPD9 7SLdo8NIaBksYr/zrudWCwu4u5gvoBTNr0n4KwwTKBNx1jQTep+M0ApFS71R6Uil IF5eEYwnKUQZ80D4+G568R3MeOR5Cr2QMc+Lihhe4lyPZzw5uL99bELJMd0QOT+9 ITaH9uJUN9GvETXS94BJA9Ty7zkPZu2z2A006PnozMJAIEML2YmKrLlgqJGMKNkr sqTPrRSpYIcZLEIVxaujuK1FGBYCw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedvgddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 10CBE1030F; Wed, 27 Mar 2019 07:14:45 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, maxime.coquelin@redhat.com Date: Wed, 27 Mar 2019 12:14:44 +0100 Message-ID: <4147107.f6clCcuQYr@xps> In-Reply-To: <20190321195910.11140-1-stephen@networkplumber.org> References: <20190321195910.11140-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327111444.Qd_V-y5aw7fV5KqdBpn2V3wUsJe1p0chplYusGaRIEY@z> 21/03/2019 20:59, Stephen Hemminger: > The divisor is not modified here. Doesn't really matter for optimizaton > since the function is inline already; but helps with expressing > intent. > > Signed-off-by: Stephen Hemminger > --- > static __rte_always_inline uint64_t > -rte_reciprocal_divide_u64(uint64_t a, struct rte_reciprocal_u64 *R) > +rte_reciprocal_divide_u64(uint64_t a, const struct rte_reciprocal_u64 *R) Why not doing the same change for rte_reciprocal_divide()? Should we advertise such API change?