From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0B47AA05D3 for ; Wed, 27 Mar 2019 12:21:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD2351B13C; Wed, 27 Mar 2019 12:21:31 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id EC12C5F2A for ; Wed, 27 Mar 2019 12:21:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 21786220BD; Wed, 27 Mar 2019 07:21:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 27 Mar 2019 07:21:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=LeCsXpILHp5mFkQhmoazlkhiZbtGwiuN2wKhtTKLRDA=; b=HLzLhCfKFauP hV7tIzA1kc5jsyihIPsYihZDgS2GvPUvliVwj7fSSBLY+6S8hntaK9wK/M9rQBKM DyP3/ZivT5Z/m71HR/YHSpqrtNoxP506WZijY+Rf7tr0n0vR9hbyB0bUchLGWi78 fyZ7C0jc4/NOElM6jEyW/HNfbb9qZl4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LeCsXpILHp5mFkQhmoazlkhiZbtGwiuN2wKhtTKLR DA=; b=x5vduytTTyUC3DlAVMKI+ygJRXsB3C4QfnyjAfbL/j0p5h3281n7p3ooI zdSfEbuB1opsVCCe1Yw+vIwsE0QswFU15UTour0ChgMcknlt3sfd2N7VWun1+cgs tooazHPSrEoRcKaawg7/yoKgFxM8yb3FTCJeB0kEDQ9uNScLGuYcRVlqbu831UKU Z3KOqscQEyJFxaddgIlwcna+uWlPmbvOTiO67UiOdUHeoDa/I1q3zlYMl7se6Jhh bhez1WsYJT1335ANR/s1GzMGKmbVQvTEAEK2mwOewrd/u/UgIROf//4ZnvlZi0lE lqr3lyR6CQLbXZu7PuDCf7WAojpcQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedvgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 64516E4841; Wed, 27 Mar 2019 07:21:27 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, olivier.matz@6wind.com, pablo.de.lara.guarch@intel.com, ramirose@gmail.com Date: Wed, 27 Mar 2019 12:21:25 +0100 Message-ID: <2813505.FGjIkkUpHa@xps> In-Reply-To: <20190321230341.6576-1-stephen@networkplumber.org> References: <20190321230341.6576-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] rte_ring: add newline to error message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327112125.Je4O3h5KdqXBfFSCDopSSWqxFM9-fFAOKqZbjMOZMjg@z> 22/03/2019 00:03, Stephen Hemminger: > Log message should end with newline. > > Fixes: 4e32101f9b01 ("ring: support freeing") > Signed-off-by: Stephen Hemminger > --- > - RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()"); > + RTE_LOG(ERR, RING, > + "Cannot free ring (not created with rte_ring_create()\n"); While at it, could you fix the parens? I think it would be better to replace the first paren with a comma.