DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	Akhil Goyal <akhil.goyal@nxp.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH v2] examples/multi_process/symmetric_mp: fix link check
Date: Wed, 27 Mar 2019 11:33:08 +0000	[thread overview]
Message-ID: <20190327112348.12785-1-akhil.goyal@nxp.com> (raw)
Message-ID: <20190327113308.81DuHDmU1e3pIf6RxS5JM_CG2fST9k1o3Clf6DtpGRw@z> (raw)
In-Reply-To: <20190327111318.12347-1-akhil.goyal@nxp.com>

link check is done for primary process for the ports
which are given in the port mask and not the complete
set of ports.

Fixes: d3641ae86313 ("examples: update link status checks")
Cc: stable@dpdk.org

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 examples/multi_process/symmetric_mp/main.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c
index c310e942b..7fb2a24ea 100644
--- a/examples/multi_process/symmetric_mp/main.c
+++ b/examples/multi_process/symmetric_mp/main.c
@@ -73,6 +73,7 @@ static unsigned num_procs = 0;
 
 static uint16_t ports[RTE_MAX_ETHPORTS];
 static unsigned num_ports = 0;
+static uint16_t port_mask;
 
 static struct lcore_ports lcore_ports[RTE_MAX_LCORE];
 static struct port_stats pstats[RTE_MAX_ETHPORTS];
@@ -115,7 +116,7 @@ smp_parse_args(int argc, char **argv)
 	int opt, ret;
 	char **argvopt;
 	int option_index;
-	uint16_t i, port_mask = 0;
+	uint16_t i;
 	char *prgname = argv[0];
 	static struct option lgopts[] = {
 			{PARAM_NUM_PROCS, 1, 0, 0},
@@ -349,7 +350,7 @@ lcore_main(void *arg __rte_unused)
 
 /* Check the link status of all ports in up to 9s, and print them finally */
 static void
-check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
+check_all_ports_link_status(uint16_t port_num, uint32_t mask)
 {
 #define CHECK_INTERVAL 100 /* 100ms */
 #define MAX_CHECK_TIME 90 /* 9s (90 * 100ms) in total */
@@ -362,7 +363,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
 	for (count = 0; count <= MAX_CHECK_TIME; count++) {
 		all_ports_up = 1;
 		for (portid = 0; portid < port_num; portid++) {
-			if ((port_mask & (1 << portid)) == 0)
+			if ((mask & (1 << portid)) == 0)
 				continue;
 			memset(&link, 0, sizeof(link));
 			rte_eth_link_get_nowait(portid, &link);
@@ -451,7 +452,7 @@ main(int argc, char **argv)
 	}
 
 	if (proc_type == RTE_PROC_PRIMARY)
-		check_all_ports_link_status((uint8_t)num_ports, (~0x0));
+		check_all_ports_link_status(rte_eth_dev_count(), port_mask);
 
 	assign_ports_to_cores();
 
-- 
2.17.1


  parent reply	other threads:[~2019-03-27 11:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 11:22 [dpdk-dev] [PATCH] " Akhil Goyal
2019-03-27 11:22 ` Akhil Goyal
2019-03-27 11:33 ` Akhil Goyal [this message]
2019-03-27 11:33   ` [dpdk-dev] [PATCH v2] " Akhil Goyal
2019-04-05 12:42   ` Burakov, Anatoly
2019-04-05 12:42     ` Burakov, Anatoly
2019-04-05 13:03   ` Thomas Monjalon
2019-04-05 13:03     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190327112348.12785-1-akhil.goyal@nxp.com \
    --to=akhil.goyal@nxp.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).