From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 13B79A05D3 for ; Wed, 27 Mar 2019 12:35:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2AF1C1B0FC; Wed, 27 Mar 2019 12:35:34 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 43BD85681; Wed, 27 Mar 2019 12:35:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 04:35:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,276,1549958400"; d="scan'208";a="129073736" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga008.jf.intel.com with ESMTP; 27 Mar 2019 04:35:30 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.205]) by irsmsx110.ger.corp.intel.com ([169.254.15.102]) with mapi id 14.03.0415.000; Wed, 27 Mar 2019 11:35:29 +0000 From: "Daly, Lee" To: "Cel, TomaszX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Trahe, Fiona" , "Tucker, Greg B" , "Jozwiak, TomaszX" Thread-Topic: [PATCH] compress/isal: fix compression stream initialization Thread-Index: AQHU47gzuF+0No46NkeBtZxwNmQWr6YfUKIA Date: Wed, 27 Mar 2019 11:35:28 +0000 Message-ID: References: <1553593329-8075-1-git-send-email-tomaszx.cel@intel.com> In-Reply-To: <1553593329-8075-1-git-send-email-tomaszx.cel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDRhYTNhMTQtNmUwZi00NDAyLTk5MGEtMWZmOWVlY2E2ZGU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicDRcL0ViRkh4Z0VrWU5ROWNIR1hVYytGR0dSYytDS2JaRjNjRVF5aGpGR01pUnBud0RqT05RWkx4c0pteXRtNUoifQ== x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] compress/isal: fix compression stream initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327113528.6mZ5y-gH22p-U_VBZm0RrZNGlyRTEq9o6uAGltbozmY@z> Hi Tomasz, > -----Original Message----- > From: Cel, TomaszX > Sent: Tuesday, March 26, 2019 9:42 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Trahe, Fiona ; Daly, Lee > ; Tucker, Greg B ; Jozwiak, > TomaszX > Subject: [PATCH] compress/isal: fix compression stream initialization >=20 > This patch fixes ISAL internal state fields initialization. >=20 > Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality"= ) > Cc: stable@dpdk.org >=20 > Signed-off-by: Tomasz Cel > --- > drivers/compress/isal/isal_compress_pmd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/compress/isal/isal_compress_pmd.c > b/drivers/compress/isal/isal_compress_pmd.c > index 8879a42..1e518b3 100644 > --- a/drivers/compress/isal/isal_compress_pmd.c > +++ b/drivers/compress/isal/isal_compress_pmd.c > @@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct > isal_comp_qp *qp, > uint8_t *temp_level_buf =3D qp->stream->level_buf; >=20 > /* Initialize compression stream */ > - isal_deflate_stateless_init(qp->stream); > + isal_deflate_init(qp->stream); >=20 > qp->stream->level_buf =3D temp_level_buf; >=20 > @@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct > isal_comp_qp *qp, > op->output_chksum =3D qp->stream->internal_state.crc; > } >=20 > - isal_deflate_reset(qp->stream); I have tested this and it works, removing this reset function makes sense a= s everything cleared here is cleared in the init function anyway, On that note, the same is to be said to isal_inflate_reset, everything clea= red in reset is cleared, plus more, in isal_inflate_init. I suggest we also remove isal_inflate_reset for commonality across both fun= ctions. > - > return ret; > } >=20 > -- > 2.7.4