From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130058.outbound.protection.outlook.com [40.107.13.58]) by dpdk.org (Postfix) with ESMTP id 1D3001B20E; Wed, 27 Mar 2019 12:53:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XoPIclGAf+g6gK6g1enFPaHH3xCWtYr08qQ1UPTGzkU=; b=Dq4UQMqFmqKygIu3388Gb0vF14QamuXnjYWv1j+qPVBD1tEJCmiL7rYkTq6xWTfd7IVwSsdyp4eg/OUjEAOsJO1ZtbP2lWg9o8/QA+5N/pyaHKDsn7sUl9hvq8h6RVIKuyEll4Jw4gygLD5C0hO/XM+imXro6yJTeiC85LxyI74= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB3072.eurprd04.prod.outlook.com (10.170.228.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.19; Wed, 27 Mar 2019 11:53:31 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::d81a:c2cb:6bce:30bb]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::d81a:c2cb:6bce:30bb%4]) with mapi id 15.20.1750.014; Wed, 27 Mar 2019 11:53:31 +0000 From: Akhil Goyal To: "dev@dpdk.org" CC: Hemant Agrawal , Akhil Goyal , "stable@dpdk.org" Thread-Topic: [PATCH 1/6] crypto/dpaa2_sec: fix session clear Thread-Index: AQHU5JOyLJ7DEks8Qkyk/1UGJQ6Cvw== Date: Wed, 27 Mar 2019 11:53:30 +0000 Message-ID: <20190327114407.13697-2-akhil.goyal@nxp.com> References: <20190327114407.13697-1-akhil.goyal@nxp.com> In-Reply-To: <20190327114407.13697-1-akhil.goyal@nxp.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BMXPR01CA0061.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:2c::25) To VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:56::26) x-mailer: git-send-email 2.17.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.120.1.68] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba6eb1f2-a295-4eaf-fc40-08d6b2aad4eb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB3072; x-ms-traffictypediagnostic: VI1PR04MB3072: x-microsoft-antispam-prvs: x-forefront-prvs: 0989A7979C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(346002)(396003)(376002)(366004)(199004)(189003)(2351001)(106356001)(256004)(71190400001)(14444005)(25786009)(5660300002)(71200400001)(105586002)(446003)(6506007)(386003)(26005)(8676002)(450100002)(4326008)(1730700003)(81156014)(53936002)(66066001)(4744005)(81166006)(54906003)(2616005)(11346002)(86362001)(476003)(486006)(5640700003)(8936002)(316002)(68736007)(6486002)(99286004)(3846002)(6116002)(6512007)(6436002)(6916009)(44832011)(2501003)(14454004)(186003)(478600001)(52116002)(76176011)(50226002)(1076003)(36756003)(305945005)(97736004)(102836004)(7736002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB3072; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kqimRsD+sQs6sKJjiI4gyxWWNbnZxDjY/wyAT5KLQPsf5ePCGl8mufX35h1bchF5kUBgL90PaBBGcZ3KT0jfkxv3PwPybw2SNjcRvDjdN8zNi3UNprBzsSQku5wlHa0n5kkG8TnLUTL1SHtopRO5k963liXgJf5yqrDJ87umxZ9PfE2KFCjxE1+kt8iAAF9Ah3/26u39BGriQxINIyorN27Tthb6WlwXLaI0yJMEIbqlKrVjv4Y1M2pJxgWRPRL4EAhRmeMBymfaaE83ATX3k61ENvm5Uxa/guqnHzIOM+4FK2ke7R/WYYSw2OKWsiCgfYlYFxDs2o081cYGk+CF/JSWXdjraDrUcyMeGmLU0t3iGv4LFIx9hF/LMFhim41eevEwgBzV8Ef6PtA4amXuV4g8Ucgrp78HVsa4YoqTOIs= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba6eb1f2-a295-4eaf-fc40-08d6b2aad4eb X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2019 11:53:30.9706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3072 Subject: [dpdk-dev] [PATCH 1/6] crypto/dpaa2_sec: fix session clear X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 11:53:33 -0000 private data should be cleared instead of the complete session Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: stable@dpdk.org Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/d= paa2_sec/dpaa2_sec_dpseci.c index c2c22515d..d955ffc45 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -2912,7 +2912,7 @@ dpaa2_sec_sym_session_clear(struct rte_cryptodev *dev= , rte_free(s->ctxt); rte_free(s->cipher_key.data); rte_free(s->auth_key.data); - memset(sess, 0, sizeof(dpaa2_sec_session)); + memset(s, 0, sizeof(dpaa2_sec_session)); struct rte_mempool *sess_mp =3D rte_mempool_from_obj(sess_priv); set_sym_session_private_data(sess, index, NULL); rte_mempool_put(sess_mp, sess_priv); --=20 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BBE99A05D3 for ; Wed, 27 Mar 2019 12:53:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2D6C1B21A; Wed, 27 Mar 2019 12:53:34 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130058.outbound.protection.outlook.com [40.107.13.58]) by dpdk.org (Postfix) with ESMTP id 1D3001B20E; Wed, 27 Mar 2019 12:53:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XoPIclGAf+g6gK6g1enFPaHH3xCWtYr08qQ1UPTGzkU=; b=Dq4UQMqFmqKygIu3388Gb0vF14QamuXnjYWv1j+qPVBD1tEJCmiL7rYkTq6xWTfd7IVwSsdyp4eg/OUjEAOsJO1ZtbP2lWg9o8/QA+5N/pyaHKDsn7sUl9hvq8h6RVIKuyEll4Jw4gygLD5C0hO/XM+imXro6yJTeiC85LxyI74= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB3072.eurprd04.prod.outlook.com (10.170.228.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.19; Wed, 27 Mar 2019 11:53:31 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::d81a:c2cb:6bce:30bb]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::d81a:c2cb:6bce:30bb%4]) with mapi id 15.20.1750.014; Wed, 27 Mar 2019 11:53:31 +0000 From: Akhil Goyal To: "dev@dpdk.org" CC: Hemant Agrawal , Akhil Goyal , "stable@dpdk.org" Thread-Topic: [PATCH 1/6] crypto/dpaa2_sec: fix session clear Thread-Index: AQHU5JOyLJ7DEks8Qkyk/1UGJQ6Cvw== Date: Wed, 27 Mar 2019 11:53:30 +0000 Message-ID: <20190327114407.13697-2-akhil.goyal@nxp.com> References: <20190327114407.13697-1-akhil.goyal@nxp.com> In-Reply-To: <20190327114407.13697-1-akhil.goyal@nxp.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BMXPR01CA0061.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:2c::25) To VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:56::26) x-mailer: git-send-email 2.17.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.120.1.68] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba6eb1f2-a295-4eaf-fc40-08d6b2aad4eb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB3072; x-ms-traffictypediagnostic: VI1PR04MB3072: x-microsoft-antispam-prvs: x-forefront-prvs: 0989A7979C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(346002)(396003)(376002)(366004)(199004)(189003)(2351001)(106356001)(256004)(71190400001)(14444005)(25786009)(5660300002)(71200400001)(105586002)(446003)(6506007)(386003)(26005)(8676002)(450100002)(4326008)(1730700003)(81156014)(53936002)(66066001)(4744005)(81166006)(54906003)(2616005)(11346002)(86362001)(476003)(486006)(5640700003)(8936002)(316002)(68736007)(6486002)(99286004)(3846002)(6116002)(6512007)(6436002)(6916009)(44832011)(2501003)(14454004)(186003)(478600001)(52116002)(76176011)(50226002)(1076003)(36756003)(305945005)(97736004)(102836004)(7736002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB3072; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kqimRsD+sQs6sKJjiI4gyxWWNbnZxDjY/wyAT5KLQPsf5ePCGl8mufX35h1bchF5kUBgL90PaBBGcZ3KT0jfkxv3PwPybw2SNjcRvDjdN8zNi3UNprBzsSQku5wlHa0n5kkG8TnLUTL1SHtopRO5k963liXgJf5yqrDJ87umxZ9PfE2KFCjxE1+kt8iAAF9Ah3/26u39BGriQxINIyorN27Tthb6WlwXLaI0yJMEIbqlKrVjv4Y1M2pJxgWRPRL4EAhRmeMBymfaaE83ATX3k61ENvm5Uxa/guqnHzIOM+4FK2ke7R/WYYSw2OKWsiCgfYlYFxDs2o081cYGk+CF/JSWXdjraDrUcyMeGmLU0t3iGv4LFIx9hF/LMFhim41eevEwgBzV8Ef6PtA4amXuV4g8Ucgrp78HVsa4YoqTOIs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba6eb1f2-a295-4eaf-fc40-08d6b2aad4eb X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2019 11:53:30.9706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3072 Subject: [dpdk-dev] [PATCH 1/6] crypto/dpaa2_sec: fix session clear X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327115330.jfidJO4g-mFoVzuS6FsFjX1QzU5b9aMDSv41r8o2q7Y@z> private data should be cleared instead of the complete session Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: stable@dpdk.org Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/d= paa2_sec/dpaa2_sec_dpseci.c index c2c22515d..d955ffc45 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -2912,7 +2912,7 @@ dpaa2_sec_sym_session_clear(struct rte_cryptodev *dev= , rte_free(s->ctxt); rte_free(s->cipher_key.data); rte_free(s->auth_key.data); - memset(sess, 0, sizeof(dpaa2_sec_session)); + memset(s, 0, sizeof(dpaa2_sec_session)); struct rte_mempool *sess_mp =3D rte_mempool_from_obj(sess_priv); set_sym_session_private_data(sess, index, NULL); rte_mempool_put(sess_mp, sess_priv); --=20 2.17.1