From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6EA44A05D3 for ; Wed, 27 Mar 2019 12:52:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F28261B207; Wed, 27 Mar 2019 12:52:18 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7A3211B1FF; Wed, 27 Mar 2019 12:52:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 04:52:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,276,1549958400"; d="scan'208";a="286302538" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.103]) ([10.237.220.103]) by orsmga004.jf.intel.com with ESMTP; 27 Mar 2019 04:52:14 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org References: <72f990b04219f319b2922570a7ca7b9ce93e0aae.1550851129.git.anatoly.burakov@intel.com> <10158735.WBPJjXTH6e@xps> From: "Burakov, Anatoly" Message-ID: <7a0681ab-b71d-9a43-e4de-4827bed69ccc@intel.com> Date: Wed, 27 Mar 2019 11:52:13 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <10158735.WBPJjXTH6e@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] mem: warn user when running without NUMA support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327115213.zmxc78VH2bEJ7sTSHii2aPeCZCja4HCY5PWhxquyGec@z> On 27-Mar-19 10:31 AM, Thomas Monjalon wrote: > 22/02/2019 16:59, Anatoly Burakov: >> Running in non-legacy mode on a NUMA-enabled system without libnuma >> is unsupported, so explicitly print out a warning when trying to >> do so. >> >> Running in legacy mode without libnuma is still supported whether or >> not we are running with libnuma support enabled, so also fix init to >> allow that scenario. >> >> Cc: stable@dpdk.org >> >> Signed-off-by: Anatoly Burakov >> --- >> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c >> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c >> @@ -50,6 +50,7 @@ >> #include "eal_internal_cfg.h" >> #include "eal_filesystem.h" >> #include "eal_hugepages.h" >> +#include "eal_options.h" > > I'm seeing this error: > > lib/librte_eal/common/eal_options.h:74:28: error: > array type has incomplete element type ‘struct option’ > extern const struct option eal_long_options[]; > Yes, i've been meaning to resubmit but it fell through the cracks. I'll do a v2 ASAP. -- Thanks, Anatoly