From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples: detect build directory rather than hardcoding
Date: Wed, 27 Mar 2019 15:02:29 +0000 [thread overview]
Message-ID: <b30e6c7a-bd98-9f62-5b69-1838096bee47@intel.com> (raw)
Message-ID: <20190327150229.hSqmjgszjA27ldJyru3sNM74t42DwWfHIwQl0wnCw2s@z> (raw)
In-Reply-To: <20190327135805.11067-1-bruce.richardson@intel.com>
On 3/27/2019 1:58 PM, Bruce Richardson wrote:
> Most examples have in their makefiles a default RTE_TARGET directory to be
> used in case RTE_TARGET is not set. Rather than just using a hard-coded
> default, we can instead detect what the build directory is relative to
> RTE_SDK directory.
>
> This fixes a potential issue for anyone who continues to build using
> "make install T=x86_64-native-linuxapp-gcc" and skips setting RTE_TARGET
> explicitly, instead relying on the fact that they were building in a
> directory which corresponded to the example default path - which was
> changed to "x86_64-native-linux-gcc" by commit 218c4e68c1d9 ("mk: use
> linux and freebsd in config names").
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2019-03-27 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 13:58 Bruce Richardson
2019-03-27 13:58 ` Bruce Richardson
2019-03-27 15:02 ` Ferruh Yigit [this message]
2019-03-27 15:02 ` Ferruh Yigit
2019-03-30 0:14 ` Thomas Monjalon
2019-03-30 0:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b30e6c7a-bd98-9f62-5b69-1838096bee47@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).