From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id E8F09A05D3
for <public@inbox.dpdk.org>; Wed, 27 Mar 2019 19:11:47 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id F16A9568A;
Wed, 27 Mar 2019 19:11:46 +0100 (CET)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C0F3D4D3A;
Wed, 27 Mar 2019 19:11:45 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 5211A21C9C;
Wed, 27 Mar 2019 14:11:45 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Wed, 27 Mar 2019 14:11:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=4Qqo9W+MJNiN5A46g4s8RWlqZ5u5P6Uo9rpADoXUSnw=; b=NwCSPAWeAtY7
WmNnmizDsUjjvq/8QPCuvtNt1VE32tMGgV26j19XTqxU3kPDzrlIY4v4Z/T1Sg/e
LLpJaDQOwGmswHG9RfgmP5lm9reygCOF1MAduUkBKtmudPK+8K0vtLpGMR6j0Ba1
jsYMyl32EWPu5jpNVP76JG+Z6ervcRQ=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=4Qqo9W+MJNiN5A46g4s8RWlqZ5u5P6Uo9rpADoXUS
nw=; b=os7HlkJP7STkRzbI9IxpjtMzxFttUmue2meEZE1LAi0jXFiGTQPXm2y6q
vKinRSgyyCbpiX+8cF6eAMn+n9uGwoT2K0hnYGY94UvgxOBi7fqMxnDMFX8yWggj
moJ2oB0JZCR/0dl3JsJcJoikKy/BAxuiXpuzWXGUlWA5PX06BVpOSK8i7p51rOBR
rYX1xsaHqstzcR0Y+iPFMZjGpK5iqzjlDycNnqPB1BjASMsnQibHKL0G6wzTi+t6
SKvd5Akx6tiKiOe+Av6TYB2Zr2xnaBMvWvfYgMf1OJUeYtYR62htiJGfKOnRQM+G
O9txSVBoczpySDPUaH785gzuGQKSA==
X-ME-Sender: <xms:4LybXDJJp6nlJLpUkF2_JJvvtHqegdrZLk9XUJZPInEfFsFhrARU3Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedvgddutdegucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh
ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:4LybXDcDwB9k1YYs9F8eNcEZyWk5nukmiFWnsSazaITFqHr8_xgUIA>
<xmx:4LybXOfRV7-SX2OSENW-T1rMaM5i0bj5hZKkJDMf4kiBKooGmjQLQQ>
<xmx:4LybXOOIgQq1oKautDmo4HgFTHzoKMP-2oGAJCMO81GV_wEUhGJXQA>
<xmx:4bybXPKocQv7kuZBzgGc96YgX2sZs1sty99zi1P-B2BcYn9awr83qg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 742E010394;
Wed, 27 Mar 2019 14:11:43 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>, stable@dpdk.org
Date: Wed, 27 Mar 2019 19:11:41 +0100
Message-ID: <2545420.xP4CxeWPSp@xps>
In-Reply-To: <20190326184331.13850-1-dariusz.stojaczyk@intel.com>
References: <20190326184331.13850-1-dariusz.stojaczyk@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] eal: initialize alarms early
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190327181141.ja62ryrY52L2BFuG63hknG4NvPwsMCKZZy0mqstUhGA@z>
26/03/2019 19:43, Darek Stojaczyk:
> We currently initialize rte_alarms after starting
> to listen for IPC hotplug requests, which gives
> us a data race window. Upon receiving such hotplug
> request we always try to set an alarm and this
> obviously doesn't work if the alarms weren't
> initialized yet.
>
> To fix it, we initialize alarms before starting
> to listen for IPC hotplug messages. Specifically,
> we move rte_eal_alarm_init() right after
> rte_eal_intr_init() as it makes some sense to
> keep those two close to each other.
I wonder which regression it will bring :)
The experience shows that we cannot touch this function
without introducing a regression. Please check twice.
> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> Cc: Qi Zhang <qi.z.zhang@intel.com>
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> Cc: stable@dpdk.org
>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
> lib/librte_eal/linux/eal/eal.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
You probably need to update the FreeBSD version too.