From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 41F4F11A4 for <dev@dpdk.org>; Wed, 27 Mar 2019 22:08:48 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id g12so3890801pll.11 for <dev@dpdk.org>; Wed, 27 Mar 2019 14:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6MHyJmT0vJaMBBZ2ZqXJzl1nO2TTpXumzwsQYNtPGwA=; b=XaBHM9LTepRmLl/CJeqtfQYq2IYC9JGV1lv+zobPPivTZ9vHKB7/KcLxATGagosYz/ OsJpLPmc/D3RtBQWhH9APOAandeWWHlTlil2S2roJSKyO9yhi7/xsBkBUyVDxsJyVYhM fLuIXjmG4ScOexd1iZ4Ydi19ve6LS5cvZsJlWKuSpWNJWZ6DSu4gRaGkS3uaPTbp4t3T hDgEBGPTAkHvn+EBKVxHKoOoaoEbE3wggMzaCLA4sEyVvrVY07WDWBcqiP3SCShyOgO6 8UQ2J/5Ktyr5yfLtSIaRspSiZJpwlyWWwyPwgzAxALPd6zpWrrLt0aIBLwi4rtkba/x7 wM2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6MHyJmT0vJaMBBZ2ZqXJzl1nO2TTpXumzwsQYNtPGwA=; b=CIsEgS5cmdBNRYL74/L/uamFEFgTlG8D8PuwtydDnQB+qOLmv8Sm7lq4LtJut58C+g b7ZVFOlyRowHTz/lVI0/D7Yj8e2CSYVUjJP0KNZ7ojZrm2tAm3I75A6UYkEtuKB1mFYP QcX4Yb/Owvo8Czr7u8TJ366juhpznCpPjRIJUlTMSCl+brYSd07jNlqGvOpoYyQEOOPD cmJOlsdI9nfHeO9qQ3fLru1V5VS3IkRAg+y0LO/VRIHVpKx4P0pKtFMibPPVEdvY1rpS GT42lAYrq9W5Qt2yIc4ccf7mXq+xcwBJtjCpz3p42V0mNkF82E71fxxkV/BM1xdFhcsl r/Bg== X-Gm-Message-State: APjAAAXB9YqlW+SQnzfbaVgIUPNalG+7ntm8MDDaMHFeLbVNHgvXRopX 00hsUDfL7bdN42cUUnYSUmuo9Q== X-Google-Smtp-Source: APXvYqy3DybNkUj4cdkiB63ZARQEJIQQa9cp7lu8NP2krQGR8AYxEGhF3w0UyGJV+9b/c9ztmzGvmA== X-Received: by 2002:a17:902:22f:: with SMTP id 44mr39590564plc.138.1553720927502; Wed, 27 Mar 2019 14:08:47 -0700 (PDT) Received: from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l69sm19421348pga.73.2019.03.27.14.08.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 14:08:46 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>, Stephen Hemminger <sthemmin@microsoft.com> Date: Wed, 27 Mar 2019 14:08:42 -0700 Message-Id: <20190327210843.13813-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190327210843.13813-1-stephen@networkplumber.org> References: <20190327210843.13813-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 1/2] net/netvsc: fix lgtm static checker complaint X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 27 Mar 2019 21:08:48 -0000 Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> --- drivers/net/netvsc/hn_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 6197118b01ee..8818d68cea5c 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -123,7 +123,7 @@ hn_update_packet_stats(struct hn_stats *stats, const struct rte_mbuf *m) stats->size_bins[0]++; else if (s < 1519) stats->size_bins[6]++; - else if (s >= 1519) + else stats->size_bins[7]++; } -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1AC28A05D3 for <public@inbox.dpdk.org>; Wed, 27 Mar 2019 22:08:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58A044CAB; Wed, 27 Mar 2019 22:08:52 +0100 (CET) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 41F4F11A4 for <dev@dpdk.org>; Wed, 27 Mar 2019 22:08:48 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id g12so3890801pll.11 for <dev@dpdk.org>; Wed, 27 Mar 2019 14:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6MHyJmT0vJaMBBZ2ZqXJzl1nO2TTpXumzwsQYNtPGwA=; b=XaBHM9LTepRmLl/CJeqtfQYq2IYC9JGV1lv+zobPPivTZ9vHKB7/KcLxATGagosYz/ OsJpLPmc/D3RtBQWhH9APOAandeWWHlTlil2S2roJSKyO9yhi7/xsBkBUyVDxsJyVYhM fLuIXjmG4ScOexd1iZ4Ydi19ve6LS5cvZsJlWKuSpWNJWZ6DSu4gRaGkS3uaPTbp4t3T hDgEBGPTAkHvn+EBKVxHKoOoaoEbE3wggMzaCLA4sEyVvrVY07WDWBcqiP3SCShyOgO6 8UQ2J/5Ktyr5yfLtSIaRspSiZJpwlyWWwyPwgzAxALPd6zpWrrLt0aIBLwi4rtkba/x7 wM2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6MHyJmT0vJaMBBZ2ZqXJzl1nO2TTpXumzwsQYNtPGwA=; b=CIsEgS5cmdBNRYL74/L/uamFEFgTlG8D8PuwtydDnQB+qOLmv8Sm7lq4LtJut58C+g b7ZVFOlyRowHTz/lVI0/D7Yj8e2CSYVUjJP0KNZ7ojZrm2tAm3I75A6UYkEtuKB1mFYP QcX4Yb/Owvo8Czr7u8TJ366juhpznCpPjRIJUlTMSCl+brYSd07jNlqGvOpoYyQEOOPD cmJOlsdI9nfHeO9qQ3fLru1V5VS3IkRAg+y0LO/VRIHVpKx4P0pKtFMibPPVEdvY1rpS GT42lAYrq9W5Qt2yIc4ccf7mXq+xcwBJtjCpz3p42V0mNkF82E71fxxkV/BM1xdFhcsl r/Bg== X-Gm-Message-State: APjAAAXB9YqlW+SQnzfbaVgIUPNalG+7ntm8MDDaMHFeLbVNHgvXRopX 00hsUDfL7bdN42cUUnYSUmuo9Q== X-Google-Smtp-Source: APXvYqy3DybNkUj4cdkiB63ZARQEJIQQa9cp7lu8NP2krQGR8AYxEGhF3w0UyGJV+9b/c9ztmzGvmA== X-Received: by 2002:a17:902:22f:: with SMTP id 44mr39590564plc.138.1553720927502; Wed, 27 Mar 2019 14:08:47 -0700 (PDT) Received: from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l69sm19421348pga.73.2019.03.27.14.08.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 14:08:46 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>, Stephen Hemminger <sthemmin@microsoft.com> Date: Wed, 27 Mar 2019 14:08:42 -0700 Message-Id: <20190327210843.13813-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190327210843.13813-1-stephen@networkplumber.org> References: <20190327210843.13813-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 1/2] net/netvsc: fix lgtm static checker complaint X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190327210842.2xhL0qvFCOz_VT5INAGrycrBkficIOJl0TC8AYnMtrI@z> Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> --- drivers/net/netvsc/hn_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 6197118b01ee..8818d68cea5c 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -123,7 +123,7 @@ hn_update_packet_stats(struct hn_stats *stats, const struct rte_mbuf *m) stats->size_bins[0]++; else if (s < 1519) stats->size_bins[6]++; - else if (s >= 1519) + else stats->size_bins[7]++; } -- 2.17.1