From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id D1EE411A4 for <dev@dpdk.org>; Wed, 27 Mar 2019 22:08:49 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id p19so3888031plo.2 for <dev@dpdk.org>; Wed, 27 Mar 2019 14:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bU00agEhrD4aYp2fEzpgv+uNQ8jBm+OvLPwPAhBnZr4=; b=mP9FZUpAQu5pV4zsg2HHcb1o6/Ia8HkHDyKhAjdesudS/5ZYu0Vv8V9W1MuyI9usK9 oa/SyRGZL8fEOjVg0vc5gipadPeGcUcCGvzS7m0Au+iGnTDF9VQQwm8rXJy3bcWKLaoq kSY0KVA4+ReYmkXVukUXk0vmrq04eGq1+xe5RPkG+pvl+pq3yoVXP6QfNlitpEL3IJiP bYhTNbD7UxnhmGFuieN11ap77xH+l8Yhn/dbcFfTjyr4C1Ze1mXsKCFE4dDAs52Q3qdl IxgwRqTQKmAPC7n0VqIeFWavG7RZRregCy1yz8RHpjKvTtD6NbC0UGL4Qwq8LoH5OEy7 0vWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bU00agEhrD4aYp2fEzpgv+uNQ8jBm+OvLPwPAhBnZr4=; b=hBwO8hBHX2xGEL5/d5xIvRE2lDJZRB6EZ1aZHBcgwVZzwIqISDgCd3soJlEqcZRcll n6Ih/A8QUkkN4GSNX7EVs5Du0sn50S3N2Iik/5oDbtkdTaW49klLyzN9xrXG8Ad2dSeP siWgzJuQn7l7WbkBuVOZH+UMkIMc46I7mYDiFpvEkCo0SybxQPIMeOFFmVil5hW7jyVG MEnr3NU+vdwm7uExfyBbiE1fWsiACDAXg5lfW2ztPfe6Qwre+d32EpNh22ZjgWtQJwzR LOoGFLEFwQIDQ+urZUVm7PMuNGaQu3lSW85BdSt58e/QhWp1lLWLdN+ElRfD+f1XPkIF K+HA== X-Gm-Message-State: APjAAAUSvXgid7TDuIhJYAQVhS/M7pcFFPlR1PLUmjE7BiIJOyu+ebGJ C2UBrWvOjP0/b0q62QjFqYUX0g== X-Google-Smtp-Source: APXvYqx9jFzU6AipESfx9iDVV7YMb1RtVd1HpWpvsBMW91UGqh0OflK+hI8wJB7wj3TxNof4TynBzw== X-Received: by 2002:a17:902:241:: with SMTP id 59mr3876791plc.79.1553720929110; Wed, 27 Mar 2019 14:08:49 -0700 (PDT) Received: from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l69sm19421348pga.73.2019.03.27.14.08.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 14:08:48 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org> Date: Wed, 27 Mar 2019 14:08:43 -0700 Message-Id: <20190327210843.13813-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190327210843.13813-1-stephen@networkplumber.org> References: <20190327210843.13813-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 2/2] net/virtio: fix lgtm static checker complaint X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 27 Mar 2019 21:08:50 -0000 Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- drivers/net/virtio/virtio_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 5f6796bdba37..268fe3b8f156 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -1110,7 +1110,7 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) stats->size_bins[0]++; else if (s < 1519) stats->size_bins[6]++; - else if (s >= 1519) + else stats->size_bins[7]++; } -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F2E79A05D3 for <public@inbox.dpdk.org>; Wed, 27 Mar 2019 22:09:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 333AC4D27; Wed, 27 Mar 2019 22:08:54 +0100 (CET) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id D1EE411A4 for <dev@dpdk.org>; Wed, 27 Mar 2019 22:08:49 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id p19so3888031plo.2 for <dev@dpdk.org>; Wed, 27 Mar 2019 14:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bU00agEhrD4aYp2fEzpgv+uNQ8jBm+OvLPwPAhBnZr4=; b=mP9FZUpAQu5pV4zsg2HHcb1o6/Ia8HkHDyKhAjdesudS/5ZYu0Vv8V9W1MuyI9usK9 oa/SyRGZL8fEOjVg0vc5gipadPeGcUcCGvzS7m0Au+iGnTDF9VQQwm8rXJy3bcWKLaoq kSY0KVA4+ReYmkXVukUXk0vmrq04eGq1+xe5RPkG+pvl+pq3yoVXP6QfNlitpEL3IJiP bYhTNbD7UxnhmGFuieN11ap77xH+l8Yhn/dbcFfTjyr4C1Ze1mXsKCFE4dDAs52Q3qdl IxgwRqTQKmAPC7n0VqIeFWavG7RZRregCy1yz8RHpjKvTtD6NbC0UGL4Qwq8LoH5OEy7 0vWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bU00agEhrD4aYp2fEzpgv+uNQ8jBm+OvLPwPAhBnZr4=; b=hBwO8hBHX2xGEL5/d5xIvRE2lDJZRB6EZ1aZHBcgwVZzwIqISDgCd3soJlEqcZRcll n6Ih/A8QUkkN4GSNX7EVs5Du0sn50S3N2Iik/5oDbtkdTaW49klLyzN9xrXG8Ad2dSeP siWgzJuQn7l7WbkBuVOZH+UMkIMc46I7mYDiFpvEkCo0SybxQPIMeOFFmVil5hW7jyVG MEnr3NU+vdwm7uExfyBbiE1fWsiACDAXg5lfW2ztPfe6Qwre+d32EpNh22ZjgWtQJwzR LOoGFLEFwQIDQ+urZUVm7PMuNGaQu3lSW85BdSt58e/QhWp1lLWLdN+ElRfD+f1XPkIF K+HA== X-Gm-Message-State: APjAAAUSvXgid7TDuIhJYAQVhS/M7pcFFPlR1PLUmjE7BiIJOyu+ebGJ C2UBrWvOjP0/b0q62QjFqYUX0g== X-Google-Smtp-Source: APXvYqx9jFzU6AipESfx9iDVV7YMb1RtVd1HpWpvsBMW91UGqh0OflK+hI8wJB7wj3TxNof4TynBzw== X-Received: by 2002:a17:902:241:: with SMTP id 59mr3876791plc.79.1553720929110; Wed, 27 Mar 2019 14:08:49 -0700 (PDT) Received: from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l69sm19421348pga.73.2019.03.27.14.08.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 14:08:48 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org> Date: Wed, 27 Mar 2019 14:08:43 -0700 Message-Id: <20190327210843.13813-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190327210843.13813-1-stephen@networkplumber.org> References: <20190327210843.13813-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 2/2] net/virtio: fix lgtm static checker complaint X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190327210843.m1osaaOvJfgrLJ_2Lt2UUMm2Tvl8abbu68y4ofnUttQ@z> Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- drivers/net/virtio/virtio_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 5f6796bdba37..268fe3b8f156 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -1110,7 +1110,7 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) stats->size_bins[0]++; else if (s < 1519) stats->size_bins[6]++; - else if (s >= 1519) + else stats->size_bins[7]++; } -- 2.17.1