DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Gage Eads <gage.eads@intel.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com, arybchenko@solarflare.com,
	bruce.richardson@intel.com, konstantin.ananyev@intel.com,
	gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, nd@arm.com,
	chaozhu@linux.vnet.ibm.com, jerinj@marvell.com,
	hemant.agrawal@nxp.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange (x86-64 only)
Date: Thu, 28 Mar 2019 00:12:37 +0100	[thread overview]
Message-ID: <3387191.pRBmEOjPGs@xps> (raw)
Message-ID: <20190327231237.YO50mj-lqIouodKRfB7I9jHDzTbafesAJZTaowuQ4E4@z> (raw)
In-Reply-To: <20190304205133.2248-2-gage.eads@intel.com>

04/03/2019 21:51, Gage Eads:
> --- a/lib/librte_eal/common/include/generic/rte_atomic.h
> +++ b/lib/librte_eal/common/include/generic/rte_atomic.h
> +#if defined(RTE_ARCH_X86_64)
> +/**
> + * 128-bit integer structure.
> + */
> +RTE_STD_C11
> +typedef struct {
> +       RTE_STD_C11
> +       union {
> +               uint64_t val[2];
> +               __int128 int128;
> +       };
> +} __rte_aligned(16) rte_int128_t;

Why adding an arch-specific definition in a generic file?
Can we move it to the x86_64 file?



  reply	other threads:[~2019-03-27 23:12 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 17:29 [dpdk-dev] [PATCH 0/1] Add 128-bit compare and set Gage Eads
2019-01-28 17:29 ` [dpdk-dev] [PATCH 1/1] eal: add 128-bit cmpset (x86-64 only) Gage Eads
2019-01-28 23:01   ` Ola Liljedahl
2019-02-01 17:06     ` Eads, Gage
2019-02-01 19:01       ` Ola Liljedahl
2019-02-01 19:28         ` Eads, Gage
2019-02-01 19:43           ` Ola Liljedahl
2019-02-01 21:05             ` Eads, Gage
2019-02-01 23:11               ` Ola Liljedahl
2019-02-04 18:33       ` Honnappa Nagarahalli
2019-01-31  5:48   ` Honnappa Nagarahalli
2019-02-01 17:11     ` Eads, Gage
2019-02-22 15:46 ` [dpdk-dev] [PATCH v2 0/1] Add 128-bit compare and set Gage Eads
2019-02-22 15:46   ` [dpdk-dev] [PATCH v2 1/1] eal: add 128-bit cmpxchg (x86-64 only) Gage Eads
2019-03-04 20:19     ` Honnappa Nagarahalli
2019-03-04 20:47       ` Eads, Gage
2019-03-04 20:51   ` [dpdk-dev] [PATCH v3 0/1] Add 128-bit compare and set Gage Eads
2019-03-04 20:51     ` [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange (x86-64 only) Gage Eads
2019-03-27 23:12       ` Thomas Monjalon [this message]
2019-03-27 23:12         ` Thomas Monjalon
2019-03-28 16:22         ` Eads, Gage
2019-03-28 16:22           ` Eads, Gage
2019-04-03 17:34     ` [dpdk-dev] [PATCH v4 0/1] Add 128-bit compare and set Gage Eads
2019-04-03 17:34       ` Gage Eads
2019-04-03 17:34       ` [dpdk-dev] [PATCH v4 1/1] eal: add 128-bit compare exchange (x86-64 only) Gage Eads
2019-04-03 17:34         ` Gage Eads
2019-04-03 19:04         ` Thomas Monjalon
2019-04-03 19:04           ` Thomas Monjalon
2019-04-03 19:21           ` Eads, Gage
2019-04-03 19:21             ` Eads, Gage
2019-04-03 19:27             ` Thomas Monjalon
2019-04-03 19:27               ` Thomas Monjalon
2019-04-03 19:35 ` [dpdk-dev] [PATCH v5] eal/x86: add 128-bit atomic compare exchange Thomas Monjalon
2019-04-03 19:35   ` Thomas Monjalon
2019-04-03 19:44   ` [dpdk-dev] [PATCH v6] " Gage Eads
2019-04-03 19:44     ` Gage Eads
2019-04-03 20:01     ` Thomas Monjalon
2019-04-03 20:01       ` Thomas Monjalon
2019-04-04 11:47     ` Ferruh Yigit
2019-04-04 11:47       ` Ferruh Yigit
2019-04-04 12:08       ` Thomas Monjalon
2019-04-04 12:08         ` Thomas Monjalon
2019-04-04 12:12         ` Thomas Monjalon
2019-04-04 12:12           ` Thomas Monjalon
2019-04-04 12:14           ` Eads, Gage
2019-04-04 12:14             ` Eads, Gage
2019-04-04 12:18             ` Thomas Monjalon
2019-04-04 12:18               ` Thomas Monjalon
2019-04-04 12:22               ` Eads, Gage
2019-04-04 12:22                 ` Eads, Gage
2019-04-04 12:24               ` Eads, Gage
2019-04-04 12:24                 ` Eads, Gage
2019-04-04 12:52               ` Ferruh Yigit
2019-04-04 12:52                 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3387191.pRBmEOjPGs@xps \
    --to=thomas@monjalon.net \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=gavin.hu@arm.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).