Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows

[Anand Rawat <anand.rawat@intel.com>]

On 3/27/2019 7:30 PM, Varghese, Vipin wrote:
> Hi Anand,
> 
> snipped
>>
>> Adding sys/queue.h on windows for supporting common code.
>> This is implementation has BSD-3-Clause licensing.
>>
>> Signed-off-by: Ranjit Menon <ranjit.menon@intel.com>
>> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
>> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
>> ---
>>   .../windows/eal/include/sys/queue.h           | 320 ++++++++++++++++++
>>   1 file changed, 320 insertions(+)
>>   create mode 100644 lib/librte_eal/windows/eal/include/sys/queue.h
>>
>> diff --git a/lib/librte_eal/windows/eal/include/sys/queue.h
>> b/lib/librte_eal/windows/eal/include/sys/queue.h
>> new file mode 100644
>> index 000000000..5ee4916ad
>> --- /dev/null
>> +++ b/lib/librte_eal/windows/eal/include/sys/queue.h
>> @@ -0,0 +1,320 @@
>> +/*-
>> + * SPDX-License-Identifier: BSD-3-Clause
>> + *
>> + * Copyright (c) 1991, 1993
>> + *	The Regents of the University of California.  All rights reserved.
>> + *
>> + * Redistribution and use in source and binary forms, with or without
>> + * modification, are permitted provided that the following conditions
>> + * are met:
>> + * 1. Redistributions of source code must retain the above copyright
>> + *    notice, this list of conditions and the following disclaimer.
>> + * 2. Redistributions in binary form must reproduce the above copyright
>> + *    notice, this list of conditions and the following disclaimer in the
>> + *    documentation and/or other materials provided with the distribution.
>> + * 3. Neither the name of the University nor the names of its contributors
>> + *    may be used to endorse or promote products derived from this software
>> + *    without specific prior written permission.
>> + *
>> + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS''
>> AND
>> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>> THE
>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
>> PARTICULAR PURPOSE
>> + * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE
>> LIABLE
>> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>> CONSEQUENTIAL
>> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>> SUBSTITUTE GOODS
>> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>> INTERRUPTION)
>> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>> CONTRACT, STRICT
>> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
>> ANY WAY
>> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
>> OF
>> + * SUCH DAMAGE.
>> + *
>> + */
> 
> Can you help me understand why this should not be
> ```
> # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2017 Intel Corporation
> +# Copyright(c) 2017-2019 Intel Corporation
> ```
> 
> snipped
> 

 From my understanding of licenses, this code did not originate or even 
modified at Intel to contain Intel copyright statement.

-- 
Anand Rawat