From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 79BE0A05D3 for ; Thu, 28 Mar 2019 03:39:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A79345F29; Thu, 28 Mar 2019 03:39:46 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 332523772 for ; Thu, 28 Mar 2019 03:39:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 19:39:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,278,1549958400"; d="scan'208";a="135421283" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by fmsmga008.fm.intel.com with ESMTP; 27 Mar 2019 19:39:43 -0700 To: "Varghese, Vipin" , "dev@dpdk.org" Cc: "Kadam, Pallavi" , "Menon, Ranjit" , "Shaw, Jeffrey B" , "Richardson, Bruce" , "thomas@monjalon.net" References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328022115.4660-1-anand.rawat@intel.com> <20190328022115.4660-5-anand.rawat@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D326E11@BGSMSX101.gar.corp.intel.com> From: Anand Rawat Message-ID: <97d7130f-5bce-f1ad-40e1-a067901c2993@intel.com> Date: Wed, 27 Mar 2019 19:39:43 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D326E11@BGSMSX101.gar.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190328023943.6fU0ryim7Hcu4mHl5sJHfOGfYdcMhgXksrtUhxHdeks@z> On 3/27/2019 7:30 PM, Varghese, Vipin wrote: > Hi Anand, > > snipped >> >> Adding sys/queue.h on windows for supporting common code. >> This is implementation has BSD-3-Clause licensing. >> >> Signed-off-by: Ranjit Menon >> Signed-off-by: Anand Rawat >> Reviewed-by: Jeff Shaw >> --- >> .../windows/eal/include/sys/queue.h | 320 ++++++++++++++++++ >> 1 file changed, 320 insertions(+) >> create mode 100644 lib/librte_eal/windows/eal/include/sys/queue.h >> >> diff --git a/lib/librte_eal/windows/eal/include/sys/queue.h >> b/lib/librte_eal/windows/eal/include/sys/queue.h >> new file mode 100644 >> index 000000000..5ee4916ad >> --- /dev/null >> +++ b/lib/librte_eal/windows/eal/include/sys/queue.h >> @@ -0,0 +1,320 @@ >> +/*- >> + * SPDX-License-Identifier: BSD-3-Clause >> + * >> + * Copyright (c) 1991, 1993 >> + * The Regents of the University of California. All rights reserved. >> + * >> + * Redistribution and use in source and binary forms, with or without >> + * modification, are permitted provided that the following conditions >> + * are met: >> + * 1. Redistributions of source code must retain the above copyright >> + * notice, this list of conditions and the following disclaimer. >> + * 2. Redistributions in binary form must reproduce the above copyright >> + * notice, this list of conditions and the following disclaimer in the >> + * documentation and/or other materials provided with the distribution. >> + * 3. Neither the name of the University nor the names of its contributors >> + * may be used to endorse or promote products derived from this software >> + * without specific prior written permission. >> + * >> + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' >> AND >> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, >> THE >> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A >> PARTICULAR PURPOSE >> + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE >> LIABLE >> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >> CONSEQUENTIAL >> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF >> SUBSTITUTE GOODS >> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS >> INTERRUPTION) >> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN >> CONTRACT, STRICT >> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN >> ANY WAY >> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY >> OF >> + * SUCH DAMAGE. >> + * >> + */ > > Can you help me understand why this should not be > ``` > # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2017 Intel Corporation > +# Copyright(c) 2017-2019 Intel Corporation > ``` > > snipped > From my understanding of licenses, this code did not originate or even modified at Intel to contain Intel copyright statement. -- Anand Rawat