Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check

[Ali Alnubani <alialnu@mellanox.com>]

Hi Ferruh,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Wednesday, March 27, 2019 11:31 AM
> To: Shahaf Shuler <shahafs@mellanox.com>; Dekel Peled
> <dekelp@mellanox.com>; Ali Alnubani <alialnu@mellanox.com>;
> dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check
> 
> On 3/25/2019 12:02 PM, Ferruh Yigit wrote:
> > On 3/24/2019 9:26 AM, Shahaf Shuler wrote:
> >> Thursday, March 21, 2019 11:34 AM, Dekel Peled:
> >>> Subject: RE: [PATCH] net/mlx5: add missing return value check
> >>>
> >>>> -----Original Message-----
> >>>> From: Ali Alnubani
> >>>> Sent: Thursday, March 21, 2019 11:07 AM
> >>>> To: dev@dpdk.org
> >>>> Cc: Shahaf Shuler <shahafs@mellanox.com>; Dekel Peled
> >>>> <dekelp@mellanox.com>
> >>>> Subject: [PATCH] net/mlx5: add missing return value check
> >>>>
> >>>> Fixes: d86406b965df ("net/mlx5: support new representor naming
> >>>> format")
> >>>> Cc: dekelp@mellanox.com
> >>>>
> >>>> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> >>
> >> Applied to next-net-mlx, thanks.
> >>
> >
> > Squashed into relevant commit [1] in next-net, thanks.
> >
> > [1]
> > net/mlx5: support new representor naming format
> >
> 
> 'main' repo get the original patch without squash, so can't squash now,
> merged as a incremental patch ...
> 
> Applied to dpdk-next-net/master, thanks.

A more detailed commit body:

This patch fixes the build failure with message:
    drivers/net/mlx5/mlx5_ethdev.c: In function ‘mlx5_sysfs_switch_info’:
    drivers/net/mlx5/mlx5_ethdev.c:1381:3: error: ignoring return value
    of ‘fscanf’, declared with attribute warn_unused_result [-Werror=unused-result]
    fscanf(file, "%s", port_name);
    ^
Which reproduces on Ubuntu 16.04 LTS with
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609.

Fixes: b2f3a3810125 ("net/mlx5: support new representor naming format")

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Dekel Peled <dekelp@mellanox.com>


Thanks,
Ali