DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] raw/ifpga: modify log output
@ 2019-03-27  1:32 Andy Pei
  2019-03-27  1:32 ` Andy Pei
  2019-03-28 14:25 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  0 siblings, 2 replies; 6+ messages in thread
From: Andy Pei @ 2019-03-27  1:32 UTC (permalink / raw)
  To: dev; +Cc: andy.pei, rosen.xu, stable

print function name in ifpga log and a new line goes after every IFPGA log.

Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Cc: rosen.xu@intel.com
Cc: andy.pei@intel.com
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
index c7759b8..234ce36 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
@@ -8,8 +8,8 @@
 extern int ifpga_rawdev_logtype;
 
 #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \
-	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \
-		##args)
+	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \
+				__func__, ##args)
 
 #define IFPGA_RAWDEV_PMD_FUNC_TRACE() IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>")
 
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2] raw/ifpga: modify log output
  2019-03-27  1:32 [dpdk-dev] [PATCH v2] raw/ifpga: modify log output Andy Pei
@ 2019-03-27  1:32 ` Andy Pei
  2019-03-28 14:25 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  1 sibling, 0 replies; 6+ messages in thread
From: Andy Pei @ 2019-03-27  1:32 UTC (permalink / raw)
  To: dev; +Cc: andy.pei, rosen.xu, stable

print function name in ifpga log and a new line goes after every IFPGA log.

Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Cc: rosen.xu@intel.com
Cc: andy.pei@intel.com
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
index c7759b8..234ce36 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
@@ -8,8 +8,8 @@
 extern int ifpga_rawdev_logtype;
 
 #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \
-	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \
-		##args)
+	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \
+				__func__, ##args)
 
 #define IFPGA_RAWDEV_PMD_FUNC_TRACE() IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>")
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga: modify log output
  2019-03-27  1:32 [dpdk-dev] [PATCH v2] raw/ifpga: modify log output Andy Pei
  2019-03-27  1:32 ` Andy Pei
@ 2019-03-28 14:25 ` Ferruh Yigit
  2019-03-28 14:25   ` Ferruh Yigit
  1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-03-28 14:25 UTC (permalink / raw)
  To: Andy Pei, dev; +Cc: rosen.xu, stable

On 3/27/2019 1:32 AM, Andy Pei wrote:
> print function name in ifpga log and a new line goes after every IFPGA log.
> 
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Cc: rosen.xu@intel.com
> Cc: andy.pei@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>

(Carrying ack from other other thread)

Reviewed-by: Rosen Xu <rosen.xu@intel.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga: modify log output
  2019-03-28 14:25 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-03-28 14:25   ` Ferruh Yigit
  0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-03-28 14:25 UTC (permalink / raw)
  To: Andy Pei, dev; +Cc: rosen.xu, stable

On 3/27/2019 1:32 AM, Andy Pei wrote:
> print function name in ifpga log and a new line goes after every IFPGA log.
> 
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Cc: rosen.xu@intel.com
> Cc: andy.pei@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>

(Carrying ack from other other thread)

Reviewed-by: Rosen Xu <rosen.xu@intel.com>

Applied to dpdk-next-net/master, thanks.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga: modify log output
  2019-03-20  8:16   ` [dpdk-dev] [PATCH v2] " Xu, Rosen
@ 2019-03-20 11:11     ` Ferruh Yigit
  2019-03-20 11:11       ` Ferruh Yigit
  0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-03-20 11:11 UTC (permalink / raw)
  To: Xu, Rosen, Pei, Andy, dev; +Cc: stable

On 3/20/2019 8:16 AM, Xu, Rosen wrote:
> 
> 
>> -----Original Message-----
>> From: Pei, Andy
>> Sent: Wednesday, March 20, 2019 16:03
>> To: dev@dpdk.org
>> Cc: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>;
>> stable@dpdk.org
>> Subject: [PATCH v2] raw/ifpga: modify log output
>>
>> print function name in ifpga log and a new line goes after every IFPGA log.
>>
>> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
>> Cc: rosen.xu@intel.com
>> Cc: andy.pei@intel.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andy Pei <andy.pei@intel.com>
>> ---
>>  drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
>> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
>> index c7759b8..234ce36 100644
>> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
>> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
>> @@ -8,8 +8,8 @@
>>  extern int ifpga_rawdev_logtype;
>>
>>  #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \
>> -	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \
>> -		##args)
>> +	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \
>> +				__func__, ##args)
>>
>>  #define IFPGA_RAWDEV_PMD_FUNC_TRACE()
>> IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>")
>>
>> --
>> 1.8.3.1
> 
> Reviewed-by: Rosen Xu <rosen.xu@intel.com>
> 

Hi Rosen, Andy,

I don't see the v2 in dev or stable mail list & patchwork. Can you please
re-send it?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga: modify log output
  2019-03-20 11:11     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-03-20 11:11       ` Ferruh Yigit
  0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-03-20 11:11 UTC (permalink / raw)
  To: Xu, Rosen, Pei, Andy, dev; +Cc: stable

On 3/20/2019 8:16 AM, Xu, Rosen wrote:
> 
> 
>> -----Original Message-----
>> From: Pei, Andy
>> Sent: Wednesday, March 20, 2019 16:03
>> To: dev@dpdk.org
>> Cc: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>;
>> stable@dpdk.org
>> Subject: [PATCH v2] raw/ifpga: modify log output
>>
>> print function name in ifpga log and a new line goes after every IFPGA log.
>>
>> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
>> Cc: rosen.xu@intel.com
>> Cc: andy.pei@intel.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andy Pei <andy.pei@intel.com>
>> ---
>>  drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
>> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
>> index c7759b8..234ce36 100644
>> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
>> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
>> @@ -8,8 +8,8 @@
>>  extern int ifpga_rawdev_logtype;
>>
>>  #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \
>> -	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \
>> -		##args)
>> +	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \
>> +				__func__, ##args)
>>
>>  #define IFPGA_RAWDEV_PMD_FUNC_TRACE()
>> IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>")
>>
>> --
>> 1.8.3.1
> 
> Reviewed-by: Rosen Xu <rosen.xu@intel.com>
> 

Hi Rosen, Andy,

I don't see the v2 in dev or stable mail list & patchwork. Can you please
re-send it?

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-03-28 14:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-27  1:32 [dpdk-dev] [PATCH v2] raw/ifpga: modify log output Andy Pei
2019-03-27  1:32 ` Andy Pei
2019-03-28 14:25 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-28 14:25   ` Ferruh Yigit
  -- strict thread matches above, loose matches on Subject: below --
2019-03-14  9:47 [dpdk-dev] [PATCH] " Andy Pei
     [not found] ` <1553069009-64692-1-git-send-email-andy.pei@intel.com>
2019-03-20  8:16   ` [dpdk-dev] [PATCH v2] " Xu, Rosen
2019-03-20 11:11     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-20 11:11       ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).