From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D2B59A05D3 for ; Fri, 29 Mar 2019 14:57:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 147523572; Fri, 29 Mar 2019 14:57:25 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 955242BF4 for ; Fri, 29 Mar 2019 14:57:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 28FB2219AA; Fri, 29 Mar 2019 09:57:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 29 Mar 2019 09:57:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=p2lKX4L/0BjRFWXshJ3k4fi+h5Fbuc8YHhKw31nUA7w=; b=TnUFsOhj2+i1 t1+5RCA9x/ryru/WFiO4WrfMR2pBh23M3UXhGOjWK8HSk8/UVb/Z5Z7eFD5IrgUg moLM3+hODo+FpC33vGr+1lHpmv3hlsCoRDzh2fTi5fj3mfAZtBLlQuxrh8ZK5HmB m17ApkqqASUKMBsFOCP9DjEmgjrWvI8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=p2lKX4L/0BjRFWXshJ3k4fi+h5Fbuc8YHhKw31nUA 7w=; b=6OcPAR/VJsKeCw9dNVq1p+hrPrPCj4nY75jo4U46+Wox8tdz1cR/O5yDr 7N2E2yhZDWuNdfCJQiozNXVc6mt5ilqR2EqXDymbvEbjmDLqbnZYi2SLmOyU0o4/ y+qRCJWHWOCC+UCIBn+QNGYQJwyI5vO3FrlvLw1J2AUDlGSOUyV3Ku/QvRYmQ4X2 vfhG9FcAJ5wuI5MXlsA3F9RW5RHvKu0xD2VoLISmoTJUxrUWJBC1G8pQlkGBLu3R jmGC50cYPZ4YWCe2jUXIleHTbtsZ8k5h8Bm2pajwUnTI2aqaeFwcV8yY1XOuoRjG zsP8zJ8hdEMuYqnw64Pn1ro6fH1Jg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeejgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E056B1031A; Fri, 29 Mar 2019 09:57:20 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org, Bruce Richardson , "gavin.hu@arm.com" , Pavan Nikhilesh Bhagavatula , hemant.agrawal@nxp.com, honnappa.nagarahalli@arm.com, Yongseok Koh Date: Fri, 29 Mar 2019 14:57:19 +0100 Message-ID: <3635349.6jznIY6G22@xps> In-Reply-To: <20190319094043.GA318652@bricha3-MOBL.ger.corp.intel.com> References: <20190224181041.27127-1-jerinj@marvell.com> <20190318164949.2357-2-jerinj@marvell.com> <20190319094043.GA318652@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 2/4] meson: add infra to support machine specific flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190329135719.CDQ-AlOGsHRWfBqYQ-k3BhnGKqjMuZe2t3FnvG8mjq4@z> 19/03/2019 10:40, Bruce Richardson: > On Mon, Mar 18, 2019 at 04:50:16PM +0000, Jerin Jacob Kollanukkaran wrote: > > From: Pavan Nikhilesh > > > > Currently, RTE_* flags are set based on the implementer ID but there might > > be some micro arch specific differences from the same vendor > > eg. CACHE_LINESIZE. Add support to set micro arch specific flags. > > > > Signed-off-by: Pavan Nikhilesh > > Signed-off-by: Jerin Jacob > > --- > > config/arm/meson.build | 37 ++++++++++++++++++++++++++++++++----- > > 1 file changed, 32 insertions(+), 5 deletions(-) > > > This looks ok to me, but I think review and ack from another Arm vendor > would be good to have. Adding Cc's for more reviews