From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Hajkowski <marcinx.hajkowski@intel.com>,
david.hunt@intel.com
Cc: stable@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification
Date: Fri, 29 Mar 2019 15:09:09 +0000 [thread overview]
Message-ID: <fe336745-19bc-8a65-77c8-c5782696875d@intel.com> (raw)
Message-ID: <20190329150909.7PsGhN-e__p53NA5FWmBr8fpVrwk8EDw4MnFXze-Ujc@z> (raw)
In-Reply-To: <3804007.JU0OzdjkKo@xps>
On 29-Mar-19 2:14 PM, Thomas Monjalon wrote:
> 18/03/2019 12:56, Hajkowski:
>> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
>> --- a/doc/guides/rel_notes/release_19_05.rst
>> +++ b/doc/guides/rel_notes/release_19_05.rst
>> @@ -120,6 +120,8 @@ API Changes
>> + * power: ``rte_power_set_env`` and ``rte_power_unset_env`` functions
>> + have been modified to be thread safe.
>
> The deprecation notice was recently sent,
> so I guess this patch is for DPDK 19.08.
Yes, this is changing API so the target was 19.08. However, first patch
is a fix and can be applied to 19.05 as well. The API documentation
stated that the function was not thread safe, but the code itself was
thread safe (it wasn't because it was buggy, but the intention of being
thread safe was there), so this could be considered fixing docs to match
the intended behavior of the code.
>
> Review from the maintainer (David) may help.
> Thanks
>
>
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-03-29 15:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 11:56 [dpdk-dev] " Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 2/4] power: return error in set env when power env already set Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 3/4] power: reset function pointers on unset env Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-19 10:58 ` Burakov, Anatoly
2019-03-19 10:58 ` Burakov, Anatoly
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 4/4] power: add UTs for all power env types Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-19 11:58 ` Burakov, Anatoly
2019-03-19 11:58 ` Burakov, Anatoly
2019-03-18 15:01 ` [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification Stephen Hemminger
2019-03-18 15:01 ` Stephen Hemminger
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-29 14:14 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-03-29 14:14 ` Thomas Monjalon
2019-03-29 15:09 ` Burakov, Anatoly [this message]
2019-03-29 15:09 ` Burakov, Anatoly
2020-10-25 18:22 ` Thomas Monjalon
2020-10-28 13:53 ` David Hunt
2020-10-28 14:16 ` Thomas Monjalon
2019-04-05 14:35 ` [dpdk-dev] [PATCH] " Hajkowski
2019-04-05 14:35 ` Hajkowski
2019-04-22 20:22 ` Thomas Monjalon
2019-04-22 20:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe336745-19bc-8a65-77c8-c5782696875d@intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=marcinx.hajkowski@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).