From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0C0C4A05D3 for ; Fri, 29 Mar 2019 16:09:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 214E13772; Fri, 29 Mar 2019 16:09:19 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 887D73572; Fri, 29 Mar 2019 16:09:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2019 08:09:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,284,1549958400"; d="scan'208";a="156981219" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.103]) ([10.237.220.103]) by fmsmga004.fm.intel.com with ESMTP; 29 Mar 2019 08:09:09 -0700 To: Thomas Monjalon , Hajkowski , david.hunt@intel.com Cc: stable@dpdk.org, dev@dpdk.org References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> <3804007.JU0OzdjkKo@xps> From: "Burakov, Anatoly" Message-ID: Date: Fri, 29 Mar 2019 15:09:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <3804007.JU0OzdjkKo@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190329150909.7PsGhN-e__p53NA5FWmBr8fpVrwk8EDw4MnFXze-Ujc@z> On 29-Mar-19 2:14 PM, Thomas Monjalon wrote: > 18/03/2019 12:56, Hajkowski: >> From: Marcin Hajkowski >> --- a/doc/guides/rel_notes/release_19_05.rst >> +++ b/doc/guides/rel_notes/release_19_05.rst >> @@ -120,6 +120,8 @@ API Changes >> + * power: ``rte_power_set_env`` and ``rte_power_unset_env`` functions >> + have been modified to be thread safe. > > The deprecation notice was recently sent, > so I guess this patch is for DPDK 19.08. Yes, this is changing API so the target was 19.08. However, first patch is a fix and can be applied to 19.05 as well. The API documentation stated that the function was not thread safe, but the code itself was thread safe (it wasn't because it was buggy, but the intention of being thread safe was there), so this could be considered fixing docs to match the intended behavior of the code. > > Review from the maintainer (David) may help. > Thanks > > > -- Thanks, Anatoly