Re: [dpdk-dev] [PATCH v3 0/4] adding rsa priv key feature flag

[Ayuj Verma <ayverma@marvell.com>]

Hi Akhil,


Thanks.

Please add relevant information in the description in future.

Sure will keep this in mind.


Thanks and regards

Ayuj Verma

________________________________
From: Akhil Goyal <akhil.goyal@nxp.com>
Sent: 29 March 2019 20:47:33
To: Ayuj Verma
Cc: arkadiuszx.kusztal@intel.com; Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/4] adding rsa priv key feature flag



On 3/28/2019 3:57 PM, Ayuj Verma wrote:
> Some PMDs can support RSA private key operations using CRT
> (quintuple) or exponent key only. Thus add a feature flag
> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and
> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key
> type is supported to perform rsa private key op.
>
> App should query PMD feature flag to check if specific
> key type is supported and call operation with relevant key type.
>
> Changes in v3:
>          - Rebase changes on top of latest unit test application
>          - add feature flag description in documentation
>
> Changes in v2:
>          - RSA key type feature flags exponenet and quintuple,
>            in place of making them part of xform capabilities.
>
> Ayuj Verma (4):
>    lib/cryptodev: add rsa priv key feature flag
>    crypto/openssl: set rsa private op feature flag
>    app/test: check for key type ff in asym unit test
>    doc: add rsa key type to feature list
>
>   app/test/test_cryptodev_asym.c             | 26 ++++++++++++++++++++++++++
>   doc/guides/cryptodevs/features/openssl.ini |  2 ++
>   doc/guides/cryptodevs/overview.rst         |  6 ++++++
>   drivers/crypto/openssl/rte_openssl_pmd.c   |  4 +++-
>   lib/librte_cryptodev/rte_cryptodev.c       |  4 ++++
>   lib/librte_cryptodev/rte_cryptodev.h       |  4 ++++
>   6 files changed, 45 insertions(+), 1 deletion(-)
>
Applied to dpdk-next-crypto

4th patch squashed to 1st and 2nd.
Also added description for 3rd patch. Please add relevant information in
the description in future.

Thanks.