From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 028F8A05D3 for ; Fri, 29 Mar 2019 19:59:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 778A32BD3; Fri, 29 Mar 2019 19:59:07 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C856C11A4 for ; Fri, 29 Mar 2019 19:59:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2019 11:59:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,285,1549958400"; d="scan'208";a="157038207" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by fmsmga004.fm.intel.com with ESMTP; 29 Mar 2019 11:59:02 -0700 To: Rosen Xu , dev@dpdk.org Cc: tianfei.zhang@intel.com, dan.wei@intel.com, andy.pei@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com, santos.chen@intel.com, zhang.zhang@intel.com References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com> <1553875099-166351-1-git-send-email-rosen.xu@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <620ed7cb-9402-d964-27e7-a556a8774200@intel.com> Date: Fri, 29 Mar 2019 18:59:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1553875099-166351-1-git-send-email-rosen.xu@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 00/15] Add patch set for IPN3KE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190329185902.4trEwM9dV-AkiL_CxOeQeaNI5N7B92KGIiBXMUE2Ovs@z> On 3/29/2019 3:58 PM, Rosen Xu wrote: > v2 updates: > ========== > - Fix v1 comments > - Add support for 10G Base Line Design Bitstream > - Add support for 25G Base Line Design Bitstream > > This patch set adds the support of a new net PMD, Intel® FPGA Programmable > Acceleration Card N3000, also called ipn3ke. > > The ipn3ke PMD (librte_pmd_ipn3ke) provides poll mode driver support > for Intel® FPGA PAC(Programmable Acceleration Card) N3000 based on > the Intel Ethernet Controller X710/XXV710 and Intel Arria 10 FPGA. > > In this card, FPGA is an acceleration bridge between network interface > and the Intel Ethernet Controller. Although both FPGA and Ethernet > Controllers are connected to CPU with PCIe Gen3x16 Switch, all the > packet RX/TX is handled by Intel Ethernet Controller. So from application > point of view the data path is still the legacy Intel Ethernet Controller > X710/XXV710 PMD. Besides this, users can enable more acceleration > features by FPGA IP. > > Rosen Xu (7): > drivers/bus/ifpga: add AFU shared data > drivers/bus/ifpga: add function for AFU search by name > drivers/net/ipn3ke: add IPN3KE ethdev PMD driver > drivers/net/ipn3ke: add IPN3KE representor of PMD driver > drivers/net/ipn3ke: add IPN3KE TM of PMD driver > drivers/net/ipn3ke: add IPN3KE Flow of PMD driver > drivers/raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev > > Zhang, Tianfei (8): > raw/ifpga/base: clean up code for ifpga share code > raw/ifpga/base: store private features in FME and Port list > raw/ifpga/base: add SPI and MAX10 device driver > raw/ifpga/base: add I2C and at24 EEPROM driver > raw/ifpga/base: add eth group driver > raw/ifpga/base: add device tree support > raw/ifpga/base: add version description on README > raw/ifpga/base: using prefix name "ifpga_" for feature and feature_ops > data struct Hi Rosen, I am seeing some build errors, for 32bit [1], cross compilation [2] and linkage errors [3], can you please check them? Is "libfdt.h" dependency in [2] documented in driver doc? [1] Building i686-native-linuxapp-gcc ... .../dpdk/drivers/net/ipn3ke/ipn3ke_ethdev.c: In function ‘ipn3ke_indirect_read’: .../dpdk/drivers/net/ipn3ke/ipn3ke_ethdev.c:68:19: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] indirect_addrs = (volatile void *)(base_addr | 0x10); ^ .../dpdk/drivers/net/ipn3ke/ipn3ke_ethdev.c:76:19: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] indirect_addrs = (volatile void *)(base_addr | 0x18); ^ .../dpdk/drivers/net/ipn3ke/ipn3ke_ethdev.c: In function ‘ipn3ke_indirect_write’: .../dpdk/drivers/net/ipn3ke/ipn3ke_ethdev.c:118:19: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] indirect_addrs = (volatile void *)(base_addr | 0x10); ^ cc1: all warnings being treated as errors make[7]: *** [.../dpdk/mk/internal/rte.compile-pre.mk:116: ipn3ke_ethdev.o] Error 1 make[7]: *** Waiting for unfinished jobs.... In file included from .../dpdk/drivers/net/ipn3ke/ipn3ke_representor.c:25: .../dpdk/drivers/net/ipn3ke/ipn3ke_representor.c: In function ‘ipn3ke_update_link’: .../dpdk/drivers/net/ipn3ke/ipn3ke_logs.h:13:49: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=] rte_log(RTE_LOG_ ## level, ipn3ke_afu_logtype, "ipn3ke_afu: " fmt, \ ^~~~~~~~~~~~~~ .../dpdk/drivers/net/ipn3ke/ipn3ke_logs.h:19:2: note: in expansion of macro ‘IPN3KE_AFU_PMD_LOG’ IPN3KE_AFU_PMD_LOG(DEBUG, fmt, ## args) ^~~~~~~~~~~~~~~~~~ .../dpdk/drivers/net/ipn3ke/ipn3ke_representor.c:388:2: note: in expansion of macro ‘IPN3KE_AFU_PMD_DEBUG’ IPN3KE_AFU_PMD_DEBUG("line_link_bitmap is %lx\n", line_link_bitmap); ^~~~~~~~~~~~~~~~~~~~ .../dpdk/drivers/net/ipn3ke/ipn3ke_representor.c:388:46: note: format string is defined here IPN3KE_AFU_PMD_DEBUG("line_link_bitmap is %lx\n", line_link_bitmap); ~~^ %llx cc1: all warnings being treated as errors [2] .../dpdk/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c:6:10: fatal error: libfdt.h: No such file or directory #include ^~~~~~~~~~ [3] /usr/bin/ld: ipn3ke_representor.o: in function `ipn3ke_rpst_init': ipn3ke_representor.c:(.text+0xc8b): undefined reference to `pthread_create' /usr/bin/ld: ipn3ke_representor.c:(.text+0xca8): undefined reference to `pthread_cancel' /usr/bin/ld: ipn3ke_representor.c:(.text+0xcbe): undefined reference to `pthread_join' /usr/bin/ld: ipn3ke_representor.o: in function `ipn3ke_rpst_uninit': ipn3ke_representor.c:(.text+0xd6b): undefined reference to `pthread_create' /usr/bin/ld: ipn3ke_representor.c:(.text+0xd88): undefined reference to `pthread_cancel' /usr/bin/ld: ipn3ke_representor.c:(.text+0xd9e): undefined reference to `pthread_join' collect2: error: ld returned 1 exit status /usr/bin/ld: ipn3ke_representor.o: in function `ipn3ke_rpst_init': ipn3ke_representor.c:(.text+0xc8b): undefined reference to `pthread_create' /usr/bin/ld: ipn3ke_representor.c:(.text+0xca8): undefined reference to `pthread_cancel' /usr/bin/ld: ipn3ke_representor.c:(.text+0xcbe): undefined reference to `pthread_join' /usr/bin/ld: ipn3ke_representor.o: in function `ipn3ke_rpst_uninit': ipn3ke_representor.c:(.text+0xd6b): undefined reference to `pthread_create' /usr/bin/ld: ipn3ke_representor.c:(.text+0xd88): undefined reference to `pthread_cancel' /usr/bin/ld: ipn3ke_representor.c:(.text+0xd9e): undefined reference to `pthread_join' collect2: error: ld returned 1 exit status